mirror of
https://github.com/containers/podman.git
synced 2025-12-02 02:58:03 +08:00
34235b2726
Fix two bugs in `system df`:
1. The total size was calculated incorrectly as it was creating the sum
of all image sizes but did not consider that a) the same image may
be listed more than once (i.e., for each repo-tag pair), and that
b) images share layers.
The total size is now calculated directly in `libimage` by taking
multi-layer use into account.
2. The reclaimable size was calculated incorrectly. This number
indicates which data we can actually remove which means the total
size minus what containers use (i.e., the "unique" size of the image
in use by containers).
NOTE: The c/storage version is pinned back to the previous commit as it
is buggy. c/common already requires the buggy version, so use a
`replace` to force/pin.
Fixes: #16135
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
72 lines
1.5 KiB
Go
72 lines
1.5 KiB
Go
//go:build !linux
|
|
// +build !linux
|
|
|
|
package cgroups
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
|
|
spec "github.com/opencontainers/runtime-spec/specs-go"
|
|
)
|
|
|
|
type pidHandler struct{}
|
|
|
|
func getPidsHandler() *pidHandler {
|
|
return &pidHandler{}
|
|
}
|
|
|
|
// Apply set the specified constraints
|
|
func (c *pidHandler) Apply(ctr *CgroupControl, res *spec.LinuxResources) error {
|
|
if res.Pids == nil {
|
|
return nil
|
|
}
|
|
var PIDRoot string
|
|
|
|
if ctr.cgroup2 {
|
|
PIDRoot = filepath.Join(cgroupRoot, ctr.path)
|
|
} else {
|
|
PIDRoot = ctr.getCgroupv1Path(Pids)
|
|
}
|
|
|
|
p := filepath.Join(PIDRoot, "pids.max")
|
|
return os.WriteFile(p, []byte(fmt.Sprintf("%d\n", res.Pids.Limit)), 0o644)
|
|
}
|
|
|
|
// Create the cgroup
|
|
func (c *pidHandler) Create(ctr *CgroupControl) (bool, error) {
|
|
if ctr.cgroup2 {
|
|
return false, nil
|
|
}
|
|
return ctr.createCgroupDirectory(Pids)
|
|
}
|
|
|
|
// Destroy the cgroup
|
|
func (c *pidHandler) Destroy(ctr *CgroupControl) error {
|
|
return rmDirRecursively(ctr.getCgroupv1Path(Pids))
|
|
}
|
|
|
|
// Stat fills a metrics structure with usage stats for the controller
|
|
func (c *pidHandler) Stat(ctr *CgroupControl, m *Metrics) error {
|
|
if ctr.path == "" {
|
|
// nothing we can do to retrieve the pids.current path
|
|
return nil
|
|
}
|
|
|
|
var PIDRoot string
|
|
if ctr.cgroup2 {
|
|
PIDRoot = filepath.Join(cgroupRoot, ctr.path)
|
|
} else {
|
|
PIDRoot = ctr.getCgroupv1Path(Pids)
|
|
}
|
|
|
|
current, err := readFileAsUint64(filepath.Join(PIDRoot, "pids.current"))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
m.Pids = PidsMetrics{Current: current}
|
|
return nil
|
|
}
|