mirror of
https://github.com/containers/podman.git
synced 2025-06-01 00:45:22 +08:00

If user sets capabilities list we need handle minimal capabilities. Also handle seccomp-policy being passed in. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
149 lines
4.6 KiB
Go
149 lines
4.6 KiB
Go
package generate
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"github.com/containers/common/pkg/capabilities"
|
|
"github.com/containers/libpod/libpod"
|
|
"github.com/containers/libpod/libpod/image"
|
|
"github.com/containers/libpod/pkg/specgen"
|
|
"github.com/containers/libpod/pkg/util"
|
|
"github.com/opencontainers/runtime-tools/generate"
|
|
"github.com/opencontainers/selinux/go-selinux/label"
|
|
"github.com/pkg/errors"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
// setLabelOpts sets the label options of the SecurityConfig according to the
|
|
// input.
|
|
func setLabelOpts(s *specgen.SpecGenerator, runtime *libpod.Runtime, pidConfig specgen.Namespace, ipcConfig specgen.Namespace) error {
|
|
if !runtime.EnableLabeling() || s.Privileged {
|
|
s.SelinuxOpts = label.DisableSecOpt()
|
|
return nil
|
|
}
|
|
|
|
var labelOpts []string
|
|
if pidConfig.IsHost() {
|
|
labelOpts = append(labelOpts, label.DisableSecOpt()...)
|
|
} else if pidConfig.IsContainer() {
|
|
ctr, err := runtime.LookupContainer(pidConfig.Value)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "container %q not found", pidConfig.Value)
|
|
}
|
|
secopts, err := label.DupSecOpt(ctr.ProcessLabel())
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to duplicate label %q ", ctr.ProcessLabel())
|
|
}
|
|
labelOpts = append(labelOpts, secopts...)
|
|
}
|
|
|
|
if ipcConfig.IsHost() {
|
|
labelOpts = append(labelOpts, label.DisableSecOpt()...)
|
|
} else if ipcConfig.IsContainer() {
|
|
ctr, err := runtime.LookupContainer(ipcConfig.Value)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "container %q not found", ipcConfig.Value)
|
|
}
|
|
secopts, err := label.DupSecOpt(ctr.ProcessLabel())
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to duplicate label %q ", ctr.ProcessLabel())
|
|
}
|
|
labelOpts = append(labelOpts, secopts...)
|
|
}
|
|
|
|
s.SelinuxOpts = append(s.SelinuxOpts, labelOpts...)
|
|
return nil
|
|
}
|
|
|
|
func securityConfigureGenerator(s *specgen.SpecGenerator, g *generate.Generator, newImage *image.Image) error {
|
|
// HANDLE CAPABILITIES
|
|
// NOTE: Must happen before SECCOMP
|
|
if s.Privileged {
|
|
g.SetupPrivileged(true)
|
|
}
|
|
|
|
useNotRoot := func(user string) bool {
|
|
if user == "" || user == "root" || user == "0" {
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
configSpec := g.Config
|
|
var err error
|
|
var caplist []string
|
|
bounding := configSpec.Process.Capabilities.Bounding
|
|
if useNotRoot(s.User) {
|
|
configSpec.Process.Capabilities.Bounding = caplist
|
|
}
|
|
caplist, err = capabilities.MergeCapabilities(configSpec.Process.Capabilities.Bounding, s.CapAdd, s.CapDrop)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
privCapsRequired := []string{}
|
|
|
|
// If the container image specifies an label with a
|
|
// capabilities.ContainerImageLabel then split the comma separated list
|
|
// of capabilities and record them. This list indicates the only
|
|
// capabilities, required to run the container.
|
|
var capsRequiredRequested []string
|
|
for key, val := range s.Labels {
|
|
if util.StringInSlice(key, capabilities.ContainerImageLabels) {
|
|
capsRequiredRequested = strings.Split(val, ",")
|
|
}
|
|
}
|
|
if !s.Privileged && len(capsRequiredRequested) > 0 {
|
|
|
|
// Pass capRequiredRequested in CapAdd field to normalize capabilities names
|
|
capsRequired, err := capabilities.MergeCapabilities(nil, capsRequiredRequested, nil)
|
|
if err != nil {
|
|
logrus.Errorf("capabilities requested by user or image are not valid: %q", strings.Join(capsRequired, ","))
|
|
} else {
|
|
// Verify all capRequiered are in the capList
|
|
for _, cap := range capsRequired {
|
|
if !util.StringInSlice(cap, caplist) {
|
|
privCapsRequired = append(privCapsRequired, cap)
|
|
}
|
|
}
|
|
}
|
|
if len(privCapsRequired) == 0 {
|
|
caplist = capsRequired
|
|
} else {
|
|
logrus.Errorf("capabilities requested by user or image are not allowed by default: %q", strings.Join(privCapsRequired, ","))
|
|
}
|
|
}
|
|
|
|
configSpec.Process.Capabilities.Bounding = caplist
|
|
configSpec.Process.Capabilities.Permitted = caplist
|
|
configSpec.Process.Capabilities.Inheritable = caplist
|
|
configSpec.Process.Capabilities.Effective = caplist
|
|
configSpec.Process.Capabilities.Ambient = caplist
|
|
if useNotRoot(s.User) {
|
|
caplist, err = capabilities.MergeCapabilities(bounding, s.CapAdd, s.CapDrop)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
configSpec.Process.Capabilities.Bounding = caplist
|
|
|
|
// HANDLE SECCOMP
|
|
if s.SeccompProfilePath != "unconfined" {
|
|
seccompConfig, err := getSeccompConfig(s, configSpec, newImage)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
configSpec.Linux.Seccomp = seccompConfig
|
|
}
|
|
|
|
// Clear default Seccomp profile from Generator for privileged containers
|
|
if s.SeccompProfilePath == "unconfined" || s.Privileged {
|
|
configSpec.Linux.Seccomp = nil
|
|
}
|
|
|
|
g.SetRootReadonly(s.ReadOnlyFilesystem)
|
|
for sysctlKey, sysctlVal := range s.Sysctl {
|
|
g.AddLinuxSysctl(sysctlKey, sysctlVal)
|
|
}
|
|
|
|
return nil
|
|
}
|