mirror of
https://github.com/containers/podman.git
synced 2025-08-06 19:44:14 +08:00
2ddf1c5cbd
I found the ginkgolinter[1] by accident, this looks for not optimal matching and suggest how to do it better. Overall these fixes seem to be all correct and they will give much better error messages when something fails. Check out the repo to see what the linter reports. [1] https://github.com/nunnatsa/ginkgolinter Signed-off-by: Paul Holzinger <pholzing@redhat.com>
253 lines
8.8 KiB
Go
253 lines
8.8 KiB
Go
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"strconv"
|
|
"strings"
|
|
|
|
. "github.com/containers/podman/v4/test/utils"
|
|
. "github.com/onsi/ginkgo"
|
|
. "github.com/onsi/gomega"
|
|
. "github.com/onsi/gomega/gexec"
|
|
)
|
|
|
|
var _ = Describe("Podman start", func() {
|
|
var (
|
|
tempdir string
|
|
err error
|
|
podmanTest *PodmanTestIntegration
|
|
)
|
|
|
|
BeforeEach(func() {
|
|
tempdir, err = CreateTempDirInTempDir()
|
|
if err != nil {
|
|
os.Exit(1)
|
|
}
|
|
podmanTest = PodmanTestCreate(tempdir)
|
|
podmanTest.Setup()
|
|
})
|
|
|
|
AfterEach(func() {
|
|
podmanTest.Cleanup()
|
|
f := CurrentGinkgoTestDescription()
|
|
processTestResult(f)
|
|
|
|
})
|
|
|
|
It("podman start bogus container", func() {
|
|
session := podmanTest.Podman([]string{"start", "123"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(125))
|
|
})
|
|
|
|
It("podman start single container by id", func() {
|
|
session := podmanTest.Podman([]string{"create", ALPINE, "ls"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
cid := session.OutputToString()
|
|
session = podmanTest.Podman([]string{"start", cid})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
})
|
|
|
|
It("podman start --rm removed on failure", func() {
|
|
session := podmanTest.Podman([]string{"create", "--name=test", "--rm", ALPINE, "foo"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
session = podmanTest.Podman([]string{"start", "test"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(125))
|
|
session = podmanTest.Podman([]string{"container", "exists", "test"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).To(ExitWithError())
|
|
})
|
|
|
|
It("podman start --rm --attach removed on failure", func() {
|
|
session := podmanTest.Podman([]string{"create", "--rm", ALPINE, "foo"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
cid := session.OutputToString()
|
|
session = podmanTest.Podman([]string{"start", "--attach", cid})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(125))
|
|
session = podmanTest.Podman([]string{"container", "exists", cid})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).To(ExitWithError())
|
|
})
|
|
|
|
It("podman container start single container by id", func() {
|
|
session := podmanTest.Podman([]string{"container", "create", ALPINE, "ls"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
cid := session.OutputToString()
|
|
session = podmanTest.Podman([]string{"container", "start", cid})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
Expect(session.OutputToString()).To(Equal(cid))
|
|
})
|
|
|
|
It("podman container start single container by short id", func() {
|
|
session := podmanTest.Podman([]string{"container", "create", ALPINE, "ls"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
cid := session.OutputToString()
|
|
shortID := cid[0:10]
|
|
session = podmanTest.Podman([]string{"container", "start", shortID})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
Expect(session.OutputToString()).To(Equal(shortID))
|
|
})
|
|
|
|
It("podman start single container by name", func() {
|
|
name := "foobar99"
|
|
session := podmanTest.Podman([]string{"create", "--name", name, ALPINE, "ls"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
session = podmanTest.Podman([]string{"start", name})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
Expect(session.OutputToString()).To(Equal(name))
|
|
})
|
|
|
|
It("podman start single container with attach and test the signal", func() {
|
|
session := podmanTest.Podman([]string{"create", "--entrypoint", "sh", ALPINE, "-c", "exit 1"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
cid := session.OutputToString()
|
|
session = podmanTest.Podman([]string{"start", "--attach", cid})
|
|
session.WaitWithDefaultTimeout()
|
|
// It should forward the signal
|
|
Expect(session).Should(Exit(1))
|
|
})
|
|
|
|
It("podman start multiple containers", func() {
|
|
session := podmanTest.Podman([]string{"create", "--name", "foobar99", ALPINE, "ls"})
|
|
session.WaitWithDefaultTimeout()
|
|
cid1 := session.OutputToString()
|
|
session2 := podmanTest.Podman([]string{"create", "--name", "foobar100", ALPINE, "ls"})
|
|
session2.WaitWithDefaultTimeout()
|
|
cid2 := session2.OutputToString()
|
|
session = podmanTest.Podman([]string{"start", cid1, cid2})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
})
|
|
|
|
It("podman start multiple containers with bogus", func() {
|
|
session := podmanTest.Podman([]string{"create", "--name", "foobar99", ALPINE, "ls"})
|
|
session.WaitWithDefaultTimeout()
|
|
cid1 := session.OutputToString()
|
|
session = podmanTest.Podman([]string{"start", cid1, "doesnotexist"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(125))
|
|
})
|
|
|
|
It("podman multiple containers -- attach should fail", func() {
|
|
session := podmanTest.Podman([]string{"create", "--name", "foobar1", ALPINE, "ls"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
session = podmanTest.Podman([]string{"create", "--name", "foobar2", ALPINE, "ls"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
session = podmanTest.Podman([]string{"start", "-a", "foobar1", "foobar2"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(125))
|
|
})
|
|
|
|
It("podman failed to start with --rm should delete the container", func() {
|
|
session := podmanTest.Podman([]string{"create", "--name", "test1", "-it", "--rm", ALPINE, "foo"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
start := podmanTest.Podman([]string{"start", "test1"})
|
|
start.WaitWithDefaultTimeout()
|
|
|
|
wait := podmanTest.Podman([]string{"wait", "test1"})
|
|
wait.WaitWithDefaultTimeout()
|
|
Expect(wait).To(ExitWithError())
|
|
|
|
Eventually(podmanTest.NumberOfContainers(), defaultWaitTimeout, 3.0).Should(BeZero())
|
|
})
|
|
|
|
It("podman failed to start without --rm should NOT delete the container", func() {
|
|
session := podmanTest.Podman([]string{"create", "-it", ALPINE, "foo"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
start := podmanTest.Podman([]string{"start", session.OutputToString()})
|
|
start.WaitWithDefaultTimeout()
|
|
Expect(start).To(ExitWithError())
|
|
|
|
Eventually(podmanTest.NumberOfContainers(), defaultWaitTimeout, 3.0).Should(Equal(1))
|
|
})
|
|
|
|
It("podman start --sig-proxy should not work without --attach", func() {
|
|
session := podmanTest.Podman([]string{"create", ALPINE, "ls"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
session = podmanTest.Podman([]string{"start", "-l", "--sig-proxy"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(125))
|
|
})
|
|
|
|
It("podman start container with special pidfile", func() {
|
|
SkipIfRemote("pidfile not handled by remote")
|
|
pidfile := tempdir + "pidfile"
|
|
session := podmanTest.Podman([]string{"create", "--pidfile", pidfile, ALPINE, "ls"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
cid := session.OutputToString()
|
|
|
|
session = podmanTest.Podman([]string{"start", cid})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
readFirstLine := func(path string) string {
|
|
content, err := os.ReadFile(path)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
return strings.Split(string(content), "\n")[0]
|
|
}
|
|
containerPID := readFirstLine(pidfile)
|
|
_, err = strconv.Atoi(containerPID) // Make sure it's a proper integer
|
|
Expect(err).ToNot(HaveOccurred())
|
|
})
|
|
|
|
It("podman start container --filter", func() {
|
|
session1 := podmanTest.Podman([]string{"container", "create", ALPINE})
|
|
session1.WaitWithDefaultTimeout()
|
|
Expect(session1).Should(Exit(0))
|
|
cid1 := session1.OutputToString()
|
|
|
|
session1 = podmanTest.Podman([]string{"container", "create", ALPINE})
|
|
session1.WaitWithDefaultTimeout()
|
|
Expect(session1).Should(Exit(0))
|
|
cid2 := session1.OutputToString()
|
|
|
|
session1 = podmanTest.Podman([]string{"container", "create", ALPINE})
|
|
session1.WaitWithDefaultTimeout()
|
|
Expect(session1).Should(Exit(0))
|
|
cid3 := session1.OutputToString()
|
|
shortCid3 := cid3[0:5]
|
|
|
|
session1 = podmanTest.Podman([]string{"start", cid1, "-f", "status=running"})
|
|
session1.WaitWithDefaultTimeout()
|
|
Expect(session1).Should(Exit(0))
|
|
Expect(session1.OutputToString()).To(HaveLen(0))
|
|
|
|
session1 = podmanTest.Podman([]string{"start", "--all", "--filter", fmt.Sprintf("id=%swrongid", shortCid3)})
|
|
session1.WaitWithDefaultTimeout()
|
|
Expect(session1).Should(Exit(0))
|
|
Expect(session1.OutputToString()).To(HaveLen(0))
|
|
|
|
session1 = podmanTest.Podman([]string{"start", "--all", "--filter", fmt.Sprintf("id=%s", shortCid3)})
|
|
session1.WaitWithDefaultTimeout()
|
|
Expect(session1).Should(Exit(0))
|
|
Expect(session1.OutputToString()).To(BeEquivalentTo(cid3))
|
|
|
|
session1 = podmanTest.Podman([]string{"start", "-f", fmt.Sprintf("id=%s", cid2)})
|
|
session1.WaitWithDefaultTimeout()
|
|
Expect(session1).Should(Exit(0))
|
|
Expect(session1.OutputToString()).To(BeEquivalentTo(cid2))
|
|
})
|
|
})
|