mirror of
https://github.com/containers/podman.git
synced 2025-12-04 20:28:40 +08:00
34235b2726
Fix two bugs in `system df`:
1. The total size was calculated incorrectly as it was creating the sum
of all image sizes but did not consider that a) the same image may
be listed more than once (i.e., for each repo-tag pair), and that
b) images share layers.
The total size is now calculated directly in `libimage` by taking
multi-layer use into account.
2. The reclaimable size was calculated incorrectly. This number
indicates which data we can actually remove which means the total
size minus what containers use (i.e., the "unique" size of the image
in use by containers).
NOTE: The c/storage version is pinned back to the previous commit as it
is buggy. c/common already requires the buggy version, so use a
`replace` to force/pin.
Fixes: #16135
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
90 lines
2.9 KiB
Bash
90 lines
2.9 KiB
Bash
# -*- sh -*-
|
|
#
|
|
# system related tests
|
|
#
|
|
|
|
## ensure system is clean
|
|
t POST 'libpod/system/prune?volumes=true&all=true' params='' 200
|
|
|
|
## podman system df
|
|
t GET system/df 200 '{"LayersSize":0,"Images":[],"Containers":[],"Volumes":[],"BuildCache":[],"BuilderSize":0}'
|
|
t GET libpod/system/df 200 '{"ImagesSize":0,"Images":[],"Containers":[],"Volumes":[]}'
|
|
|
|
# Create volume. We expect df to report this volume next invocation of system/df
|
|
t GET libpod/info 200
|
|
volumepath=$(jq -r ".store.volumePath" <<<"$output")
|
|
t POST libpod/volumes/create name=foo1 201 \
|
|
.Name=foo1 \
|
|
.Driver=local \
|
|
.Mountpoint=$volumepath/foo1/_data \
|
|
.CreatedAt~[0-9]\\{4\\}-[0-9]\\{2\\}-[0-9]\\{2\\}.* \
|
|
.Labels={} \
|
|
.Options={}
|
|
|
|
t GET system/df 200 '.Volumes[0].Name=foo1'
|
|
|
|
t GET libpod/system/df 200 '.Volumes[0].VolumeName=foo1'
|
|
|
|
# Verify that no containers reference the volume
|
|
t GET system/df 200 '.Volumes[0].UsageData.RefCount=0'
|
|
|
|
# Make a container using the volume
|
|
podman pull $IMAGE &>/dev/null
|
|
t POST containers/create Image=$IMAGE Volumes='{"/test":{}}' HostConfig='{"Binds":["foo1:/test"]}' 201 \
|
|
.Id~[0-9a-f]\\{64\\}
|
|
cid=$(jq -r '.Id' <<<"$output")
|
|
|
|
# Verify that one container references the volume
|
|
t GET system/df 200 '.Volumes[0].UsageData.RefCount=1'
|
|
|
|
# Remove the container
|
|
t DELETE containers/$cid?v=true 204
|
|
|
|
# Verify that no containers reference the volume
|
|
t GET system/df 200 '.Volumes[0].UsageData.RefCount=0'
|
|
|
|
# Create two more volumes to test pruneing
|
|
t POST libpod/volumes/create \
|
|
Name=foo2 \
|
|
Label='{"testlabel1":""}' \
|
|
Options='{"type":"tmpfs","o":"nodev,noexec"}}' \
|
|
201 \
|
|
.Name=foo2 \
|
|
.Driver=local \
|
|
.Mountpoint=$volumepath/foo2/_data \
|
|
.CreatedAt~[0-9]\\{4\\}-[0-9]\\{2\\}-[0-9]\\{2\\}.* \
|
|
.Labels.testlabel1="" \
|
|
.Options.o=nodev,noexec
|
|
|
|
t POST libpod/volumes/create \
|
|
Name=foo3 \
|
|
Label='{"testlabel1":"testonly"}' \
|
|
Options='{"type":"tmpfs","o":"nodev,noexec"}}' \
|
|
201 \
|
|
.Name=foo3 \
|
|
.Driver=local \
|
|
.Mountpoint=$volumepath/foo3/_data \
|
|
.CreatedAt~[0-9]\\{4\\}-[0-9]\\{2\\}-[0-9]\\{2\\}.* \
|
|
.Labels.testlabel1=testonly \
|
|
.Options.o=nodev,noexec
|
|
|
|
t GET system/df 200 '.Volumes | length=3'
|
|
t GET libpod/system/df 200 '.Volumes | length=3'
|
|
|
|
# Prune volumes
|
|
|
|
t POST 'libpod/system/prune?volumes=true&filters={"label":["testlabel1=idontmatch"]}' params='' 200
|
|
|
|
# nothing should have been pruned
|
|
t GET system/df 200 '.Volumes | length=3'
|
|
t GET libpod/system/df 200 '.Volumes | length=3'
|
|
|
|
# only foo3 should be pruned because of filter
|
|
t POST 'libpod/system/prune?volumes=true&filters={"label":["testlabel1=testonly"]}' params='' 200 .VolumePruneReports[0].Id=foo3
|
|
# only foo2 should be pruned because of filter
|
|
t POST 'libpod/system/prune?volumes=true&filters={"label":["testlabel1"]}' params='' 200 .VolumePruneReports[0].Id=foo2
|
|
# foo1, the last remaining volume should be pruned without any filters applied
|
|
t POST 'libpod/system/prune?volumes=true' params='' 200 .VolumePruneReports[0].Id=foo1
|
|
|
|
# TODO add other system prune tests for pods / images
|