mirror of
https://github.com/containers/podman.git
synced 2025-11-01 10:45:52 +08:00
232c32bd35
Our test registry (used for login & local registry tests)
was being run using the standard podman tmpdir, hence the
standard podman database, This was then getting clobbered
in the 330-corrupt-images test, which runs "system reset".
We just didn't know this was happening. Until we added
a registry test after the system reset. Oops.
Solution: new helper function podman_isolation_opts()
sets --root, --runroot, *and --tmpdir*. Refactor all
existing --root/--runroot usages. Document.
Next problem: the "network reload" test in 500-networking.bats
did not (could not) know about our registry port, so the
"iptables -F" command reverted that to DROP, so the subsequent
podman-auth in 700-play timed out.
Solution: add a podman-isolated "network reload" to start_registry().
Final problem, because, really, those weren't enough: a BATS
bug where running with --filter-tags would set IFS=',' in setup_suite
which in turn has catastrophic consequences:
https://github.com/bats-core/bats-core/issues/812
See #20966 for details of the failure and further conversation.
Signed-off-by: Ed Santiago <santiago@redhat.com>
40 lines
1.4 KiB
Bash
40 lines
1.4 KiB
Bash
# -*- bash -*-
|
|
#
|
|
# global setup/teardown for the entire system test suite
|
|
#
|
|
bats_require_minimum_version 1.8.0
|
|
|
|
load helpers
|
|
load helpers.network
|
|
load helpers.registry
|
|
|
|
# Create common environment just in case we end up needing a registry.
|
|
# These environment variables will be available to all tests.
|
|
function setup_suite() {
|
|
# FIXME: 2023-12-13: https://github.com/bats-core/bats-core/issues/812
|
|
# Running 'bats --filter-tags' sets IFS=',' which ... ugh. Not fun to debug.
|
|
# The line below is newline, space, tab.
|
|
IFS="
|
|
"
|
|
|
|
# Can't use $BATS_SUITE_TMPDIR because podman barfs:
|
|
# Error: the specified runroot is longer than 50 characters
|
|
export PODMAN_LOGIN_WORKDIR=$(mktemp -d --tmpdir=${BATS_TMPDIR:-${TMPDIR:-/tmp}} podman-bats-registry.XXXXXX)
|
|
|
|
export PODMAN_LOGIN_USER="user$(random_string 4)"
|
|
export PODMAN_LOGIN_PASS="pw$(random_string 15)"
|
|
|
|
# FIXME: racy! It could be many minutes between now and when we start it.
|
|
# To mitigate, we use a range not used anywhere else in system tests.
|
|
export PODMAN_LOGIN_REGISTRY_PORT=$(random_free_port 42000-42999)
|
|
|
|
# The above does not handle errors. Do a final confirmation.
|
|
assert "$PODMAN_LOGIN_REGISTRY_PORT" != "" \
|
|
"Unable to set PODMAN_LOGIN_REGISTRY_PORT"
|
|
}
|
|
|
|
# Run at the very end of all tests. Useful for cleanup of non-BATS tmpdirs.
|
|
function teardown_suite() {
|
|
stop_registry
|
|
}
|