mirror of
https://github.com/containers/podman.git
synced 2025-12-06 05:37:49 +08:00
2ddf1c5cbd
I found the ginkgolinter[1] by accident, this looks for not optimal matching and suggest how to do it better. Overall these fixes seem to be all correct and they will give much better error messages when something fails. Check out the repo to see what the linter reports. [1] https://github.com/nunnatsa/ginkgolinter Signed-off-by: Paul Holzinger <pholzing@redhat.com>
69 lines
1.4 KiB
Go
69 lines
1.4 KiB
Go
package bindings_test
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"github.com/containers/podman/v4/pkg/bindings/containers"
|
|
"github.com/containers/podman/v4/pkg/bindings/system"
|
|
. "github.com/onsi/ginkgo"
|
|
. "github.com/onsi/gomega"
|
|
"github.com/onsi/gomega/gexec"
|
|
)
|
|
|
|
var _ = Describe("Podman connection", func() {
|
|
var (
|
|
bt *bindingTest
|
|
s *gexec.Session
|
|
)
|
|
|
|
BeforeEach(func() {
|
|
bt = newBindingTest()
|
|
bt.RestoreImagesFromCache()
|
|
s = bt.startAPIService()
|
|
time.Sleep(1 * time.Second)
|
|
err := bt.NewConnection()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
})
|
|
|
|
AfterEach(func() {
|
|
s.Kill()
|
|
bt.cleanup()
|
|
})
|
|
|
|
It("request on cancelled context results in error", func() {
|
|
ctx, cancel := context.WithCancel(bt.conn)
|
|
cancel()
|
|
_, err := system.Version(ctx, nil)
|
|
Expect(err).To(MatchError(ctx.Err()))
|
|
})
|
|
|
|
It("cancel request in flight reports cancelled context", func() {
|
|
var name = "top"
|
|
_, err := bt.RunTopContainer(&name, nil)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
errChan := make(chan error)
|
|
ctx, cancel := context.WithCancel(bt.conn)
|
|
|
|
go func() {
|
|
defer close(errChan)
|
|
_, err := containers.Wait(ctx, name, nil)
|
|
errChan <- err
|
|
}()
|
|
|
|
// Wait for the goroutine to fire the request
|
|
time.Sleep(1 * time.Second)
|
|
|
|
cancel()
|
|
|
|
select {
|
|
case err, ok := <-errChan:
|
|
Expect(ok).To(BeTrue())
|
|
Expect(err).To(MatchError(ctx.Err()))
|
|
case <-time.NewTimer(1 * time.Second).C:
|
|
Fail("cancelled request did not return in less than 1 second")
|
|
}
|
|
})
|
|
})
|