opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-09-10 08:22:23 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
podman/libpod
History
Valentin Rothberg 9563415430 fix --health-on-failure=restart in transient unit 
As described in #17777, the `restart` on-failure action did not behave
correctly when the health check is being run by a transient systemd
unit.  It ran just fine when being executed outside such a unit, for
instance, manually or, as done in the system tests, in a scripted
fashion.

There were two issue causing the `restart` on-failure action to
misbehave:

1) The transient systemd units used the default `KillMode=cgroup` which
   will nuke all processes in the specific cgroup including the recently
   restarted container/conmon once the main `podman healthcheck run`
   process exits.

2) Podman attempted to remove the transient systemd unit and timer
   during restart.  That is perfectly fine when manually restarting the
   container but not when the restart itself is being executed inside
   such a transient unit.  Ultimately, Podman tried to shoot itself in
   the foot.

Fix both issues by moving the restart logic in the cleanup process.
Instead of restarting the container, the `healthcheck run` will just
stop the container and the cleanup process will restart the container
once it has turned unhealthy.

Fixes: #17777
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-20 13:56:00 +01:00
..
define
Support running nested SELinux container separation
2023-03-13 14:21:12 -04:00
driver
bump go module to version 4
2022-01-18 12:47:07 +01:00
events
events: no duplicates when streaming during a log rotation
2023-03-15 10:28:16 +01:00
layers
Initial checkin from CRI-O repo
2017-11-01 11:24:59 -04:00
linkmode
go fmt: use go 1.18 conditional-build syntax
2022-03-18 09:11:53 +01:00
lock
Fix typos. Improve language.
2023-02-09 21:56:27 +01:00
logs
journald logs: simplify entry parsing
2023-02-20 13:58:15 +01:00
plugin
bump golangci-lint to v1.49.0
2022-10-17 09:19:41 +02:00
shutdown
play kube: Add --wait option
2023-02-28 13:45:36 -05:00
boltdb_state_internal.go
Remove concept of Namespaces from BoltDB
2023-02-22 11:00:50 -05:00
boltdb_state_unsupported.go
libpod: Add definition of containerPlatformState for FreeBSD
2022-08-23 15:31:00 +01:00
boltdb_state.go
Remove --namespace flag from Podman root
2023-02-22 11:00:50 -05:00
common_test.go
bump go module to version 4
2022-01-18 12:47:07 +01:00
container_api.go
libpod: avoid nil pointer dereference in (*Container).Cleanup
2023-03-06 11:51:42 +00:00
container_commit.go
commit: use libimage code to parse changes
2023-01-16 16:28:11 +01:00
container_config.go
Support running nested SELinux container separation
2023-03-13 14:21:12 -04:00
container_copy_common.go
libpod: Implement 'podman cp' for FreeBSD
2022-09-20 08:36:23 +01:00
container_copy_freebsd.go
libpod: Implement 'podman cp' for FreeBSD
2022-09-20 08:36:23 +01:00
container_copy_linux.go
libpod: Move jointMountAndExec to container_copy_linux.go
2022-09-20 08:36:23 +01:00
container_copy_unsupported.go
libpod: Implement 'podman cp' for FreeBSD
2022-09-20 08:36:23 +01:00
container_exec.go
container rm: save once for exec removal and state change
2023-01-30 15:43:03 +01:00
container_freebsd.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
container_graph_test.go
bump go module to version 4
2022-01-18 12:47:07 +01:00
container_graph.go
Introduce graph-based pod container removal
2022-09-14 13:44:48 -04:00
container_inspect_freebsd.go
libpod: Factor out platform-specfic code from generateInspectContainerHostConfig
2022-09-15 08:10:34 +01:00
container_inspect_linux.go
build(deps): bump github.com/container-orchestrated-devices/container-device-interface
2023-02-20 14:51:04 +01:00
container_inspect.go
Fix typos. Improve language.
2023-02-09 21:56:27 +01:00
container_internal_common.go
Fix various integration test issues with SQLite state
2023-03-15 14:45:18 -04:00
container_internal_freebsd.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
container_internal_linux_test.go
Fix a potential UID/GID collision in unit tests
2023-02-07 09:34:15 -05:00
container_internal_linux.go
Merge pull request #17729 from rhatdan/selinux
2023-03-15 12:07:03 -04:00
container_internal_test.go
Vendor in latest containers/storage
2023-02-24 08:25:04 -05:00
container_internal_unsupported.go
libpod: Add FreeBSD implementation of container internals
2022-09-05 10:12:12 +01:00
container_internal.go
fix --health-on-failure=restart in transient unit
2023-03-20 13:56:00 +01:00
container_linux.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
container_log_linux.go
podman logs passthrough driver support --cgroups=split
2023-02-20 13:58:16 +01:00
container_log_unsupported.go
podman logs passthrough driver support --cgroups=split
2023-02-20 13:58:16 +01:00
container_log.go
podman logs passthrough driver support --cgroups=split
2023-02-20 13:58:16 +01:00
container_path_resolution_test.go
libpod: fix lookup for subpath in volumes
2022-09-14 17:09:04 +02:00
container_path_resolution.go
bump golangci-lint to v1.49.0
2022-10-17 09:19:41 +02:00
container_stat_common.go
Fix typos. Improve language.
2023-02-09 21:56:27 +01:00
container_stat_freebsd.go
libpod: Implement 'podman cp' for FreeBSD
2022-09-20 08:36:23 +01:00
container_stat_linux.go
libpod: Move part of (*Container).stat to container_stat_linux.go
2022-09-20 08:36:23 +01:00
container_stat_unsupported.go
libpod: Implement 'podman cp' for FreeBSD
2022-09-20 08:36:23 +01:00
container_top_freebsd.go
libpod: Add support for 'podman top' on FreeBSD
2022-10-17 16:43:53 +01:00
container_top_linux.go
Fix stutters
2022-09-10 07:52:00 -04:00
container_top_unsupported.go
libpod: Add support for 'podman top' on FreeBSD
2022-10-17 16:43:53 +01:00
container_unsupported.go
libpod: Add definition of containerPlatformState for FreeBSD
2022-08-23 15:31:00 +01:00
container_validate.go
libpod: remove CNI word were no longer applicable
2022-12-16 14:20:14 +01:00
container.go
Add container error message to ContainerState
2023-01-03 13:21:24 -05:00
diff.go
libpod: switch to golang native error wrapping
2022-07-05 16:06:32 +02:00
doc.go
document that using libpod package directly is not supported
2022-03-23 19:05:29 +01:00
events.go
container create: add inspect data to event
2022-11-29 10:40:24 +01:00
healthcheck_linux.go
health check: ignore dependencies of transient systemd units/timers
2022-12-08 15:01:57 +01:00
healthcheck_nosystemd_linux.go
disable healthchecks automatically on non systemd systems
2022-12-05 20:58:30 +01:00
healthcheck_unsupported.go
libpod: Track healthcheck API changes in healthcheck_unsupported.go
2022-12-02 16:41:21 +00:00
healthcheck.go
fix --health-on-failure=restart in transient unit
2023-03-20 13:56:00 +01:00
info_freebsd.go
Fix stutters
2022-09-10 07:52:00 -04:00
info_linux.go
Fix stutters
2022-09-10 07:52:00 -04:00
info_test.go
libpod: Make unit test for statToPercent Linux only
2022-11-13 10:56:15 +00:00
info_unsupported.go
libpod: Enable 'podman info' for FreeBSD
2022-08-24 10:55:52 +01:00
info.go
sqlite: add a hidden --db-backend flag
2023-03-02 13:43:11 +01:00
kube.go
Don't set hostPort when generating a service
2023-02-14 11:00:28 -05:00
mounts_linux.go
go fmt: use go 1.18 conditional-build syntax
2022-03-18 09:11:53 +01:00
networking_common.go
podman inspect list network when using --net=host or none
2023-03-08 17:27:08 -05:00
networking_freebsd.go
Fix typos. Improve language.
2023-02-09 21:56:27 +01:00
networking_linux_test.go
enable unparam linter
2022-04-25 13:23:20 +02:00
networking_linux.go
Fix typos. Improve language.
2023-02-09 21:56:27 +01:00
networking_machine.go
Replace deprecated ioutil
2022-09-20 15:34:27 -04:00
networking_pasta_linux.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
networking_slirp4netns.go
Fix typos. Improve language.
2023-02-09 21:56:27 +01:00
networking_unsupported.go
Fix typos. Improve language.
2023-02-09 21:56:27 +01:00
oci_conmon_attach_common.go
bump golangci-lint to v1.49.0
2022-10-17 09:19:41 +02:00
oci_conmon_attach_freebsd.go
libpod: Build oci_conmon_common.go and oci_conmon_attach_common on FreeBSD
2022-08-18 08:07:30 +01:00
oci_conmon_attach_linux.go
libpod: Move openUnixSocket to oci_conmon_attach_linux.go
2022-08-18 08:05:42 +01:00
oci_conmon_common.go
waitPidStop: reduce sleep time to 10ms
2023-01-19 12:31:37 +01:00
oci_conmon_exec_common.go
Replace deprecated ioutil
2022-09-20 15:34:27 -04:00
oci_conmon_exec_freebsd.go
libpod: Factor out capabilites code from prepareProcessExec
2022-09-07 07:58:37 +01:00
oci_conmon_exec_linux.go
libpod: Factor out capabilites code from prepareProcessExec
2022-09-07 07:58:37 +01:00
oci_conmon_freebsd.go
libpod: Make sure writeConmonPipeData is called on FreeBSD
2022-08-29 13:04:04 +01:00
oci_conmon_linux.go
Add and use Container.LinuxResource() helper
2022-10-12 13:45:49 +02:00
oci_conmon_unsupported.go
libpod: Build oci_conmon_common.go and oci_conmon_attach_common on FreeBSD
2022-08-18 08:07:30 +01:00
oci_conmon.go
podman: add new cgroup mode split
2020-06-25 17:16:12 +02:00
oci_missing.go
implement podman update
2022-09-01 13:02:01 -04:00
oci_util.go
libpod: switch to golang native error wrapping
2022-07-05 16:06:32 +02:00
oci.go
bump golangci-lint to v1.49.0
2022-10-17 09:19:41 +02:00
options.go
Support running nested SELinux container separation
2023-03-13 14:21:12 -04:00
pod_api.go
Merge pull request #16818 from SoMuchForSubtlety/api-port-bindings
2022-12-15 20:19:53 -05:00
pod_internal_freebsd.go
libpod: Factor out cgroups handling from (*Pod).refresh
2022-10-07 08:26:10 +01:00
pod_internal_linux.go
libpod: Factor out cgroups handling from (*Pod).refresh
2022-10-07 08:26:10 +01:00
pod_internal.go
Add initial SQLite-backed state implementation
2023-02-22 11:00:50 -05:00
pod_status.go
bump go module to version 4
2022-01-18 12:47:07 +01:00
pod_top_linux.go
libpod/pod_top_linux.go: s/TODO/NOTE/
2022-05-25 12:30:19 +02:00
pod_top_unsupported.go
libpod: Add stubs for non-linux builds
2022-08-17 11:45:07 +01:00
pod.go
Must use mountlabel when creating builtin volumes
2023-03-09 12:36:52 -05:00
reset.go
Update c/storage after https://github.com/containers/storage/pull/1436
2022-12-01 16:05:13 +01:00
runtime_cstorage.go
Add support for 'image' volume driver
2022-09-22 13:07:40 -04:00
runtime_ctr_freebsd.go
libpod: Don't mount /dev/shm in containers on FreeBSD
2022-09-05 10:20:50 +01:00
runtime_ctr_linux.go
libpod: Don't mount /dev/shm in containers on FreeBSD
2022-09-05 10:20:50 +01:00
runtime_ctr.go
Must use mountlabel when creating builtin volumes
2023-03-09 12:36:52 -05:00
runtime_img.go
DB: make loading container states optional
2023-01-26 10:20:38 +01:00
runtime_migrate_unsupported.go
libpod: Add stubs for non-linux builds
2022-08-17 11:45:07 +01:00
runtime_migrate.go
DB: make loading container states optional
2023-01-26 10:20:38 +01:00
runtime_pod_common.go
libpod: Add support for 'podman pod' on FreeBSD
2022-10-07 08:27:27 +01:00
runtime_pod_freebsd.go
libpod: Add support for 'podman pod' on FreeBSD
2022-10-07 08:27:27 +01:00
runtime_pod_linux.go
libpod: Factor out cgroup validation from (*Runtime).NewPod
2022-10-07 08:27:27 +01:00
runtime_pod_unsupported.go
libpod: Add support for 'podman pod' on FreeBSD
2022-10-07 08:27:27 +01:00
runtime_pod.go
libpod/runtime: switch to golang native error wrapping
2022-07-04 15:39:00 +02:00
runtime_renumber.go
DB: make loading container states optional
2023-01-26 10:20:38 +01:00
runtime_test.go
libpod: Ensure that generated container names are random
2022-09-01 10:27:04 +01:00
runtime_volume_common.go
Fix various integration test issues with SQLite state
2023-03-15 14:45:18 -04:00
runtime_volume_unsupported.go
libpod: Add volume support for FreeBSD
2022-09-27 16:31:40 +01:00
runtime_volume.go
libpod/runtime: switch to golang native error wrapping
2022-07-04 15:39:00 +02:00
runtime_worker.go
work queue: simplify and use a wait group
2022-05-25 10:17:46 +02:00
runtime.go
Add support for containers.conf database setting
2023-02-22 12:59:01 -05:00
service.go
play kube: Add --wait option
2023-02-28 13:45:36 -05:00
sqlite_state_internal.go
Fix various integration test issues with SQLite state
2023-03-15 14:45:18 -04:00
sqlite_state.go
Ensure SQLite places uses the runroot in transient mode
2023-03-15 14:45:28 -04:00
state_test.go
Remove concept of Namespaces from BoltDB
2023-02-22 11:00:50 -05:00
state.go
Add initial SQLite-backed state implementation
2023-02-22 11:00:50 -05:00
stats_common.go
libpod: Split out the common code from GetContainerStats
2022-09-14 08:29:26 +01:00
stats_freebsd.go
Fix swapped NetInput/-Output stats
2022-11-28 12:26:41 +01:00
stats_linux.go
Fix swapped NetInput/-Output stats
2022-11-28 12:26:41 +01:00
stats_unsupported.go
libpod: Add support for 'podman stats' on FreeBSD
2022-09-14 08:29:26 +01:00
storage.go
libpod: switch to golang native error wrapping
2022-07-05 16:06:32 +02:00
util_freebsd.go
Must use mountlabel when creating builtin volumes
2023-03-09 12:36:52 -05:00
util_linux_test.go
Must use mountlabel when creating builtin volumes
2023-03-09 12:36:52 -05:00
util_linux.go
Must use mountlabel when creating builtin volumes
2023-03-09 12:36:52 -05:00
util_test.go
bump go module to version 4
2022-01-18 12:47:07 +01:00
util_unsupported.go
Must use mountlabel when creating builtin volumes
2023-03-09 12:36:52 -05:00
util.go
remove unmapped ports from inspect port bindings
2022-12-15 23:18:50 +01:00
volume_inspect.go
Add support for 'image' volume driver
2022-09-22 13:07:40 -04:00
volume_internal_common.go
libpod: Add volume support for FreeBSD
2022-09-27 16:31:40 +01:00
volume_internal_freebsd.go
libpod: Add volume support for FreeBSD
2022-09-27 16:31:40 +01:00
volume_internal_linux.go
libpod: Factor out usage of unix.MNT_DETACH from (*Volume).unmount
2022-09-27 16:31:40 +01:00
volume_internal_unsupported.go
libpod: Add volume support for FreeBSD
2022-09-27 16:31:40 +01:00
volume_internal.go
Add initial SQLite-backed state implementation
2023-02-22 11:00:50 -05:00
volume.go
Fix various integration test issues with SQLite state
2023-03-15 14:45:18 -04:00