mirror of
https://github.com/containers/podman.git
synced 2025-09-17 23:18:39 +08:00

There is no reason to define the same code every time in each file, just use global nodes. This diff should speak for itself. CleanupSecrets()/Volume() no longer call Cleanup() directly, as the global AfterEach node will always call Cleanup() this is no longer necessary. If one AfterEach() node fails it will still run the others. Also always unset the CONTAINERS_CONF env vars. This prevents people from forgetting to unset it. And fix the special CONTAINERS_CONF logic in the system connection tests, we do not want to preserve CONTAINERS_CONF anyway so just remove this logic. Ginkgo orders the BeforeEach and AfterEach nodes. They will be executed from the outer-most defined to inner-most. This means our global BeforeEach is always first. Only then the inner one (in the Describe() function in each file). For AfterEach it is inverted, from the inner to the outer. Also see https://onsi.github.io/ginkgo/#organizing-specs-with-container-nodes Signed-off-by: Paul Holzinger <pholzing@redhat.com>
141 lines
4.4 KiB
Go
141 lines
4.4 KiB
Go
package integration
|
|
|
|
import (
|
|
"errors"
|
|
"io/fs"
|
|
"net"
|
|
"net/url"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strconv"
|
|
"syscall"
|
|
"time"
|
|
|
|
testUtils "github.com/containers/podman/v4/test/utils"
|
|
podmanUtils "github.com/containers/podman/v4/utils"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
. "github.com/onsi/gomega/gexec"
|
|
)
|
|
|
|
var _ = Describe("Systemd activate", func() {
|
|
var activate string
|
|
|
|
BeforeEach(func() {
|
|
SkipIfRemote("Testing stopped service requires both podman and podman-remote binaries")
|
|
|
|
activate, err = exec.LookPath("systemd-socket-activate")
|
|
if err != nil {
|
|
activate = "/usr/bin/systemd-socket-activate"
|
|
}
|
|
stat, err := os.Stat(activate)
|
|
switch {
|
|
case errors.Is(err, fs.ErrNotExist):
|
|
Skip(activate + " required for systemd activation tests")
|
|
case stat.Mode()&0111 == 0:
|
|
Skip("Unable to execute " + activate)
|
|
case err != nil:
|
|
Skip(err.Error())
|
|
}
|
|
})
|
|
|
|
It("stop podman.service", func() {
|
|
// systemd-socket-activate does not support DNS lookups
|
|
host := "127.0.0.1"
|
|
port, err := podmanUtils.GetRandomPort()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
addr := net.JoinHostPort(host, strconv.Itoa(port))
|
|
|
|
podmanOptions := podmanTest.makeOptions(nil, false, false)
|
|
|
|
systemdArgs := []string{
|
|
"-E", "http_proxy", "-E", "https_proxy", "-E", "no_proxy",
|
|
"-E", "HTTP_PROXY", "-E", "HTTPS_PROXY", "-E", "NO_PROXY",
|
|
"-E", "XDG_RUNTIME_DIR",
|
|
"--listen", addr,
|
|
podmanTest.PodmanBinary}
|
|
systemdArgs = append(systemdArgs, podmanOptions...)
|
|
systemdArgs = append(systemdArgs, "system", "service", "--time=0")
|
|
|
|
activateSession := testUtils.StartSystemExec(activate, systemdArgs)
|
|
Expect(activateSession.Exited).ShouldNot(Receive(), "Failed to start podman service")
|
|
WaitForService(url.URL{Scheme: "tcp", Host: addr})
|
|
defer activateSession.Signal(syscall.SIGTERM)
|
|
|
|
// Create custom functions for running podman and
|
|
// podman-remote. This test is a rare exception where both
|
|
// binaries need to be run in parallel. Usually, the remote
|
|
// and non-remote details are hidden. Yet we use the
|
|
// `podmanOptions` above to make sure all settings (root,
|
|
// runroot, events, tmpdir, etc.) are used as in other e2e
|
|
// tests.
|
|
podmanRemote := func(args ...string) *testUtils.PodmanSession {
|
|
args = append([]string{"--url", "tcp://" + addr}, args...)
|
|
return testUtils.SystemExec(podmanTest.RemotePodmanBinary, args)
|
|
}
|
|
|
|
podman := func(args ...string) *testUtils.PodmanSession {
|
|
args = append(podmanOptions, args...)
|
|
return testUtils.SystemExec(podmanTest.PodmanBinary, args)
|
|
}
|
|
|
|
containerName := "top_" + testUtils.RandomString(8)
|
|
apiSession := podmanRemote(
|
|
"create", "--tty", "--name", containerName, "--entrypoint", "top",
|
|
ALPINE,
|
|
)
|
|
Expect(apiSession).Should(Exit(0))
|
|
defer podman("rm", "-f", containerName)
|
|
|
|
apiSession = podmanRemote("start", containerName)
|
|
Expect(apiSession).Should(Exit(0))
|
|
|
|
apiSession = podmanRemote("inspect", "--format={{.State.Running}}", containerName)
|
|
Expect(apiSession).Should(Exit(0))
|
|
Expect(apiSession.OutputToString()).To(Equal("true"))
|
|
|
|
// Emulate 'systemd stop podman.service'
|
|
activateSession.Signal(syscall.SIGTERM)
|
|
time.Sleep(100 * time.Millisecond)
|
|
Eventually(activateSession).Should(Exit(0))
|
|
|
|
abiSession := podman("inspect", "--format={{.State.Running}}", containerName)
|
|
Expect(abiSession).To(Exit(0))
|
|
Expect(abiSession.OutputToString()).To(Equal("true"))
|
|
})
|
|
|
|
It("invalid systemd file descriptor", func() {
|
|
host := "127.0.0.1"
|
|
port, err := podmanUtils.GetRandomPort()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
addr := net.JoinHostPort(host, strconv.Itoa(port))
|
|
|
|
// start systemd activation with datagram socket
|
|
activateSession := testUtils.StartSystemExec(activate, []string{
|
|
"--datagram", "--listen", addr,
|
|
podmanTest.PodmanBinary,
|
|
"--root=" + filepath.Join(tempdir, "server_root"),
|
|
"system", "service",
|
|
"--time=0",
|
|
})
|
|
Expect(activateSession.Exited).ShouldNot(Receive(), "Failed to start podman service")
|
|
|
|
// we have to wait for systemd-socket-activate to become ready
|
|
time.Sleep(1 * time.Second)
|
|
|
|
// now dial the socket to start podman
|
|
conn, err := net.Dial("udp", addr)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
defer conn.Close()
|
|
_, err = conn.Write([]byte("test"))
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
// wait for podman to exit
|
|
activateSession.Wait(10)
|
|
Expect(activateSession).To(Exit(125))
|
|
Expect(activateSession.ErrorToString()).To(ContainSubstring("Error: unexpected fd received from systemd: cannot listen on it"))
|
|
})
|
|
})
|