mirror of
https://github.com/containers/podman.git
synced 2025-09-17 06:47:10 +08:00
ab29ff2f66
There is no reason to define the same code every time in each file, just use global nodes. This diff should speak for itself. CleanupSecrets()/Volume() no longer call Cleanup() directly, as the global AfterEach node will always call Cleanup() this is no longer necessary. If one AfterEach() node fails it will still run the others. Also always unset the CONTAINERS_CONF env vars. This prevents people from forgetting to unset it. And fix the special CONTAINERS_CONF logic in the system connection tests, we do not want to preserve CONTAINERS_CONF anyway so just remove this logic. Ginkgo orders the BeforeEach and AfterEach nodes. They will be executed from the outer-most defined to inner-most. This means our global BeforeEach is always first. Only then the inner one (in the Describe() function in each file). For AfterEach it is inverted, from the inner to the outer. Also see https://onsi.github.io/ginkgo/#organizing-specs-with-container-nodes Signed-off-by: Paul Holzinger <pholzing@redhat.com>
111 lines
3.8 KiB
Go
111 lines
3.8 KiB
Go
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
. "github.com/containers/podman/v4/test/utils"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
. "github.com/onsi/gomega/gexec"
|
|
)
|
|
|
|
var PodmanDockerfile = fmt.Sprintf(`
|
|
FROM %s
|
|
LABEL RUN podman --version`, ALPINE)
|
|
|
|
var LsDockerfile = fmt.Sprintf(`
|
|
FROM %s
|
|
LABEL RUN ls -la`, ALPINE)
|
|
|
|
var PodmanRunlabelNameDockerfile = fmt.Sprintf(`
|
|
FROM %s
|
|
LABEL RUN podman run --name NAME IMAGE`, ALPINE)
|
|
|
|
var _ = Describe("podman container runlabel", func() {
|
|
|
|
BeforeEach(func() {
|
|
SkipIfRemote("runlabel is not supported for remote connections")
|
|
})
|
|
|
|
It("podman container runlabel (podman --version)", func() {
|
|
image := "podman-runlabel-test:podman"
|
|
podmanTest.BuildImage(PodmanDockerfile, image, "false")
|
|
|
|
result := podmanTest.Podman([]string{"container", "runlabel", "RUN", image})
|
|
result.WaitWithDefaultTimeout()
|
|
Expect(result).Should(Exit(0))
|
|
|
|
result = podmanTest.Podman([]string{"rmi", image})
|
|
result.WaitWithDefaultTimeout()
|
|
Expect(result).Should(Exit(0))
|
|
})
|
|
|
|
It("podman container runlabel (ls -la)", func() {
|
|
image := "podman-runlabel-test:ls"
|
|
podmanTest.BuildImage(LsDockerfile, image, "false")
|
|
|
|
result := podmanTest.Podman([]string{"container", "runlabel", "RUN", image})
|
|
result.WaitWithDefaultTimeout()
|
|
Expect(result).Should(Exit(0))
|
|
|
|
result = podmanTest.Podman([]string{"rmi", image})
|
|
result.WaitWithDefaultTimeout()
|
|
Expect(result).Should(Exit(0))
|
|
})
|
|
It("podman container runlabel --display", func() {
|
|
image := "podman-runlabel-test:ls"
|
|
podmanTest.BuildImage(LsDockerfile, image, "false")
|
|
|
|
result := podmanTest.Podman([]string{"container", "runlabel", "--display", "RUN", image})
|
|
result.WaitWithDefaultTimeout()
|
|
Expect(result).Should(Exit(0))
|
|
Expect(result.OutputToString()).To(ContainSubstring(podmanTest.PodmanBinary + " -la"))
|
|
|
|
result = podmanTest.Podman([]string{"rmi", image})
|
|
result.WaitWithDefaultTimeout()
|
|
Expect(result).Should(Exit(0))
|
|
})
|
|
It("podman container runlabel bogus label should result in non-zero exit code", func() {
|
|
result := podmanTest.Podman([]string{"container", "runlabel", "RUN", ALPINE})
|
|
result.WaitWithDefaultTimeout()
|
|
Expect(result).To(ExitWithError())
|
|
// should not panic when label missing the value or don't have the label
|
|
Expect(result.OutputToString()).To(Not(ContainSubstring("panic")))
|
|
})
|
|
It("podman container runlabel bogus label in remote image should result in non-zero exit", func() {
|
|
result := podmanTest.Podman([]string{"container", "runlabel", "RUN", "docker.io/library/ubuntu:latest"})
|
|
result.WaitWithDefaultTimeout()
|
|
Expect(result).To(ExitWithError())
|
|
// should not panic when label missing the value or don't have the label
|
|
Expect(result.OutputToString()).To(Not(ContainSubstring("panic")))
|
|
})
|
|
|
|
It("runlabel should fail with nonexistent authfile", func() {
|
|
image := "podman-runlabel-test:podman"
|
|
podmanTest.BuildImage(PodmanDockerfile, image, "false")
|
|
|
|
// runlabel should fail with nonexistent authfile
|
|
result := podmanTest.Podman([]string{"container", "runlabel", "--authfile", "/tmp/nonexistent", "RUN", image})
|
|
result.WaitWithDefaultTimeout()
|
|
Expect(result).To(ExitWithError())
|
|
|
|
result = podmanTest.Podman([]string{"rmi", image})
|
|
result.WaitWithDefaultTimeout()
|
|
Expect(result).Should(Exit(0))
|
|
})
|
|
|
|
It("podman container runlabel name removes tag from image", func() {
|
|
image := "podman-runlabel-name:sometag"
|
|
podmanTest.BuildImage(PodmanRunlabelNameDockerfile, image, "false")
|
|
|
|
result := podmanTest.Podman([]string{"container", "runlabel", "--display", "RUN", image})
|
|
result.WaitWithDefaultTimeout()
|
|
Expect(result).Should(Exit(0))
|
|
Expect(result.OutputToString()).To(Equal("command: " + podmanTest.PodmanBinary + " run --name podman-runlabel-name localhost/" + image))
|
|
|
|
result = podmanTest.Podman([]string{"rmi", image})
|
|
result.WaitWithDefaultTimeout()
|
|
Expect(result).Should(Exit(0))
|
|
})
|
|
})
|