mirror of
https://github.com/containers/podman.git
synced 2025-07-15 03:02:52 +08:00
0fb95f95d2
Reintroduce .install.foo targets into Makefile, and invoke only the bare-minimum ones needed for each individual CI step in setup_environment.sh. Also add a retry to the golangci-lint curl, in hopes of dealing with network flakes. And remove the -f (fail) because it produces unhelpful logs. Reason: saw about 25% CI flakes yesterday due to the golangci-lint fetch, something about a timeout, and this was especially frustrating because none of the steps actually needed lint. Quick reminder: avoid network fetches unless absolutely necessary. Fixes: #15892 Signed-off-by: Ed Santiago <santiago@redhat.com>
27 lines
783 B
Bash
Executable File
27 lines
783 B
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
die() { echo "${1:-No error message given} (from $(basename $0))"; exit 1; }
|
|
|
|
[ -n "$VERSION" ] || die "\$VERSION is empty or undefined"
|
|
|
|
function install() {
|
|
echo "Installing golangci-lint v$VERSION into $BIN"
|
|
curl -sSL --retry 5 https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v$VERSION
|
|
}
|
|
|
|
# Undocumented behavior: golangci-lint installer requires $BINDIR in env,
|
|
# will default to ./bin but we can't rely on that.
|
|
export BINDIR="./bin"
|
|
BIN="$BINDIR/golangci-lint"
|
|
if [ ! -x "$BIN" ]; then
|
|
install
|
|
else
|
|
# Prints its own file name as part of --version output
|
|
$BIN --version | grep "$VERSION"
|
|
if [ $? -eq 0 ]; then
|
|
echo "Using existing $BINDIR/$($BIN --version)"
|
|
else
|
|
install
|
|
fi
|
|
fi
|