mirror of
https://github.com/containers/podman.git
synced 2025-09-26 08:14:14 +08:00
5fc622f945
Much to my regret, there is a number of images in the wild with invalid platforms breaking the platform checks in libimage that want to make sure that a local image is matching the expected platform. Imagine a `podman run --arch=arm64 fedora` with a local amd64 fedora image. We really shouldn't use the local one in this case and pull down the arm64 one. The strict platform checks in libimage in combination with invalid platforms in images surfaced in Podman being able to pull an image but failing to look it up in subsequent presence checks. A `podman run` would hence pull such an image but fail to create the container. Support images with invalid platforms by vendoring the latest HEAD from containers/common. Also remove the partially implemented pull-policy logic from Podman and let libimage handle that entirely. However, whenever --arch, --os or --platform are specified, the pull policy will be forced to "newer". This way, we pessimistically assume that the local image has an invalid platform and we reach out to the registry. If there's a newer image (i.e., one with a different digest), we'll pull it down. Please note that most of the logic has either already been implemented in libimage or been moved down which allows for removing some clutter from Podman. [NO TESTS NEEDED] since c/common has new tests. Podman can rely on the existing tests. Fixes: #10648 Fixes: #10682 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
99 lines
2.5 KiB
Go
99 lines
2.5 KiB
Go
package images
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"os"
|
|
"strconv"
|
|
|
|
"github.com/containers/podman/v3/pkg/auth"
|
|
"github.com/containers/podman/v3/pkg/bindings"
|
|
"github.com/containers/podman/v3/pkg/domain/entities"
|
|
"github.com/containers/podman/v3/pkg/errorhandling"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
// Pull is the binding for libpod's v2 endpoints for pulling images. Note that
|
|
// `rawImage` must be a reference to a registry (i.e., of docker transport or be
|
|
// normalized to one). Other transports are rejected as they do not make sense
|
|
// in a remote context. Progress reported on stderr
|
|
func Pull(ctx context.Context, rawImage string, options *PullOptions) ([]string, error) {
|
|
if options == nil {
|
|
options = new(PullOptions)
|
|
}
|
|
conn, err := bindings.GetClient(ctx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
params, err := options.ToParams()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
params.Set("reference", rawImage)
|
|
|
|
if options.SkipTLSVerify != nil {
|
|
params.Del("SkipTLSVerify")
|
|
// Note: we have to verify if skipped is false.
|
|
params.Set("tlsVerify", strconv.FormatBool(!options.GetSkipTLSVerify()))
|
|
}
|
|
|
|
// TODO: have a global system context we can pass around (1st argument)
|
|
header, err := auth.Header(nil, auth.XRegistryAuthHeader, options.GetAuthfile(), options.GetUsername(), options.GetPassword())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
response, err := conn.DoRequest(nil, http.MethodPost, "/images/pull", params, header)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer response.Body.Close()
|
|
|
|
if !response.IsSuccess() {
|
|
return nil, response.Process(err)
|
|
}
|
|
|
|
// Historically pull writes status to stderr
|
|
stderr := io.Writer(os.Stderr)
|
|
if options.GetQuiet() {
|
|
stderr = ioutil.Discard
|
|
}
|
|
|
|
dec := json.NewDecoder(response.Body)
|
|
var images []string
|
|
var pullErrors []error
|
|
for {
|
|
var report entities.ImagePullReport
|
|
if err := dec.Decode(&report); err != nil {
|
|
if errors.Is(err, io.EOF) {
|
|
break
|
|
}
|
|
report.Error = err.Error() + "\n"
|
|
}
|
|
|
|
select {
|
|
case <-response.Request.Context().Done():
|
|
break
|
|
default:
|
|
// non-blocking select
|
|
}
|
|
|
|
switch {
|
|
case report.Stream != "":
|
|
fmt.Fprint(stderr, report.Stream)
|
|
case report.Error != "":
|
|
pullErrors = append(pullErrors, errors.New(report.Error))
|
|
case len(report.Images) > 0:
|
|
images = report.Images
|
|
case report.ID != "":
|
|
default:
|
|
return images, errors.Errorf("failed to parse pull results stream, unexpected input: %v", report)
|
|
}
|
|
}
|
|
return images, errorhandling.JoinErrors(pullErrors)
|
|
}
|