mirror of
https://github.com/containers/podman.git
synced 2025-07-15 03:02:52 +08:00
ab29ff2f66
There is no reason to define the same code every time in each file, just use global nodes. This diff should speak for itself. CleanupSecrets()/Volume() no longer call Cleanup() directly, as the global AfterEach node will always call Cleanup() this is no longer necessary. If one AfterEach() node fails it will still run the others. Also always unset the CONTAINERS_CONF env vars. This prevents people from forgetting to unset it. And fix the special CONTAINERS_CONF logic in the system connection tests, we do not want to preserve CONTAINERS_CONF anyway so just remove this logic. Ginkgo orders the BeforeEach and AfterEach nodes. They will be executed from the outer-most defined to inner-most. This means our global BeforeEach is always first. Only then the inner one (in the Describe() function in each file). For AfterEach it is inverted, from the inner to the outer. Also see https://onsi.github.io/ginkgo/#organizing-specs-with-container-nodes Signed-off-by: Paul Holzinger <pholzing@redhat.com>
61 lines
1.8 KiB
Go
61 lines
1.8 KiB
Go
package integration
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
|
|
"github.com/containers/common/pkg/config"
|
|
. "github.com/containers/podman/v4/test/utils"
|
|
"github.com/containers/storage/pkg/homedir"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
. "github.com/onsi/gomega/gexec"
|
|
)
|
|
|
|
var _ = Describe("podman image scp", func() {
|
|
|
|
BeforeEach(setupEmptyContainersConf)
|
|
|
|
It("podman image scp bogus image", func() {
|
|
scp := podmanTest.Podman([]string{"image", "scp", "FOOBAR"})
|
|
scp.WaitWithDefaultTimeout()
|
|
Expect(scp).Should(ExitWithError())
|
|
})
|
|
|
|
It("podman image scp with proper connection", func() {
|
|
if _, err := os.Stat(filepath.Join(homedir.Get(), ".ssh", "known_hosts")); err != nil {
|
|
Skip("known_hosts does not exist or is not accessible")
|
|
}
|
|
cmd := []string{"system", "connection", "add",
|
|
"--default",
|
|
"QA",
|
|
"ssh://root@podman.test:2222/run/podman/podman.sock",
|
|
}
|
|
session := podmanTest.Podman(cmd)
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
cfg, err := config.ReadCustomConfig()
|
|
Expect(err).ShouldNot(HaveOccurred())
|
|
Expect(cfg.Engine).Should(HaveField("ActiveService", "QA"))
|
|
Expect(cfg.Engine.ServiceDestinations).To(HaveKeyWithValue("QA",
|
|
config.Destination{
|
|
URI: "ssh://root@podman.test:2222/run/podman/podman.sock",
|
|
},
|
|
))
|
|
|
|
scp := podmanTest.Podman([]string{"image", "scp", ALPINE, "QA::"})
|
|
scp.WaitWithDefaultTimeout()
|
|
// exit with error because we cannot make an actual ssh connection
|
|
// This tests that the input we are given is validated and prepared correctly
|
|
// The error given should either be a missing image (due to testing suite complications) or a no such host timeout on ssh
|
|
Expect(scp).Should(ExitWithError())
|
|
// podman-remote exits with a different error
|
|
if !IsRemote() {
|
|
Expect(scp.ErrorToString()).Should(ContainSubstring("no such host"))
|
|
}
|
|
|
|
})
|
|
|
|
})
|