mirror of
https://github.com/containers/podman.git
synced 2025-12-05 21:32:22 +08:00
overlayfs -- the kernel's version, not fuse-overlayfs -- recently learned
(as of linux 5.16.0, I believe) how to support rootless users. Previously,
rootless users had to use these storage.conf(5) settings:
* storage.driver=vfs (aka STORAGE_DRIVER=vfs), or
* storage.driver=overlay (aka STORAGE_DRIVER=overlay),
storage.options.overlay.mount_program=/usr/bin/fuse-overlayfs
(aka STORAGE_OPTS=/usr/bin/fuse-overlayfs)
Now that a third backend is available, setting only:
* storage.driver=overlay (aka STORAGE_DRIVER=overlay)
https://github.com/containers/podman/issues/13123 reported EXDEV errors
during the normal operation of their container. Tracing it out, the
problem turned out to be that their container was being mounted without
'userxattr'; I don't fully understand why, but mount(8) mentions this is
needed for rootless users:
> userxattr
>
> Use the "user.overlay." xattr namespace instead of "trusted.overlay.".
> This is useful for unprivileged mounting of overlayfs.
https://github.com/containers/storage/pull/1156 found and fixed the issue
in podman, and this just pulls in that via
go get github.com/containers/storage@ebc90ab
go mod vendor
make vendor
Closes https://github.com/containers/podman/issues/13123
Signed-off-by: Nick Guenther <nick.guenther@polymtl.ca>
110 lines
2.5 KiB
Go
110 lines
2.5 KiB
Go
//go:build !windows
|
|
// +build !windows
|
|
|
|
package graphdriver
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"sync"
|
|
"syscall"
|
|
|
|
"github.com/containers/storage/pkg/idtools"
|
|
"github.com/containers/storage/pkg/system"
|
|
)
|
|
|
|
type inode struct {
|
|
Dev uint64
|
|
Ino uint64
|
|
}
|
|
|
|
type platformChowner struct {
|
|
mutex sync.Mutex
|
|
inodes map[inode]bool
|
|
}
|
|
|
|
func newLChowner() *platformChowner {
|
|
return &platformChowner{
|
|
inodes: make(map[inode]bool),
|
|
}
|
|
}
|
|
|
|
func (c *platformChowner) LChown(path string, info os.FileInfo, toHost, toContainer *idtools.IDMappings) error {
|
|
st, ok := info.Sys().(*syscall.Stat_t)
|
|
if !ok {
|
|
return nil
|
|
}
|
|
|
|
i := inode{
|
|
Dev: uint64(st.Dev),
|
|
Ino: uint64(st.Ino),
|
|
}
|
|
c.mutex.Lock()
|
|
_, found := c.inodes[i]
|
|
if !found {
|
|
c.inodes[i] = true
|
|
}
|
|
c.mutex.Unlock()
|
|
|
|
if found {
|
|
return nil
|
|
}
|
|
|
|
// Map an on-disk UID/GID pair from host to container
|
|
// using the first map, then back to the host using the
|
|
// second map. Skip that first step if they're 0, to
|
|
// compensate for cases where a parent layer should
|
|
// have had a mapped value, but didn't.
|
|
uid, gid := int(st.Uid), int(st.Gid)
|
|
if toContainer != nil {
|
|
pair := idtools.IDPair{
|
|
UID: uid,
|
|
GID: gid,
|
|
}
|
|
mappedUID, mappedGID, err := toContainer.ToContainer(pair)
|
|
if err != nil {
|
|
if (uid != 0) || (gid != 0) {
|
|
return fmt.Errorf("error mapping host ID pair %#v for %q to container: %v", pair, path, err)
|
|
}
|
|
mappedUID, mappedGID = uid, gid
|
|
}
|
|
uid, gid = mappedUID, mappedGID
|
|
}
|
|
if toHost != nil {
|
|
pair := idtools.IDPair{
|
|
UID: uid,
|
|
GID: gid,
|
|
}
|
|
mappedPair, err := toHost.ToHost(pair)
|
|
if err != nil {
|
|
return fmt.Errorf("error mapping container ID pair %#v for %q to host: %v", pair, path, err)
|
|
}
|
|
uid, gid = mappedPair.UID, mappedPair.GID
|
|
}
|
|
if uid != int(st.Uid) || gid != int(st.Gid) {
|
|
cap, err := system.Lgetxattr(path, "security.capability")
|
|
if err != nil && !errors.Is(err, system.EOPNOTSUPP) && err != system.ErrNotSupportedPlatform {
|
|
return fmt.Errorf("%s: %v", os.Args[0], err)
|
|
}
|
|
|
|
// Make the change.
|
|
if err := system.Lchown(path, uid, gid); err != nil {
|
|
return fmt.Errorf("%s: %v", os.Args[0], err)
|
|
}
|
|
// Restore the SUID and SGID bits if they were originally set.
|
|
if (info.Mode()&os.ModeSymlink == 0) && info.Mode()&(os.ModeSetuid|os.ModeSetgid) != 0 {
|
|
if err := system.Chmod(path, info.Mode()); err != nil {
|
|
return fmt.Errorf("%s: %v", os.Args[0], err)
|
|
}
|
|
}
|
|
if cap != nil {
|
|
if err := system.Lsetxattr(path, "security.capability", cap, 0); err != nil {
|
|
return fmt.Errorf("%s: %v", os.Args[0], err)
|
|
}
|
|
}
|
|
|
|
}
|
|
return nil
|
|
}
|