mirror of
https://github.com/containers/podman.git
synced 2025-06-11 01:58:37 +08:00
09dc701097
While this commit was initially meant to fix #5847, it has turned into a bigger refactoring which I did not manage to break into smaller pieces: * Fix #5847 by refactoring the image-removal logic. * Make the api handler for image-removal use the ABI code. This way, both (i.e., ABI and Tunnel) end up using the same code. Achieving this code share required to move some code around to prevent circular dependencies. * Everything in pkg/api (excluding pkg/api/types) must now only be accessed from code using `ABISupport`. * Avoid imports from entities on handlers to prevent circular dependencies. * Move `podman system service` logic into `cmd` to prevent circular dependencies - it depends on pkg/api. * Also remove the build header from infra/abi files. It will otherwise confuse swagger and other tools; errors we cannot fix as go doesn't expose a build-tag env variable. Fixes: #5847 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
25 lines
731 B
Bash
Executable File
25 lines
731 B
Bash
Executable File
#!/bin/bash -e
|
|
|
|
# Need to run linter twice to cover all the build tags code paths
|
|
|
|
declare -A BUILD_TAGS
|
|
# TODO: add systemd tag
|
|
BUILD_TAGS[default]="apparmor,seccomp,selinux"
|
|
BUILD_TAGS[abi]="${BUILD_TAGS[default]},ABISupport,varlink,!remoteclient"
|
|
BUILD_TAGS[tunnel]="${BUILD_TAGS[default]},!ABISupport,varlink,remoteclient"
|
|
|
|
declare -A SKIP_DIRS
|
|
SKIP_DIRS[abi]=""
|
|
# TODO: add "ABISupport" build tag to pkg/api
|
|
SKIP_DIRS[tunnel]="pkg/api"
|
|
|
|
[[ $1 == run ]] && shift
|
|
|
|
for i in tunnel abi; do
|
|
echo ""
|
|
echo Running golangci-lint for "$i"
|
|
echo Build Tags "$i": ${BUILD_TAGS[$i]}
|
|
echo Skipped directories "$i": ${SKIP_DIRS[$i]}
|
|
golangci-lint run --build-tags=${BUILD_TAGS[$i]} --skip-dirs=${SKIP_DIRS[$i]} "$@"
|
|
done
|