mirror of
https://github.com/containers/podman.git
synced 2025-05-30 23:17:20 +08:00
4b784b377c
This was inspired by https://github.com/cri-o/cri-o/pull/3934 and much of the logic for it is contained there. However, in brief, a named return called "err" can cause lots of code confusion and encourages using the wrong err variable in defer statements, which can make them work incorrectly. Using a separate name which is not used elsewhere makes it very clear what the defer should be doing. As part of this, remove a large number of named returns that were not used anywhere. Most of them were once needed, but are no longer necessary after previous refactors (but were accidentally retained). Signed-off-by: Matthew Heon <matthew.heon@pm.me>
28 lines
772 B
Go
28 lines
772 B
Go
package events
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"github.com/pkg/errors"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
// NewEventer creates an eventer based on the eventer type
|
|
func NewEventer(options EventerOptions) (Eventer, error) {
|
|
logrus.Debugf("Initializing event backend %s", options.EventerType)
|
|
switch strings.ToUpper(options.EventerType) {
|
|
case strings.ToUpper(Journald.String()):
|
|
eventer, err := newEventJournalD(options)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "eventer creation")
|
|
}
|
|
return eventer, nil
|
|
case strings.ToUpper(LogFile.String()):
|
|
return EventLogFile{options}, nil
|
|
case strings.ToUpper(Null.String()):
|
|
return NewNullEventer(), nil
|
|
default:
|
|
return nil, errors.Errorf("unknown event logger type: %s", strings.ToUpper(options.EventerType))
|
|
}
|
|
}
|