mirror of
https://github.com/containers/podman.git
synced 2025-05-25 19:16:59 +08:00
2fb6cc2cea
when using an upper case image name for container commit, we observed panics due to a channel closing early. Fixes: #3897 Signed-off-by: baude <bbaude@redhat.com>
48 lines
1011 B
Go
48 lines
1011 B
Go
package endpoint
|
|
|
|
import (
|
|
"encoding/json"
|
|
"os"
|
|
|
|
. "github.com/containers/libpod/test/utils"
|
|
. "github.com/onsi/ginkgo"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("Podman commit", func() {
|
|
var (
|
|
tempdir string
|
|
err error
|
|
endpointTest *EndpointTestIntegration
|
|
)
|
|
|
|
BeforeEach(func() {
|
|
tempdir, err = CreateTempDirInTempDir()
|
|
if err != nil {
|
|
os.Exit(1)
|
|
}
|
|
endpointTest = Setup(tempdir)
|
|
endpointTest.StartVarlinkWithCache()
|
|
})
|
|
|
|
AfterEach(func() {
|
|
endpointTest.Cleanup()
|
|
|
|
})
|
|
|
|
It("ensure commit with uppercase image name does not panic", func() {
|
|
body := make(map[string]string)
|
|
body["image_name"] = "FOO"
|
|
body["format"] = "oci"
|
|
body["name"] = "top"
|
|
b, err := json.Marshal(body)
|
|
Expect(err).To(BeNil())
|
|
// run the container to be committed
|
|
_ = endpointTest.startTopContainer("top")
|
|
result := endpointTest.Varlink("Commit", string(b), false)
|
|
// This indicates an error occured
|
|
Expect(len(result.StdErrToString())).To(BeNumerically(">", 0))
|
|
})
|
|
|
|
})
|