mirror of
https://github.com/containers/podman.git
synced 2025-05-25 19:16:59 +08:00

Pulling fedora-minimal was potentially causing timeouts, which is bad. Using the cache avoids that. Sig-proxy=false test was entirely nonfunctional - I think we didn't update it when we fixed sig-proxy=true to be less racy. It was still passing, which is concerning. Signed-off-by: Matthew Heon <mheon@redhat.com>
141 lines
3.5 KiB
Go
141 lines
3.5 KiB
Go
// +build !remoteclient
|
|
|
|
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"syscall"
|
|
"time"
|
|
|
|
"github.com/containers/libpod/pkg/rootless"
|
|
. "github.com/containers/libpod/test/utils"
|
|
. "github.com/onsi/ginkgo"
|
|
. "github.com/onsi/gomega"
|
|
"golang.org/x/sys/unix"
|
|
)
|
|
|
|
const sigCatch = "trap \"echo FOO >> /h/fifo \" 8; echo READY >> /h/fifo; while :; do sleep 0.25; done"
|
|
const sigCatch2 = "trap \"echo Received\" SIGFPE; while :; do sleep 0.25; done"
|
|
|
|
var _ = Describe("Podman run with --sig-proxy", func() {
|
|
var (
|
|
tmpdir string
|
|
err error
|
|
podmanTest *PodmanTestIntegration
|
|
)
|
|
|
|
BeforeEach(func() {
|
|
tmpdir, err = CreateTempDirInTempDir()
|
|
if err != nil {
|
|
os.Exit(1)
|
|
}
|
|
podmanTest = PodmanTestCreate(tmpdir)
|
|
podmanTest.Setup()
|
|
podmanTest.SeedImages()
|
|
})
|
|
|
|
AfterEach(func() {
|
|
podmanTest.Cleanup()
|
|
f := CurrentGinkgoTestDescription()
|
|
processTestResult(f)
|
|
|
|
})
|
|
|
|
Specify("signals are forwarded to container using sig-proxy", func() {
|
|
if podmanTest.Host.Arch == "ppc64le" {
|
|
Skip("Doesnt work on ppc64le")
|
|
}
|
|
signal := syscall.SIGFPE
|
|
// Set up a socket for communication
|
|
udsDir := filepath.Join(tmpdir, "socket")
|
|
os.Mkdir(udsDir, 0700)
|
|
udsPath := filepath.Join(udsDir, "fifo")
|
|
syscall.Mkfifo(udsPath, 0600)
|
|
if rootless.IsRootless() {
|
|
podmanTest.RestoreArtifact(fedoraMinimal)
|
|
}
|
|
_, pid := podmanTest.PodmanPID([]string{"run", "-it", "-v", fmt.Sprintf("%s:/h:Z", udsDir), fedoraMinimal, "bash", "-c", sigCatch})
|
|
|
|
uds, _ := os.OpenFile(udsPath, os.O_RDONLY|syscall.O_NONBLOCK, 0600)
|
|
defer uds.Close()
|
|
|
|
// Wait for the script in the container to alert us that it is READY
|
|
counter := 0
|
|
for {
|
|
buf := make([]byte, 1024)
|
|
n, err := uds.Read(buf[:])
|
|
if err != nil && err != io.EOF {
|
|
fmt.Println(err)
|
|
return
|
|
}
|
|
data := string(buf[0:n])
|
|
if strings.Contains(data, "READY") {
|
|
break
|
|
}
|
|
time.Sleep(1 * time.Second)
|
|
if counter == 15 {
|
|
Fail("Timed out waiting for READY from container")
|
|
}
|
|
counter++
|
|
}
|
|
// Ok, container is up and running now and so is the script
|
|
|
|
if err := unix.Kill(pid, signal); err != nil {
|
|
Fail(fmt.Sprintf("error killing podman process %d: %v", pid, err))
|
|
}
|
|
|
|
// The sending of the signal above will send FOO to the socket; here we
|
|
// listen to the socket for that.
|
|
counter = 0
|
|
for {
|
|
buf := make([]byte, 1024)
|
|
n, err := uds.Read(buf[:])
|
|
if err != nil {
|
|
fmt.Println(err)
|
|
return
|
|
}
|
|
data := string(buf[0:n])
|
|
if strings.Contains(data, "FOO") {
|
|
break
|
|
}
|
|
time.Sleep(1 * time.Second)
|
|
if counter == 15 {
|
|
Fail("timed out waiting for FOO from container")
|
|
}
|
|
counter++
|
|
}
|
|
})
|
|
|
|
Specify("signals are not forwarded to container with sig-proxy false", func() {
|
|
signal := syscall.SIGFPE
|
|
if rootless.IsRootless() {
|
|
podmanTest.RestoreArtifact(fedoraMinimal)
|
|
}
|
|
session, pid := podmanTest.PodmanPID([]string{"run", "--name", "test2", "--sig-proxy=false", fedoraMinimal, "bash", "-c", sigCatch2})
|
|
|
|
ok := WaitForContainer(podmanTest)
|
|
Expect(ok).To(BeTrue())
|
|
|
|
// Kill with given signal
|
|
// Should be no output, SIGPOLL is usually ignored
|
|
if err := unix.Kill(pid, signal); err != nil {
|
|
Fail(fmt.Sprintf("error killing podman process %d: %v", pid, err))
|
|
}
|
|
|
|
// Kill with -9 to guarantee the container dies
|
|
killSession := podmanTest.Podman([]string{"kill", "-s", "9", "test2"})
|
|
killSession.WaitWithDefaultTimeout()
|
|
Expect(killSession.ExitCode()).To(Equal(0))
|
|
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session.ExitCode()).To(Equal(137))
|
|
ok, _ = session.GrepString("Received")
|
|
Expect(ok).To(BeFalse())
|
|
})
|
|
|
|
})
|