mirror of
https://github.com/containers/podman.git
synced 2025-08-06 03:19:52 +08:00
280f5d8cb0
implement new ssh interface into podman this completely redesigns the entire functionality of podman image scp, podman system connection add, and podman --remote. All references to golang.org/x/crypto/ssh have been moved to common as have native ssh/scp execs and the new usage of the sftp package. this PR adds a global flag, --ssh to podman which has two valid inputs `golang` and `native` where golang is the default. Users should not notice any difference in their everyday workflows if they continue using the golang option. UNLESS they have been using an improperly verified ssh key, this will now fail. This is because podman was incorrectly using the ssh callback method to IGNORE the ssh known hosts file which is very insecure and golang tells you not yo use this in production. The native paths allows for immense flexibility, with a new containers.conf field `SSH_CONFIG` that specifies a specific ssh config file to be used in all operations. Else the users ~/.ssh/config file will be used. podman --remote currently only uses the golang path, given its deep interconnection with dialing multiple clients and urls. My goal after this PR is to go back and abstract the idea of podman --remote from golang's dialed clients, as it should not be so intrinsically connected. Overall, this is a v1 of a long process of offering native ssh, and one that covers some good ground with podman system connection add and podman image scp. Signed-off-by: Charlie Doern <cdoern@redhat.com>
64 lines
2.1 KiB
Go
64 lines
2.1 KiB
Go
package sftp
|
|
|
|
// Methods on the Request object to make working with the Flags bitmasks and
|
|
// Attr(ibutes) byte blob easier. Use Pflags() when working with an Open/Write
|
|
// request and AttrFlags() and Attributes() when working with SetStat requests.
|
|
import "os"
|
|
|
|
// FileOpenFlags defines Open and Write Flags. Correlate directly with with os.OpenFile flags
|
|
// (https://golang.org/pkg/os/#pkg-constants).
|
|
type FileOpenFlags struct {
|
|
Read, Write, Append, Creat, Trunc, Excl bool
|
|
}
|
|
|
|
func newFileOpenFlags(flags uint32) FileOpenFlags {
|
|
return FileOpenFlags{
|
|
Read: flags&sshFxfRead != 0,
|
|
Write: flags&sshFxfWrite != 0,
|
|
Append: flags&sshFxfAppend != 0,
|
|
Creat: flags&sshFxfCreat != 0,
|
|
Trunc: flags&sshFxfTrunc != 0,
|
|
Excl: flags&sshFxfExcl != 0,
|
|
}
|
|
}
|
|
|
|
// Pflags converts the bitmap/uint32 from SFTP Open packet pflag values,
|
|
// into a FileOpenFlags struct with booleans set for flags set in bitmap.
|
|
func (r *Request) Pflags() FileOpenFlags {
|
|
return newFileOpenFlags(r.Flags)
|
|
}
|
|
|
|
// FileAttrFlags that indicate whether SFTP file attributes were passed. When a flag is
|
|
// true the corresponding attribute should be available from the FileStat
|
|
// object returned by Attributes method. Used with SetStat.
|
|
type FileAttrFlags struct {
|
|
Size, UidGid, Permissions, Acmodtime bool
|
|
}
|
|
|
|
func newFileAttrFlags(flags uint32) FileAttrFlags {
|
|
return FileAttrFlags{
|
|
Size: (flags & sshFileXferAttrSize) != 0,
|
|
UidGid: (flags & sshFileXferAttrUIDGID) != 0,
|
|
Permissions: (flags & sshFileXferAttrPermissions) != 0,
|
|
Acmodtime: (flags & sshFileXferAttrACmodTime) != 0,
|
|
}
|
|
}
|
|
|
|
// AttrFlags returns a FileAttrFlags boolean struct based on the
|
|
// bitmap/uint32 file attribute flags from the SFTP packaet.
|
|
func (r *Request) AttrFlags() FileAttrFlags {
|
|
return newFileAttrFlags(r.Flags)
|
|
}
|
|
|
|
// FileMode returns the Mode SFTP file attributes wrapped as os.FileMode
|
|
func (a FileStat) FileMode() os.FileMode {
|
|
return os.FileMode(a.Mode)
|
|
}
|
|
|
|
// Attributes parses file attributes byte blob and return them in a
|
|
// FileStat object.
|
|
func (r *Request) Attributes() *FileStat {
|
|
fs, _ := unmarshalFileStat(r.Flags, r.Attrs)
|
|
return fs
|
|
}
|