mirror of
https://github.com/containers/podman.git
synced 2025-05-22 01:27:07 +08:00
0f7d54b026
Migrate the Podman code base over to `common/libimage` which replaces `libpod/image` and a lot of glue code entirely. Note that I tried to leave bread crumbs for changed tests. Miscellaneous changes: * Some errors yield different messages which required to alter some tests. * I fixed some pre-existing issues in the code. Others were marked as `//TODO`s to prevent the PR from exploding. * The `NamesHistory` of an image is returned as is from the storage. Previously, we did some filtering which I think is undesirable. Instead we should return the data as stored in the storage. * Touched handlers use the ABI interfaces where possible. * Local image resolution: previously Podman would match "foo" on "myfoo". This behaviour has been changed and Podman will now only match on repository boundaries such that "foo" would match "my/foo" but not "myfoo". I consider the old behaviour to be a bug, at the very least an exotic corner case. * Futhermore, "foo:none" does *not* resolve to a local image "foo" without tag anymore. It's a hill I am (almost) willing to die on. * `image prune` prints the IDs of pruned images. Previously, in some cases, the names were printed instead. The API clearly states ID, so we should stick to it. * Compat endpoint image removal with _force_ deletes the entire not only the specified tag. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
110 lines
3.4 KiB
Go
110 lines
3.4 KiB
Go
package utils
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
|
|
"github.com/containers/podman/v3/libpod/define"
|
|
"github.com/containers/podman/v3/pkg/errorhandling"
|
|
"github.com/containers/storage"
|
|
"github.com/pkg/errors"
|
|
log "github.com/sirupsen/logrus"
|
|
)
|
|
|
|
var (
|
|
ErrLinkNotSupport = errors.New("Link is not supported")
|
|
)
|
|
|
|
// TODO: document the exported functions in this file and make them more
|
|
// generic (e.g., not tied to one ctr/pod).
|
|
|
|
// Error formats an API response to an error
|
|
//
|
|
// apiMessage and code must match the container API, and are sent to client
|
|
// err is logged on the system running the podman service
|
|
func Error(w http.ResponseWriter, apiMessage string, code int, err error) {
|
|
// Log detailed message of what happened to machine running podman service
|
|
log.Infof("Request Failed(%s): %s", http.StatusText(code), err.Error())
|
|
em := errorhandling.ErrorModel{
|
|
Because: (errors.Cause(err)).Error(),
|
|
Message: err.Error(),
|
|
ResponseCode: code,
|
|
}
|
|
WriteJSON(w, code, em)
|
|
}
|
|
|
|
func VolumeNotFound(w http.ResponseWriter, name string, err error) {
|
|
if errors.Cause(err) != define.ErrNoSuchVolume {
|
|
InternalServerError(w, err)
|
|
}
|
|
msg := fmt.Sprintf("No such volume: %s", name)
|
|
Error(w, msg, http.StatusNotFound, err)
|
|
}
|
|
|
|
func ContainerNotFound(w http.ResponseWriter, name string, err error) {
|
|
if errors.Cause(err) != define.ErrNoSuchCtr {
|
|
InternalServerError(w, err)
|
|
}
|
|
msg := fmt.Sprintf("No such container: %s", name)
|
|
Error(w, msg, http.StatusNotFound, err)
|
|
}
|
|
|
|
func ImageNotFound(w http.ResponseWriter, name string, err error) {
|
|
if errors.Cause(err) != storage.ErrImageUnknown {
|
|
InternalServerError(w, err)
|
|
}
|
|
msg := fmt.Sprintf("No such image: %s", name)
|
|
Error(w, msg, http.StatusNotFound, err)
|
|
}
|
|
|
|
func NetworkNotFound(w http.ResponseWriter, name string, err error) {
|
|
if errors.Cause(err) != define.ErrNoSuchNetwork {
|
|
InternalServerError(w, err)
|
|
}
|
|
msg := fmt.Sprintf("No such network: %s", name)
|
|
Error(w, msg, http.StatusNotFound, err)
|
|
}
|
|
|
|
func PodNotFound(w http.ResponseWriter, name string, err error) {
|
|
if errors.Cause(err) != define.ErrNoSuchPod {
|
|
InternalServerError(w, err)
|
|
}
|
|
msg := fmt.Sprintf("No such pod: %s", name)
|
|
Error(w, msg, http.StatusNotFound, err)
|
|
}
|
|
|
|
func SessionNotFound(w http.ResponseWriter, name string, err error) {
|
|
if errors.Cause(err) != define.ErrNoSuchExecSession {
|
|
InternalServerError(w, err)
|
|
}
|
|
msg := fmt.Sprintf("No such exec session: %s", name)
|
|
Error(w, msg, http.StatusNotFound, err)
|
|
}
|
|
|
|
func SecretNotFound(w http.ResponseWriter, nameOrID string, err error) {
|
|
if errors.Cause(err).Error() != "no such secret" {
|
|
InternalServerError(w, err)
|
|
}
|
|
msg := fmt.Sprintf("No such secret: %s", nameOrID)
|
|
Error(w, msg, http.StatusNotFound, err)
|
|
}
|
|
|
|
func ContainerNotRunning(w http.ResponseWriter, containerID string, err error) {
|
|
msg := fmt.Sprintf("Container %s is not running", containerID)
|
|
Error(w, msg, http.StatusConflict, err)
|
|
}
|
|
|
|
func InternalServerError(w http.ResponseWriter, err error) {
|
|
Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError, err)
|
|
}
|
|
|
|
func BadRequest(w http.ResponseWriter, key string, value string, err error) {
|
|
e := errors.Wrapf(err, "failed to parse query parameter '%s': %q", key, value)
|
|
Error(w, http.StatusText(http.StatusBadRequest), http.StatusBadRequest, e)
|
|
}
|
|
|
|
// UnsupportedParameter logs a given param by its string name as not supported.
|
|
func UnSupportedParameter(param string) {
|
|
log.Infof("API parameter %q: not supported", param)
|
|
}
|