mirror of
https://github.com/containers/podman.git
synced 2025-06-09 00:53:41 +08:00
5fc622f945
Much to my regret, there is a number of images in the wild with invalid platforms breaking the platform checks in libimage that want to make sure that a local image is matching the expected platform. Imagine a `podman run --arch=arm64 fedora` with a local amd64 fedora image. We really shouldn't use the local one in this case and pull down the arm64 one. The strict platform checks in libimage in combination with invalid platforms in images surfaced in Podman being able to pull an image but failing to look it up in subsequent presence checks. A `podman run` would hence pull such an image but fail to create the container. Support images with invalid platforms by vendoring the latest HEAD from containers/common. Also remove the partially implemented pull-policy logic from Podman and let libimage handle that entirely. However, whenever --arch, --os or --platform are specified, the pull policy will be forced to "newer". This way, we pessimistically assume that the local image has an invalid platform and we reach out to the registry. If there's a newer image (i.e., one with a different digest), we'll pull it down. Please note that most of the logic has either already been implemented in libimage or been moved down which allows for removing some clutter from Podman. [NO TESTS NEEDED] since c/common has new tests. Podman can rely on the existing tests. Fixes: #10648 Fixes: #10682 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
109 lines
2.7 KiB
Go
109 lines
2.7 KiB
Go
package errorhandling
|
|
|
|
import (
|
|
"os"
|
|
"strings"
|
|
|
|
"github.com/hashicorp/go-multierror"
|
|
"github.com/pkg/errors"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
// JoinErrors converts the error slice into a single human-readable error.
|
|
func JoinErrors(errs []error) error {
|
|
if len(errs) == 0 {
|
|
return nil
|
|
}
|
|
|
|
// If there's just one error, return it. This prevents the "%d errors
|
|
// occurred:" header plus list from the multierror package.
|
|
if len(errs) == 1 {
|
|
return errs[0]
|
|
}
|
|
|
|
// `multierror` appends new lines which we need to remove to prevent
|
|
// blank lines when printing the error.
|
|
var multiE *multierror.Error
|
|
multiE = multierror.Append(multiE, errs...)
|
|
|
|
finalErr := multiE.ErrorOrNil()
|
|
if finalErr == nil {
|
|
return finalErr
|
|
}
|
|
return errors.New(strings.TrimSpace(finalErr.Error()))
|
|
}
|
|
|
|
// ErrorsToString converts the slice of errors into a slice of corresponding
|
|
// error messages.
|
|
func ErrorsToStrings(errs []error) []string {
|
|
if len(errs) == 0 {
|
|
return nil
|
|
}
|
|
strErrs := make([]string, len(errs))
|
|
for i := range errs {
|
|
strErrs[i] = errs[i].Error()
|
|
}
|
|
return strErrs
|
|
}
|
|
|
|
// StringsToErrors converts a slice of error messages into a slice of
|
|
// corresponding errors.
|
|
func StringsToErrors(strErrs []string) []error {
|
|
if len(strErrs) == 0 {
|
|
return nil
|
|
}
|
|
errs := make([]error, len(strErrs))
|
|
for i := range strErrs {
|
|
errs[i] = errors.New(strErrs[i])
|
|
}
|
|
return errs
|
|
}
|
|
|
|
// SyncQuiet syncs a file and logs any error. Should only be used within
|
|
// a defer.
|
|
func SyncQuiet(f *os.File) {
|
|
if err := f.Sync(); err != nil {
|
|
logrus.Errorf("unable to sync file %s: %q", f.Name(), err)
|
|
}
|
|
}
|
|
|
|
// CloseQuiet closes a file and logs any error. Should only be used within
|
|
// a defer.
|
|
func CloseQuiet(f *os.File) {
|
|
if err := f.Close(); err != nil {
|
|
logrus.Errorf("unable to close file %s: %q", f.Name(), err)
|
|
}
|
|
}
|
|
|
|
// Contains checks if err's message contains sub's message. Contains should be
|
|
// used iff either err or sub has lost type information (e.g., due to
|
|
// marshaling). For typed errors, please use `errors.Contains(...)` or `Is()`
|
|
// in recent version of Go.
|
|
func Contains(err error, sub error) bool {
|
|
return strings.Contains(err.Error(), sub.Error())
|
|
}
|
|
|
|
// ErrorModel is used in remote connections with podman
|
|
type ErrorModel struct {
|
|
// API root cause formatted for automated parsing
|
|
// example: API root cause
|
|
Because string `json:"cause"`
|
|
// human error message, formatted for a human to read
|
|
// example: human error message
|
|
Message string `json:"message"`
|
|
// http response code
|
|
ResponseCode int `json:"response"`
|
|
}
|
|
|
|
func (e ErrorModel) Error() string {
|
|
return e.Message
|
|
}
|
|
|
|
func (e ErrorModel) Cause() error {
|
|
return errors.New(e.Because)
|
|
}
|
|
|
|
func (e ErrorModel) Code() int {
|
|
return e.ResponseCode
|
|
}
|