mirror of
https://github.com/containers/podman.git
synced 2025-06-02 19:02:10 +08:00
5bdd571b1e
The Docker-compatible REST API has historically behaved just as the rest of Podman and Buildah (and the atomic Docker in older RHEL/Fedora) where `containers-registries.conf` is centrally controlling which registries a short name may resolve to during pull or local image lookups. Please refer to a blog for more details [1]. Docker, however, is only resolving short names to docker.io which has been reported (see #12320) to break certain clients who rely on this behavior. In order to support this scenario, `containers.conf(5)` received a new option to control whether Podman's compat API resolves to docker.io only or behaves as before. Most endpoints allow for directly normalizing parameters that represent an image. If set in containers.conf, Podman will then normalize the references directly to docker.io. The build endpoint is an outlier since images are also referenced in Dockerfiles. The Buildah API, however, supports specifying a custom `types.SystemContext` in which we can set a field that enforces short-name resolution to docker.io in `c/image/pkg/shortnames`. Notice that this a "hybrid" approach of doing the normalization directly in the compat endpoints *and* in `pkg/shortnames` by passing a system context. Doing such a hybrid approach is neccessary since the compat and the libpod endpoints share the same `libimage.Runtime` which makes a global enforcement via the `libimage.Runtime.systemContext` impossible. Having two separate runtimes for the compat and the libpod endpoints seems risky and not generally applicable to all endpoints. [1] https://www.redhat.com/sysadmin/container-image-short-names Fixes: #12320 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
72 lines
2.2 KiB
Go
72 lines
2.2 KiB
Go
package compat
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"github.com/containers/podman/v3/libpod"
|
|
"github.com/containers/podman/v3/pkg/api/handlers/utils"
|
|
api "github.com/containers/podman/v3/pkg/api/types"
|
|
"github.com/containers/podman/v3/pkg/domain/entities"
|
|
"github.com/containers/podman/v3/pkg/domain/infra/abi"
|
|
"github.com/containers/storage"
|
|
"github.com/gorilla/schema"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
func RemoveImage(w http.ResponseWriter, r *http.Request) {
|
|
decoder := r.Context().Value(api.DecoderKey).(*schema.Decoder)
|
|
runtime := r.Context().Value(api.RuntimeKey).(*libpod.Runtime)
|
|
|
|
query := struct {
|
|
Force bool `schema:"force"`
|
|
NoPrune bool `schema:"noprune"`
|
|
}{
|
|
// This is where you can override the golang default value for one of fields
|
|
}
|
|
|
|
if err := decoder.Decode(&query, r.URL.Query()); err != nil {
|
|
utils.Error(w, "Something went wrong.", http.StatusBadRequest, errors.Wrapf(err, "failed to parse parameters for %s", r.URL.String()))
|
|
return
|
|
}
|
|
if _, found := r.URL.Query()["noprune"]; found {
|
|
if query.NoPrune {
|
|
utils.UnSupportedParameter("noprune")
|
|
}
|
|
}
|
|
name := utils.GetName(r)
|
|
possiblyNormalizedName, err := utils.NormalizeToDockerHub(r, name)
|
|
if err != nil {
|
|
utils.Error(w, "Something went wrong.", http.StatusInternalServerError, errors.Wrap(err, "error normalizing image"))
|
|
return
|
|
}
|
|
|
|
imageEngine := abi.ImageEngine{Libpod: runtime}
|
|
|
|
options := entities.ImageRemoveOptions{
|
|
Force: query.Force,
|
|
}
|
|
report, rmerrors := imageEngine.Remove(r.Context(), []string{possiblyNormalizedName}, options)
|
|
if len(rmerrors) > 0 && rmerrors[0] != nil {
|
|
err := rmerrors[0]
|
|
if errors.Cause(err) == storage.ErrImageUnknown {
|
|
utils.ImageNotFound(w, name, errors.Wrapf(err, "failed to find image %s", name))
|
|
return
|
|
}
|
|
|
|
utils.Error(w, "Something went wrong.", http.StatusInternalServerError, err)
|
|
return
|
|
}
|
|
response := make([]map[string]string, 0, len(report.Untagged)+1)
|
|
for _, d := range report.Deleted {
|
|
deleted := make(map[string]string, 1)
|
|
deleted["Deleted"] = d
|
|
response = append(response, deleted)
|
|
}
|
|
for _, u := range report.Untagged {
|
|
untagged := make(map[string]string, 1)
|
|
untagged["Untagged"] = u
|
|
response = append(response, untagged)
|
|
}
|
|
utils.WriteResponse(w, http.StatusOK, response)
|
|
}
|