mirror of
https://github.com/containers/podman.git
synced 2025-10-25 02:04:43 +08:00
b53cb57680
This implements support for mounting and unmounting volumes backed by volume plugins. Support for actually retrieving plugins requires a pull request to land in containers.conf and then that to be vendored, and as such is not yet ready. Given this, this code is only compile tested. However, the code for everything past retrieving the plugin has been written - there is support for creating, removing, mounting, and unmounting volumes, which should allow full functionality once the c/common PR is merged. A major change is the signature of the MountPoint function for volumes, which now, by necessity, returns an error. Named volumes managed by a plugin do not have a mountpoint we control; instead, it is managed entirely by the plugin. As such, we need to cache the path in the DB, and calls to retrieve it now need to access the DB (and may fail as such). Notably absent is support for SELinux relabelling and chowning these volumes. Given that we don't manage the mountpoint for these volumes, I am extremely reluctant to try and modify it - we could easily break the plugin trying to chown or relabel it. Also, we had no less than *5* separate implementations of inspecting a volume floating around in pkg/infra/abi and pkg/api/handlers/libpod. And none of them used volume.Inspect(), the only correct way of inspecting volumes. Remove them all and consolidate to using the correct way. Compat API is likely still doing things the wrong way, but that is an issue for another day. Fixes #4304 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
68 lines
2.6 KiB
Bash
68 lines
2.6 KiB
Bash
# -*- sh -*-
|
|
#
|
|
# system related tests
|
|
#
|
|
|
|
## ensure system is clean
|
|
t POST 'libpod/system/prune?volumes=true&all=true' params='' 200
|
|
|
|
## podman system df
|
|
t GET system/df 200 '{"LayersSize":0,"Images":[],"Containers":[],"Volumes":[],"BuildCache":[],"BuilderSize":0}'
|
|
t GET libpod/system/df 200 '{"Images":[],"Containers":[],"Volumes":[]}'
|
|
|
|
# Create volume. We expect df to report this volume next invocation of system/df
|
|
t GET libpod/info 200
|
|
volumepath=$(jq -r ".store.volumePath" <<<"$output")
|
|
t POST libpod/volumes/create name=foo1 201 \
|
|
.Name=foo1 \
|
|
.Driver=local \
|
|
.Mountpoint=$volumepath/foo1/_data \
|
|
.CreatedAt~[0-9]\\{4\\}-[0-9]\\{2\\}-[0-9]\\{2\\}.* \
|
|
.Labels={} \
|
|
.Options={}
|
|
|
|
t GET system/df 200 '.Volumes[0].Name=foo1'
|
|
|
|
t GET libpod/system/df 200 '.Volumes[0].VolumeName=foo1'
|
|
|
|
# Create two more volumes to test pruneing
|
|
t POST libpod/volumes/create \
|
|
'"Name":"foo2","Label":{"testlabel1":""},"Options":{"type":"tmpfs","o":"nodev,noexec"}}' 201 \
|
|
.Name=foo2 \
|
|
.Driver=local \
|
|
.Mountpoint=$volumepath/foo2/_data \
|
|
.CreatedAt~[0-9]\\{4\\}-[0-9]\\{2\\}-[0-9]\\{2\\}.* \
|
|
.Labels.testlabel1="" \
|
|
.Options.o=nodev,noexec
|
|
|
|
t POST libpod/volumes/create \
|
|
'"Name":"foo3","Label":{"testlabel1":"testonly"},"Options":{"type":"tmpfs","o":"nodev,noexec"}}' 201 \
|
|
.Name=foo3 \
|
|
.Driver=local \
|
|
.Mountpoint=$volumepath/foo3/_data \
|
|
.CreatedAt~[0-9]\\{4\\}-[0-9]\\{2\\}-[0-9]\\{2\\}.* \
|
|
.Labels.testlabel1=testonly \
|
|
.Options.o=nodev,noexec
|
|
|
|
t GET system/df 200 '.Volumes | length=3'
|
|
t GET libpod/system/df 200 '.Volumes | length=3'
|
|
|
|
# Prune volumes
|
|
|
|
# -G --data-urlencode 'volumes=true&filters={"label":["testlabel1=idontmatch"]}'
|
|
t POST 'libpod/system/prune?volumes=true&filters=%7B%22label%22:%5B%22testlabel1=idontmatch%22%5D%7D' params='' 200
|
|
|
|
# nothing should have been pruned
|
|
t GET system/df 200 '.Volumes | length=3'
|
|
t GET libpod/system/df 200 '.Volumes | length=3'
|
|
|
|
# -G --data-urlencode 'volumes=true&filters={"label":["testlabel1=testonly"]}'
|
|
# only foo3 should be pruned because of filter
|
|
t POST 'libpod/system/prune?volumes=true&filters=%7B%22label%22:%5B%22testlabel1=testonly%22%5D%7D' params='' 200 .VolumePruneReports[0].Id=foo3
|
|
# only foo2 should be pruned because of filter
|
|
t POST 'libpod/system/prune?volumes=true&filters=%7B%22label%22:%5B%22testlabel1%22%5D%7D' params='' 200 .VolumePruneReports[0].Id=foo2
|
|
# foo1, the last remaining volume should be pruned without any filters applied
|
|
t POST 'libpod/system/prune?volumes=true' params='' 200 .VolumePruneReports[0].Id=foo1
|
|
|
|
# TODO add other system prune tests for pods / images
|