mirror of
https://github.com/containers/podman.git
synced 2025-05-20 00:27:03 +08:00
43e899c2ec
Move the core of renaming logic into the DB. This guarantees a lot more atomicity than we have right now (our current solution, removing the container from the DB and re-creating it, is *VERY* not atomic and prone to leaving a corrupted state behind if things go wrong. Moving things into the DB allows us to remove most, but not all, of this - there's still a potential scenario where the c/storage rename fails but the Podman rename succeeds, and we end up with a mismatched state. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
114 lines
3.5 KiB
Go
114 lines
3.5 KiB
Go
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
|
|
. "github.com/containers/podman/v3/test/utils"
|
|
. "github.com/onsi/ginkgo"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("podman rename", func() {
|
|
var (
|
|
tempdir string
|
|
err error
|
|
podmanTest *PodmanTestIntegration
|
|
)
|
|
|
|
BeforeEach(func() {
|
|
tempdir, err = CreateTempDirInTempDir()
|
|
if err != nil {
|
|
os.Exit(1)
|
|
}
|
|
podmanTest = PodmanTestCreate(tempdir)
|
|
podmanTest.Setup()
|
|
podmanTest.SeedImages()
|
|
})
|
|
|
|
AfterEach(func() {
|
|
podmanTest.Cleanup()
|
|
f := CurrentGinkgoTestDescription()
|
|
processTestResult(f)
|
|
|
|
})
|
|
|
|
It("podman rename on non-existent container", func() {
|
|
session := podmanTest.Podman([]string{"rename", "doesNotExist", "aNewName"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session.ExitCode()).To(Not(Equal(0)))
|
|
})
|
|
|
|
It("Podman rename on existing container with bad name", func() {
|
|
ctrName := "testCtr"
|
|
ctr := podmanTest.Podman([]string{"create", "--name", ctrName, ALPINE, "top"})
|
|
ctr.WaitWithDefaultTimeout()
|
|
Expect(ctr.ExitCode()).To(Equal(0))
|
|
|
|
newName := "invalid<>:char"
|
|
rename := podmanTest.Podman([]string{"rename", ctrName, newName})
|
|
rename.WaitWithDefaultTimeout()
|
|
Expect(rename.ExitCode()).To(Not(Equal(0)))
|
|
|
|
ps := podmanTest.Podman([]string{"ps", "-aq", "--filter", fmt.Sprintf("name=%s", ctrName), "--format", "{{ .Names }}"})
|
|
ps.WaitWithDefaultTimeout()
|
|
Expect(ps.ExitCode()).To(Equal(0))
|
|
Expect(ps.OutputToString()).To(ContainSubstring(ctrName))
|
|
})
|
|
|
|
It("Successfully rename a created container", func() {
|
|
ctrName := "testCtr"
|
|
ctr := podmanTest.Podman([]string{"create", "--name", ctrName, ALPINE, "top"})
|
|
ctr.WaitWithDefaultTimeout()
|
|
Expect(ctr.ExitCode()).To(Equal(0))
|
|
|
|
newName := "aNewName"
|
|
rename := podmanTest.Podman([]string{"rename", ctrName, newName})
|
|
rename.WaitWithDefaultTimeout()
|
|
Expect(rename.ExitCode()).To(Equal(0))
|
|
|
|
ps := podmanTest.Podman([]string{"ps", "-aq", "--filter", fmt.Sprintf("name=%s", newName), "--format", "{{ .Names }}"})
|
|
ps.WaitWithDefaultTimeout()
|
|
Expect(ps.ExitCode()).To(Equal(0))
|
|
Expect(ps.OutputToString()).To(ContainSubstring(newName))
|
|
})
|
|
|
|
It("Successfully rename a running container", func() {
|
|
ctrName := "testCtr"
|
|
ctr := podmanTest.Podman([]string{"run", "-d", "--name", ctrName, ALPINE, "top"})
|
|
ctr.WaitWithDefaultTimeout()
|
|
Expect(ctr.ExitCode()).To(Equal(0))
|
|
|
|
newName := "aNewName"
|
|
rename := podmanTest.Podman([]string{"rename", ctrName, newName})
|
|
rename.WaitWithDefaultTimeout()
|
|
Expect(rename.ExitCode()).To(Equal(0))
|
|
|
|
ps := podmanTest.Podman([]string{"ps", "-aq", "--filter", fmt.Sprintf("name=%s", newName), "--format", "{{ .Names }}"})
|
|
ps.WaitWithDefaultTimeout()
|
|
Expect(ps.ExitCode()).To(Equal(0))
|
|
Expect(ps.OutputToString()).To(ContainSubstring(newName))
|
|
})
|
|
|
|
It("Rename a running container with exec sessions", func() {
|
|
ctrName := "testCtr"
|
|
ctr := podmanTest.Podman([]string{"run", "-d", "--name", ctrName, ALPINE, "top"})
|
|
ctr.WaitWithDefaultTimeout()
|
|
Expect(ctr.ExitCode()).To(Equal(0))
|
|
|
|
exec := podmanTest.Podman([]string{"exec", "-d", ctrName, "top"})
|
|
exec.WaitWithDefaultTimeout()
|
|
Expect(exec.ExitCode()).To(Equal(0))
|
|
|
|
newName := "aNewName"
|
|
rename := podmanTest.Podman([]string{"rename", ctrName, newName})
|
|
rename.WaitWithDefaultTimeout()
|
|
Expect(rename.ExitCode()).To(Equal(0))
|
|
|
|
ps := podmanTest.Podman([]string{"ps", "-aq", "--filter", fmt.Sprintf("name=%s", newName), "--format", "{{ .Names }}"})
|
|
ps.WaitWithDefaultTimeout()
|
|
Expect(ps.ExitCode()).To(Equal(0))
|
|
Expect(ps.OutputToString()).To(ContainSubstring(newName))
|
|
})
|
|
})
|