mirror of
https://github.com/containers/podman.git
synced 2025-05-21 00:56:36 +08:00

* Implement `podman-push` and `podman-image-push` for the podmanV2 client. * Tests for `pkg/bindings` are not possible at the time of writing as we don't have a local registry running. * Implement `/images/{name}/push` compat endpoint. Tests are not implemented for this v2 endpoint. It has been tested manually. General note: The auth config extraction from the http header is not implement for push. Since it's not yet supported for other endpoints either, I deferred it to future work. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
128 lines
5.0 KiB
Go
128 lines
5.0 KiB
Go
package images
|
|
|
|
import (
|
|
buildahcli "github.com/containers/buildah/pkg/cli"
|
|
"github.com/containers/image/v5/types"
|
|
"github.com/containers/libpod/cmd/podmanV2/registry"
|
|
"github.com/containers/libpod/pkg/domain/entities"
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/cobra"
|
|
"github.com/spf13/pflag"
|
|
)
|
|
|
|
// pushOptionsWrapper wraps entities.ImagepushOptions and prevents leaking
|
|
// CLI-only fields into the API types.
|
|
type pushOptionsWrapper struct {
|
|
entities.ImagePushOptions
|
|
TLSVerifyCLI bool // CLI only
|
|
}
|
|
|
|
var (
|
|
pushOptions = pushOptionsWrapper{}
|
|
pushDescription = `Pushes a source image to a specified destination.
|
|
|
|
The Image "DESTINATION" uses a "transport":"details" format. See podman-push(1) section "DESTINATION" for the expected format.`
|
|
|
|
// Command: podman push
|
|
pushCmd = &cobra.Command{
|
|
Use: "push [flags] SOURCE DESTINATION",
|
|
Short: "Push an image to a specified destination",
|
|
Long: pushDescription,
|
|
PreRunE: preRunE,
|
|
RunE: imagePush,
|
|
Example: `podman push imageID docker://registry.example.com/repository:tag
|
|
podman push imageID oci-archive:/path/to/layout:image:tag`,
|
|
}
|
|
|
|
// Command: podman image push
|
|
// It's basically a clone of `pushCmd` with the exception of being a
|
|
// child of the images command.
|
|
imagePushCmd = &cobra.Command{
|
|
Use: pushCmd.Use,
|
|
Short: pushCmd.Short,
|
|
Long: pushCmd.Long,
|
|
PreRunE: pushCmd.PreRunE,
|
|
RunE: pushCmd.RunE,
|
|
Example: `podman image push imageID docker://registry.example.com/repository:tag
|
|
podman image push imageID oci-archive:/path/to/layout:image:tag`,
|
|
}
|
|
)
|
|
|
|
func init() {
|
|
// push
|
|
registry.Commands = append(registry.Commands, registry.CliCommand{
|
|
Mode: []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
|
|
Command: pushCmd,
|
|
})
|
|
|
|
pushCmd.SetHelpTemplate(registry.HelpTemplate())
|
|
pushCmd.SetUsageTemplate(registry.UsageTemplate())
|
|
|
|
flags := pushCmd.Flags()
|
|
pushFlags(flags)
|
|
|
|
// images push
|
|
registry.Commands = append(registry.Commands, registry.CliCommand{
|
|
Mode: []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
|
|
Command: imagePushCmd,
|
|
Parent: imageCmd,
|
|
})
|
|
|
|
imagePushCmd.SetHelpTemplate(registry.HelpTemplate())
|
|
imagePushCmd.SetUsageTemplate(registry.UsageTemplate())
|
|
pushFlags(imagePushCmd.Flags())
|
|
}
|
|
|
|
// pushFlags set the flags for the push command.
|
|
func pushFlags(flags *pflag.FlagSet) {
|
|
flags.StringVar(&pushOptions.Authfile, "authfile", buildahcli.GetDefaultAuthFile(), "Path of the authentication file. Use REGISTRY_AUTH_FILE environment variable to override")
|
|
flags.StringVar(&pushOptions.CertDir, "cert-dir", "", "Path to a directory containing TLS certificates and keys")
|
|
flags.BoolVar(&pushOptions.Compress, "compress", false, "Compress tarball image layers when pushing to a directory using the 'dir' transport. (default is same compression type as source)")
|
|
flags.StringVar(&pushOptions.Credentials, "creds", "", "`Credentials` (USERNAME:PASSWORD) to use for authenticating to a registry")
|
|
flags.StringVar(&pushOptions.DigestFile, "digestfile", "", "Write the digest of the pushed image to the specified file")
|
|
flags.StringVarP(&pushOptions.Format, "format", "f", "", "Manifest type (oci, v2s1, or v2s2) to use when pushing an image using the 'dir' transport (default is manifest type of source)")
|
|
flags.BoolVarP(&pushOptions.Quiet, "quiet", "q", false, "Suppress output information when pushing images")
|
|
flags.BoolVar(&pushOptions.RemoveSignatures, "remove-signatures", false, "Discard any pre-existing signatures in the image")
|
|
flags.StringVar(&pushOptions.SignaturePolicy, "signature-policy", "", "Path to a signature-policy file")
|
|
flags.StringVar(&pushOptions.SignBy, "sign-by", "", "Add a signature at the destination using the specified key")
|
|
flags.BoolVar(&pushOptions.TLSVerifyCLI, "tls-verify", true, "Require HTTPS and verify certificates when contacting registries")
|
|
|
|
if registry.IsRemote() {
|
|
_ = flags.MarkHidden("authfile")
|
|
_ = flags.MarkHidden("cert-dir")
|
|
_ = flags.MarkHidden("compress")
|
|
_ = flags.MarkHidden("quiet")
|
|
_ = flags.MarkHidden("signature-policy")
|
|
_ = flags.MarkHidden("tls-verify")
|
|
}
|
|
}
|
|
|
|
// imagePush is implement the command for pushing images.
|
|
func imagePush(cmd *cobra.Command, args []string) error {
|
|
var source, destination string
|
|
switch len(args) {
|
|
case 1:
|
|
source = args[0]
|
|
case 2:
|
|
source = args[0]
|
|
destination = args[1]
|
|
case 0:
|
|
fallthrough
|
|
default:
|
|
return errors.New("push requires at least one image name, or optionally a second to specify a different destination")
|
|
}
|
|
|
|
pushOptsAPI := pushOptions.ImagePushOptions
|
|
// TLS verification in c/image is controlled via a `types.OptionalBool`
|
|
// which allows for distinguishing among set-true, set-false, unspecified
|
|
// which is important to implement a sane way of dealing with defaults of
|
|
// boolean CLI flags.
|
|
if cmd.Flags().Changed("tls-verify") {
|
|
pushOptsAPI.TLSVerify = types.NewOptionalBool(pushOptions.TLSVerifyCLI)
|
|
}
|
|
|
|
// Let's do all the remaining Yoga in the API to prevent us from scattering
|
|
// logic across (too) many parts of the code.
|
|
return registry.ImageEngine().Push(registry.GetContext(), source, destination, pushOptsAPI)
|
|
}
|