Files
podman/pkg/bindings/test/secrets_test.go
Paul Holzinger 2ddf1c5cbd ginkgo tests: apply ginkgolinter fixes
I found the ginkgolinter[1] by accident, this looks for not optimal
matching and suggest how to do it better.

Overall these fixes seem to be all correct and they will give much
better error messages when something fails.
Check out the repo to see what the linter reports.

[1] https://github.com/nunnatsa/ginkgolinter

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-11-25 14:41:43 +01:00

134 lines
3.2 KiB
Go

package bindings_test
import (
"context"
"net/http"
"strings"
"time"
"github.com/containers/podman/v4/pkg/bindings"
"github.com/containers/podman/v4/pkg/bindings/secrets"
. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
"github.com/onsi/gomega/gexec"
)
var _ = Describe("Podman secrets", func() {
var (
bt *bindingTest
s *gexec.Session
connText context.Context
err error
)
BeforeEach(func() {
bt = newBindingTest()
bt.RestoreImagesFromCache()
s = bt.startAPIService()
time.Sleep(1 * time.Second)
connText, err = bindings.NewConnection(context.Background(), bt.sock)
Expect(err).ToNot(HaveOccurred())
})
AfterEach(func() {
s.Kill()
bt.cleanup()
})
It("create secret", func() {
r := strings.NewReader("mysecret")
name := "mysecret"
opts := &secrets.CreateOptions{
Name: &name,
}
_, err := secrets.Create(connText, r, opts)
Expect(err).ToNot(HaveOccurred())
// should not be allowed to create duplicate secret name
_, err = secrets.Create(connText, r, opts)
Expect(err).To(HaveOccurred())
})
It("inspect secret", func() {
r := strings.NewReader("mysecret")
name := "mysecret"
opts := &secrets.CreateOptions{
Name: &name,
}
_, err := secrets.Create(connText, r, opts)
Expect(err).ToNot(HaveOccurred())
data, err := secrets.Inspect(connText, name, nil)
Expect(err).ToNot(HaveOccurred())
Expect(data.Spec.Name).To(Equal(name))
// inspecting non-existent secret should fail
_, err = secrets.Inspect(connText, "notasecret", nil)
code, _ := bindings.CheckResponseCode(err)
Expect(code).To(BeNumerically("==", http.StatusNotFound))
})
It("list secret", func() {
r := strings.NewReader("mysecret")
name := "mysecret"
opts := &secrets.CreateOptions{
Name: &name,
}
_, err := secrets.Create(connText, r, opts)
Expect(err).ToNot(HaveOccurred())
data, err := secrets.List(connText, nil)
Expect(err).ToNot(HaveOccurred())
Expect(data[0].Spec.Name).To(Equal(name))
})
It("list multiple secret", func() {
r := strings.NewReader("mysecret")
name := "mysecret"
opts := &secrets.CreateOptions{
Name: &name,
}
_, err := secrets.Create(connText, r, opts)
Expect(err).ToNot(HaveOccurred())
r2 := strings.NewReader("mysecret2")
name2 := "mysecret2"
opts2 := &secrets.CreateOptions{
Name: &name2,
}
_, err = secrets.Create(connText, r2, opts2)
Expect(err).ToNot(HaveOccurred())
data, err := secrets.List(connText, nil)
Expect(err).ToNot(HaveOccurred())
Expect(data).To(HaveLen(2))
})
It("list no secrets", func() {
data, err := secrets.List(connText, nil)
Expect(err).ToNot(HaveOccurred())
Expect(data).To(BeEmpty())
})
It("remove secret", func() {
r := strings.NewReader("mysecret")
name := "mysecret"
opts := &secrets.CreateOptions{
Name: &name,
}
_, err := secrets.Create(connText, r, opts)
Expect(err).ToNot(HaveOccurred())
err = secrets.Remove(connText, name)
Expect(err).ToNot(HaveOccurred())
// removing non-existent secret should fail
err = secrets.Remove(connText, "nosecret")
Expect(err).To(HaveOccurred())
code, _ := bindings.CheckResponseCode(err)
Expect(code).To(BeNumerically("==", http.StatusNotFound))
})
})