mirror of
https://github.com/containers/podman.git
synced 2025-09-09 21:52:21 +08:00
547fff2703
e2e test failures are rife with messages like:
Expected 1 to equal 0
These make me cry. They're anti-helpful, requiring the reader
to dive into the source code to figure out what those numbers
mean.
Solution: Go tests have a '.Should(Exit(NNN))' mechanism. I
don't know if it spits out a better diagnostic (I have no way
to run e2e tests on my laptop), but I have to fantasize that
it will, and given the state of our flakes I assume that at
least one test will fail and give me the opportunity to see
what the error message looks like.
THIS IS NOT REVIEWABLE CODE. There is no way for a human
to review it. Don't bother. Maybe look at a few random
ones for sanity. If you want to really review, here is
a reproducer of what I did:
cd test/e2e
! positive assertions. The second is the same as the first,
! with the addition of (unnecessary) parentheses because
! some invocations were written that way. The third is BeZero().
perl -pi -e 's/Expect\((\S+)\.ExitCode\(\)\)\.To\(Equal\((\d+)\)\)/Expect($1).Should(Exit($2))/' *_test.go
perl -pi -e 's/Expect\((\S+)\.ExitCode\(\)\)\.To\(\(Equal\((\d+)\)\)\)/Expect($1).Should(Exit($2))/' *_test.go
perl -pi -e 's/Expect\((\S+)\.ExitCode\(\)\)\.To\(BeZero\(\)\)/Expect($1).Should(Exit(0))/' *_test.go
! Same as above, but handles three non-numeric exit codes
! in run_exit_test.go
perl -pi -e 's/Expect\((\S+)\.ExitCode\(\)\)\.To\(Equal\((\S+)\)\)/Expect($1).Should(Exit($2))/' *_test.go
! negative assertions. Difference is the spelling of 'To(Not)',
! 'ToNot', and 'NotTo'. I assume those are all the same.
perl -pi -e 's/Expect\((\S+)\.ExitCode\(\)\)\.To\(Not\(Equal\((0)\)\)\)/Expect($1).To(ExitWithError())/' *_test.go
perl -pi -e 's/Expect\((\S+)\.ExitCode\(\)\)\.ToNot\(Equal\((0)\)\)/Expect($1).To(ExitWithError())/' *_test.go
perl -pi -e 's/Expect\((\S+)\.ExitCode\(\)\)\.NotTo\(Equal\((0)\)\)/Expect($1).To(ExitWithError())/' *_test.go
! negative, old use of BeZero()
perl -pi -e 's/Expect\((\S+)\.ExitCode\(\)\)\.ToNot\(BeZero\(\)\)/Expect($1).Should(ExitWithError())/' *_test.go
Run those on a clean copy of main branch (at the same branch
point as my PR, of course), then diff against a checked-out
copy of my PR. There should be no differences. Then all you
have to review is that my replacements above are sane.
UPDATE: nope, that's not enough, you also need to add gomega/gexec
to the files that don't have it:
perl -pi -e '$_ .= "$1/gexec\"\n" if m!^(.*/onsi/gomega)"!' $(grep -L gomega/gexec $(git log -1 --stat | awk '$1 ~ /test\/e2e\// { print $1}'))
UPDATE 2: hand-edit run_volume_test.go
UPDATE 3: sigh, add WaitWithDefaultTimeout() to a couple of places
UPDATE 4: skip a test due to bug #10935 (race condition)
Signed-off-by: Ed Santiago <santiago@redhat.com>
267 lines
8.6 KiB
Go
267 lines
8.6 KiB
Go
package integration
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/containers/podman/v3/pkg/rootless"
|
|
. "github.com/containers/podman/v3/test/utils"
|
|
. "github.com/onsi/ginkgo"
|
|
. "github.com/onsi/gomega"
|
|
. "github.com/onsi/gomega/gexec"
|
|
)
|
|
|
|
var _ = Describe("Podman save", func() {
|
|
var (
|
|
tempdir string
|
|
err error
|
|
podmanTest *PodmanTestIntegration
|
|
)
|
|
|
|
BeforeEach(func() {
|
|
tempdir, err = CreateTempDirInTempDir()
|
|
if err != nil {
|
|
os.Exit(1)
|
|
}
|
|
podmanTest = PodmanTestCreate(tempdir)
|
|
podmanTest.Setup()
|
|
})
|
|
|
|
AfterEach(func() {
|
|
podmanTest.Cleanup()
|
|
f := CurrentGinkgoTestDescription()
|
|
processTestResult(f)
|
|
|
|
})
|
|
|
|
It("podman save output flag", func() {
|
|
outfile := filepath.Join(podmanTest.TempDir, "alpine.tar")
|
|
|
|
save := podmanTest.Podman([]string{"save", "-o", outfile, ALPINE})
|
|
save.WaitWithDefaultTimeout()
|
|
Expect(save).Should(Exit(0))
|
|
})
|
|
|
|
It("podman save oci flag", func() {
|
|
outfile := filepath.Join(podmanTest.TempDir, "alpine.tar")
|
|
|
|
save := podmanTest.Podman([]string{"save", "-o", outfile, "--format", "oci-archive", ALPINE})
|
|
save.WaitWithDefaultTimeout()
|
|
Expect(save).Should(Exit(0))
|
|
})
|
|
|
|
It("podman save with stdout", func() {
|
|
Skip("Pipe redirection in ginkgo probably won't work")
|
|
outfile := filepath.Join(podmanTest.TempDir, "alpine.tar")
|
|
|
|
save := podmanTest.Podman([]string{"save", ALPINE, ">", outfile})
|
|
save.WaitWithDefaultTimeout()
|
|
Expect(save).Should(Exit(0))
|
|
})
|
|
|
|
It("podman save quiet flag", func() {
|
|
outfile := filepath.Join(podmanTest.TempDir, "alpine.tar")
|
|
|
|
save := podmanTest.Podman([]string{"save", "-q", "-o", outfile, ALPINE})
|
|
save.WaitWithDefaultTimeout()
|
|
Expect(save).Should(Exit(0))
|
|
})
|
|
|
|
It("podman save bogus image", func() {
|
|
outfile := filepath.Join(podmanTest.TempDir, "alpine.tar")
|
|
|
|
save := podmanTest.Podman([]string{"save", "-o", outfile, "FOOBAR"})
|
|
save.WaitWithDefaultTimeout()
|
|
Expect(save).To(ExitWithError())
|
|
})
|
|
|
|
It("podman save to directory with oci format", func() {
|
|
if rootless.IsRootless() {
|
|
Skip("Requires a fix in containers image for chown/lchown")
|
|
}
|
|
outdir := filepath.Join(podmanTest.TempDir, "save")
|
|
|
|
save := podmanTest.Podman([]string{"save", "--format", "oci-dir", "-o", outdir, ALPINE})
|
|
save.WaitWithDefaultTimeout()
|
|
Expect(save).Should(Exit(0))
|
|
})
|
|
|
|
It("podman save to directory with v2s2 docker format", func() {
|
|
if rootless.IsRootless() {
|
|
Skip("Requires a fix in containers image for chown/lchown")
|
|
}
|
|
outdir := filepath.Join(podmanTest.TempDir, "save")
|
|
|
|
save := podmanTest.Podman([]string{"save", "--format", "docker-dir", "-o", outdir, ALPINE})
|
|
save.WaitWithDefaultTimeout()
|
|
Expect(save).Should(Exit(0))
|
|
})
|
|
|
|
It("podman save to directory with docker format and compression", func() {
|
|
if rootless.IsRootless() && podmanTest.RemoteTest {
|
|
Skip("Requires a fix in containers image for chown/lchown")
|
|
}
|
|
outdir := filepath.Join(podmanTest.TempDir, "save")
|
|
|
|
save := podmanTest.Podman([]string{"save", "--compress", "--format", "docker-dir", "-o", outdir, ALPINE})
|
|
save.WaitWithDefaultTimeout()
|
|
Expect(save).Should(Exit(0))
|
|
})
|
|
|
|
It("podman save to directory with --compress but not use docker-dir and oci-dir", func() {
|
|
if rootless.IsRootless() && podmanTest.RemoteTest {
|
|
Skip("Requires a fix in containers image for chown/lchown")
|
|
}
|
|
outdir := filepath.Join(podmanTest.TempDir, "save")
|
|
|
|
save := podmanTest.Podman([]string{"save", "--compress", "--format", "docker-archive", "-o", outdir, ALPINE})
|
|
save.WaitWithDefaultTimeout()
|
|
// should not be 0
|
|
Expect(save).To(ExitWithError())
|
|
|
|
save = podmanTest.Podman([]string{"save", "--compress", "--format", "oci-archive", "-o", outdir, ALPINE})
|
|
save.WaitWithDefaultTimeout()
|
|
// should not be 0
|
|
Expect(save).To(ExitWithError())
|
|
|
|
})
|
|
|
|
It("podman save bad filename", func() {
|
|
outdir := filepath.Join(podmanTest.TempDir, "save:colon")
|
|
|
|
save := podmanTest.Podman([]string{"save", "--compress", "--format", "docker-dir", "-o", outdir, ALPINE})
|
|
save.WaitWithDefaultTimeout()
|
|
Expect(save).To(ExitWithError())
|
|
})
|
|
|
|
It("podman save remove signature", func() {
|
|
podmanTest.AddImageToRWStore(ALPINE)
|
|
SkipIfRootless("FIXME: Need get in rootless push sign")
|
|
if podmanTest.Host.Arch == "ppc64le" {
|
|
Skip("No registry image for ppc64le")
|
|
}
|
|
tempGNUPGHOME := filepath.Join(podmanTest.TempDir, "tmpGPG")
|
|
err := os.Mkdir(tempGNUPGHOME, os.ModePerm)
|
|
Expect(err).To(BeNil())
|
|
origGNUPGHOME := os.Getenv("GNUPGHOME")
|
|
err = os.Setenv("GNUPGHOME", tempGNUPGHOME)
|
|
Expect(err).To(BeNil())
|
|
defer os.Setenv("GNUPGHOME", origGNUPGHOME)
|
|
|
|
port := 5000
|
|
session := podmanTest.Podman([]string{"run", "-d", "--name", "registry", "-p", strings.Join([]string{strconv.Itoa(port), strconv.Itoa(port)}, ":"), "quay.io/libpod/registry:2.6"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
if !WaitContainerReady(podmanTest, "registry", "listening on", 20, 1) {
|
|
Skip("Cannot start docker registry.")
|
|
}
|
|
|
|
cmd := exec.Command("gpg", "--import", "sign/secret-key.asc")
|
|
err = cmd.Run()
|
|
Expect(err).To(BeNil())
|
|
|
|
cmd = exec.Command("cp", "/etc/containers/registries.d/default.yaml", "default.yaml")
|
|
if err = cmd.Run(); err != nil {
|
|
Skip("no signature store to verify")
|
|
}
|
|
defer func() {
|
|
cmd = exec.Command("cp", "default.yaml", "/etc/containers/registries.d/default.yaml")
|
|
cmd.Run()
|
|
}()
|
|
|
|
cmd = exec.Command("cp", "sign/key.gpg", "/tmp/key.gpg")
|
|
Expect(cmd.Run()).To(BeNil())
|
|
sigstore := `
|
|
default-docker:
|
|
sigstore: file:///var/lib/containers/sigstore
|
|
sigstore-staging: file:///var/lib/containers/sigstore
|
|
`
|
|
Expect(ioutil.WriteFile("/etc/containers/registries.d/default.yaml", []byte(sigstore), 0755)).To(BeNil())
|
|
|
|
session = podmanTest.Podman([]string{"tag", ALPINE, "localhost:5000/alpine"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
session = podmanTest.Podman([]string{"push", "--tls-verify=false", "--sign-by", "foo@bar.com", "localhost:5000/alpine"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
session = podmanTest.Podman([]string{"rmi", ALPINE, "localhost:5000/alpine"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
session = podmanTest.Podman([]string{"pull", "--tls-verify=false", "--signature-policy=sign/policy.json", "localhost:5000/alpine"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
outfile := filepath.Join(podmanTest.TempDir, "temp.tar")
|
|
save := podmanTest.Podman([]string{"save", "remove-signatures=true", "-o", outfile, "localhost:5000/alpine"})
|
|
save.WaitWithDefaultTimeout()
|
|
Expect(save).To(ExitWithError())
|
|
})
|
|
|
|
It("podman save image with digest reference", func() {
|
|
// pull a digest reference
|
|
session := podmanTest.Podman([]string{"pull", ALPINELISTDIGEST})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
// save a digest reference should exit without error.
|
|
outfile := filepath.Join(podmanTest.TempDir, "temp.tar")
|
|
save := podmanTest.Podman([]string{"save", "-o", outfile, ALPINELISTDIGEST})
|
|
save.WaitWithDefaultTimeout()
|
|
Expect(save).Should(Exit(0))
|
|
})
|
|
|
|
It("podman save --multi-image-archive (tagged images)", func() {
|
|
multiImageSave(podmanTest, RESTORE_IMAGES)
|
|
})
|
|
|
|
It("podman save --multi-image-archive (untagged images)", func() {
|
|
// Refer to images via ID instead of tag.
|
|
session := podmanTest.Podman([]string{"images", "--format", "{{.ID}}"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
ids := session.OutputToStringArray()
|
|
|
|
Expect(len(RESTORE_IMAGES), len(ids))
|
|
multiImageSave(podmanTest, ids)
|
|
})
|
|
})
|
|
|
|
// Create a multi-image archive, remove all images, load it and
|
|
// make sure that all images are (again) present.
|
|
func multiImageSave(podmanTest *PodmanTestIntegration, images []string) {
|
|
// Create the archive.
|
|
outfile := filepath.Join(podmanTest.TempDir, "temp.tar")
|
|
session := podmanTest.Podman(append([]string{"save", "-o", outfile, "--multi-image-archive"}, images...))
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
// Remove all images.
|
|
session = podmanTest.Podman([]string{"rmi", "-af"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
|
|
// Now load the archive.
|
|
session = podmanTest.Podman([]string{"load", "-i", outfile})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
// Grep for each image in the `podman load` output.
|
|
for _, image := range images {
|
|
found, _ := session.GrepString(image)
|
|
Expect(found).Should(BeTrue())
|
|
}
|
|
|
|
// Make sure that each image has really been loaded.
|
|
for _, image := range images {
|
|
session = podmanTest.Podman([]string{"image", "exists", image})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(Exit(0))
|
|
}
|
|
}
|