mirror of
https://github.com/containers/podman.git
synced 2025-12-17 05:01:09 +08:00
d18e44e9ab
The code checks for isPathOnVolume and isPathOnMount so we can just use the SecureJoin here directly to check for path existance. Then instead of walking symlinks and trying to guess if they are on a mount just assume if it is a link (path is different from the normal joined one) then don't error out early and let the OCI runtime deal with it. The runtime does produce a less readable error but it still fails and we have much less fragile code. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
92 lines
3.3 KiB
Go
92 lines
3.3 KiB
Go
//go:build linux || freebsd
|
|
|
|
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
|
|
. "github.com/containers/podman/v6/test/utils"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
"github.com/onsi/gomega/types"
|
|
)
|
|
|
|
var _ = Describe("Podman run", func() {
|
|
It("podman run a container without workdir", func() {
|
|
session := podmanTest.Podman([]string{"run", ALPINE, "pwd"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(ExitCleanly())
|
|
Expect(session.OutputToString()).To(Equal("/"))
|
|
})
|
|
|
|
It("podman run a container using non existing --workdir", func() {
|
|
session := podmanTest.Podman([]string{"run", "--workdir", "/home/foobar", ALPINE, "pwd"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(ExitWithError(126, `workdir "/home/foobar" does not exist on container `))
|
|
})
|
|
|
|
It("podman run a container using a --workdir under a bind mount", func() {
|
|
volume := filepath.Join(podmanTest.TempDir, "vol")
|
|
err = os.MkdirAll(volume, os.ModePerm)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
session := podmanTest.Podman([]string{"run", "--volume", fmt.Sprintf("%s:/var_ovl/:O", volume), "--workdir", "/var_ovl/log", ALPINE, "true"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(ExitCleanly())
|
|
})
|
|
|
|
It("podman run a container on an image with a workdir", func() {
|
|
dockerfile := fmt.Sprintf(`FROM %s
|
|
RUN mkdir -p /home/foobar /etc/foobar; chown bin:bin /etc/foobar
|
|
WORKDIR /etc/foobar`, ALPINE)
|
|
podmanTest.BuildImage(dockerfile, "test", "false")
|
|
|
|
session := podmanTest.Podman([]string{"run", "test", "pwd"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(ExitCleanly())
|
|
Expect(session.OutputToString()).To(Equal("/etc/foobar"))
|
|
|
|
session = podmanTest.Podman([]string{"run", "test", "ls", "-ld", "."})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session.OutputToString()).To(ContainSubstring("bin"))
|
|
|
|
session = podmanTest.Podman([]string{"run", "--workdir", "/home/foobar", "test", "pwd"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(ExitCleanly())
|
|
Expect(session.OutputToString()).To(Equal("/home/foobar"))
|
|
})
|
|
|
|
It("podman run on an image with a symlinked workdir", func() {
|
|
dockerfile := fmt.Sprintf(`FROM %s
|
|
RUN mkdir /A && ln -s /A /B && ln -s /vol/test /link
|
|
WORKDIR /B`, ALPINE)
|
|
podmanTest.BuildImage(dockerfile, "test", "false")
|
|
|
|
session := podmanTest.PodmanExitCleanly("run", "test", "pwd")
|
|
Expect(session.OutputToString()).To(Equal("/A"))
|
|
|
|
path := filepath.Join(podmanTest.TempDir, "test")
|
|
err := os.Mkdir(path, 0o755)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
session = podmanTest.PodmanExitCleanly("run", "--workdir=/link", "--volume", podmanTest.TempDir+":/vol", "test", "pwd")
|
|
Expect(session.OutputToString()).To(Equal("/vol/test"))
|
|
|
|
// This will fail in the runtime since the target doesn't exists
|
|
session = podmanTest.Podman([]string{"run", "--workdir=/link", "test", "pwd"})
|
|
session.WaitWithDefaultTimeout()
|
|
var matcher types.GomegaMatcher
|
|
if filepath.Base(podmanTest.OCIRuntime) == "crun" {
|
|
matcher = ExitWithError(127, "chdir to `/link`: No such file or directory")
|
|
} else if filepath.Base(podmanTest.OCIRuntime) == "runc" {
|
|
matcher = ExitWithError(126, "mkdir /link: file exists")
|
|
} else {
|
|
// unknown runtime, just check it failed
|
|
matcher = Not(ExitCleanly())
|
|
}
|
|
Expect(session).Should(matcher)
|
|
})
|
|
})
|