mirror of
https://github.com/containers/podman.git
synced 2025-07-15 03:02:52 +08:00
0f7d54b026
Migrate the Podman code base over to `common/libimage` which replaces `libpod/image` and a lot of glue code entirely. Note that I tried to leave bread crumbs for changed tests. Miscellaneous changes: * Some errors yield different messages which required to alter some tests. * I fixed some pre-existing issues in the code. Others were marked as `//TODO`s to prevent the PR from exploding. * The `NamesHistory` of an image is returned as is from the storage. Previously, we did some filtering which I think is undesirable. Instead we should return the data as stored in the storage. * Touched handlers use the ABI interfaces where possible. * Local image resolution: previously Podman would match "foo" on "myfoo". This behaviour has been changed and Podman will now only match on repository boundaries such that "foo" would match "my/foo" but not "myfoo". I consider the old behaviour to be a bug, at the very least an exotic corner case. * Futhermore, "foo:none" does *not* resolve to a local image "foo" without tag anymore. It's a hill I am (almost) willing to die on. * `image prune` prints the IDs of pruned images. Previously, in some cases, the names were printed instead. The API clearly states ID, so we should stick to it. * Compat endpoint image removal with _force_ deletes the entire not only the specified tag. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
65 lines
1.9 KiB
Go
65 lines
1.9 KiB
Go
package compat
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"github.com/containers/podman/v3/libpod"
|
|
"github.com/containers/podman/v3/pkg/api/handlers/utils"
|
|
"github.com/containers/podman/v3/pkg/domain/entities"
|
|
"github.com/containers/podman/v3/pkg/domain/infra/abi"
|
|
"github.com/containers/storage"
|
|
"github.com/gorilla/schema"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
func RemoveImage(w http.ResponseWriter, r *http.Request) {
|
|
decoder := r.Context().Value("decoder").(*schema.Decoder)
|
|
runtime := r.Context().Value("runtime").(*libpod.Runtime)
|
|
|
|
query := struct {
|
|
Force bool `schema:"force"`
|
|
NoPrune bool `schema:"noprune"`
|
|
}{
|
|
// This is where you can override the golang default value for one of fields
|
|
}
|
|
|
|
if err := decoder.Decode(&query, r.URL.Query()); err != nil {
|
|
utils.Error(w, "Something went wrong.", http.StatusBadRequest, errors.Wrapf(err, "failed to parse parameters for %s", r.URL.String()))
|
|
return
|
|
}
|
|
if _, found := r.URL.Query()["noprune"]; found {
|
|
if query.NoPrune {
|
|
utils.UnSupportedParameter("noprune")
|
|
}
|
|
}
|
|
name := utils.GetName(r)
|
|
imageEngine := abi.ImageEngine{Libpod: runtime}
|
|
|
|
options := entities.ImageRemoveOptions{
|
|
Force: query.Force,
|
|
}
|
|
report, rmerrors := imageEngine.Remove(r.Context(), []string{name}, options)
|
|
if len(rmerrors) > 0 && rmerrors[0] != nil {
|
|
err := rmerrors[0]
|
|
if errors.Cause(err) == storage.ErrImageUnknown {
|
|
utils.ImageNotFound(w, name, errors.Wrapf(err, "failed to find image %s", name))
|
|
return
|
|
}
|
|
|
|
utils.Error(w, "Something went wrong.", http.StatusInternalServerError, err)
|
|
return
|
|
}
|
|
response := make([]map[string]string, 0, len(report.Untagged)+1)
|
|
for _, d := range report.Deleted {
|
|
deleted := make(map[string]string, 1)
|
|
deleted["Deleted"] = d
|
|
response = append(response, deleted)
|
|
}
|
|
for _, u := range report.Untagged {
|
|
untagged := make(map[string]string, 1)
|
|
untagged["Untagged"] = u
|
|
response = append(response, untagged)
|
|
}
|
|
utils.WriteResponse(w, http.StatusOK, response)
|
|
}
|