mirror of
https://github.com/containers/podman.git
synced 2025-07-15 03:02:52 +08:00
8f6a0243f4
First, make podman diff accept optionally a second argument. This allows the user to specify a second image/container to compare the first with. If it is not set the parent layer will be used as before. Second, podman container diff should only use containers and podman image diff should only use images. Previously, podman container diff would use the image when both an image and container with this name exists. To make this work two new parameters have been added to the api. If they are not used the previous behaviour is used. The same applies to the bindings. Fixes #10649 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
46 lines
1.2 KiB
Go
46 lines
1.2 KiB
Go
package compat
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"github.com/containers/podman/v3/libpod"
|
|
"github.com/containers/podman/v3/libpod/define"
|
|
"github.com/containers/podman/v3/pkg/api/handlers/utils"
|
|
"github.com/gorilla/schema"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
func Changes(w http.ResponseWriter, r *http.Request) {
|
|
decoder := r.Context().Value("decoder").(*schema.Decoder)
|
|
runtime := r.Context().Value("runtime").(*libpod.Runtime)
|
|
|
|
query := struct {
|
|
Parent string `schema:"parent"`
|
|
DiffType string `schema:"diffType"`
|
|
}{}
|
|
if err := decoder.Decode(&query, r.URL.Query()); err != nil {
|
|
utils.Error(w, "Something went wrong.", http.StatusBadRequest, errors.Wrapf(err, "failed to parse parameters for %s", r.URL.String()))
|
|
return
|
|
}
|
|
var diffType define.DiffType
|
|
switch query.DiffType {
|
|
case "", "all":
|
|
diffType = define.DiffAll
|
|
case "container":
|
|
diffType = define.DiffContainer
|
|
case "image":
|
|
diffType = define.DiffImage
|
|
default:
|
|
utils.Error(w, "Something went wrong.", http.StatusBadRequest, errors.Errorf("invalid diffType value %q", query.DiffType))
|
|
return
|
|
}
|
|
|
|
id := utils.GetName(r)
|
|
changes, err := runtime.GetDiff(query.Parent, id, diffType)
|
|
if err != nil {
|
|
utils.InternalServerError(w, err)
|
|
return
|
|
}
|
|
utils.WriteJSON(w, 200, changes)
|
|
}
|