mirror of
https://github.com/containers/podman.git
synced 2025-08-06 11:32:07 +08:00

--sdnotify container|conmon|ignore With "conmon", we send the MAINPID, and clear the NOTIFY_SOCKET so the OCI runtime doesn't pass it into the container. We also advertise "ready" when the OCI runtime finishes to advertise the service as ready. With "container", we send the MAINPID, and leave the NOTIFY_SOCKET so the OCI runtime passes it into the container for initialization, and let the container advertise further metadata. This is the default, which is closest to the behavior podman has done in the past. The "ignore" option removes NOTIFY_SOCKET from the environment, so neither podman nor any child processes will talk to systemd. This removes the need for hardcoded CID and PID files in the command line, and the PIDFile directive, as the pid is advertised directly through sd-notify. Signed-off-by: Joseph Gooch <mrwizard@dok.org>
157 lines
5.2 KiB
Go
157 lines
5.2 KiB
Go
package specgen
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"github.com/containers/libpod/v2/libpod/define"
|
|
"github.com/containers/libpod/v2/pkg/rootless"
|
|
"github.com/containers/libpod/v2/pkg/util"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
var (
|
|
// ErrInvalidSpecConfig describes an error that the given SpecGenerator is invalid
|
|
ErrInvalidSpecConfig = errors.New("invalid configuration")
|
|
// SystemDValues describes the only values that SystemD can be
|
|
SystemDValues = []string{"true", "false", "always"}
|
|
// SdNotifyModeValues describes the only values that SdNotifyMode can be
|
|
SdNotifyModeValues = []string{define.SdNotifyModeContainer, define.SdNotifyModeConmon, define.SdNotifyModeIgnore}
|
|
// ImageVolumeModeValues describes the only values that ImageVolumeMode can be
|
|
ImageVolumeModeValues = []string{"ignore", "tmpfs", "anonymous"}
|
|
)
|
|
|
|
func exclusiveOptions(opt1, opt2 string) error {
|
|
return errors.Errorf("%s and %s are mutually exclusive options", opt1, opt2)
|
|
}
|
|
|
|
// Validate verifies that the given SpecGenerator is valid and satisfies required
|
|
// input for creating a container.
|
|
func (s *SpecGenerator) Validate() error {
|
|
|
|
//
|
|
// ContainerBasicConfig
|
|
//
|
|
// Rootfs and Image cannot both populated
|
|
if len(s.ContainerStorageConfig.Image) > 0 && len(s.ContainerStorageConfig.Rootfs) > 0 {
|
|
return errors.Wrap(ErrInvalidSpecConfig, "both image and rootfs cannot be simultaneously")
|
|
}
|
|
// Cannot set hostname and utsns
|
|
if len(s.ContainerBasicConfig.Hostname) > 0 && !s.ContainerBasicConfig.UtsNS.IsPrivate() {
|
|
return errors.Wrap(ErrInvalidSpecConfig, "cannot set hostname when running in the host UTS namespace")
|
|
}
|
|
// systemd values must be true, false, or always
|
|
if len(s.ContainerBasicConfig.Systemd) > 0 && !util.StringInSlice(strings.ToLower(s.ContainerBasicConfig.Systemd), SystemDValues) {
|
|
return errors.Wrapf(ErrInvalidSpecConfig, "--systemd values must be one of %q", strings.Join(SystemDValues, ", "))
|
|
}
|
|
// sdnotify values must be container, conmon, or ignore
|
|
if len(s.ContainerBasicConfig.SdNotifyMode) > 0 && !util.StringInSlice(strings.ToLower(s.ContainerBasicConfig.SdNotifyMode), SdNotifyModeValues) {
|
|
return errors.Wrapf(ErrInvalidSpecConfig, "--sdnotify values must be one of %q", strings.Join(SdNotifyModeValues, ", "))
|
|
}
|
|
|
|
//
|
|
// ContainerStorageConfig
|
|
//
|
|
// rootfs and image cannot both be set
|
|
if len(s.ContainerStorageConfig.Image) > 0 && len(s.ContainerStorageConfig.Rootfs) > 0 {
|
|
return exclusiveOptions("rootfs", "image")
|
|
}
|
|
// imagevolumemode must be one of ignore, tmpfs, or anonymous if given
|
|
if len(s.ContainerStorageConfig.ImageVolumeMode) > 0 && !util.StringInSlice(strings.ToLower(s.ContainerStorageConfig.ImageVolumeMode), ImageVolumeModeValues) {
|
|
return errors.Errorf("invalid ImageVolumeMode %q, value must be one of %s",
|
|
s.ContainerStorageConfig.ImageVolumeMode, strings.Join(ImageVolumeModeValues, ","))
|
|
}
|
|
// shmsize conflicts with IPC namespace
|
|
if s.ContainerStorageConfig.ShmSize != nil && !s.ContainerStorageConfig.IpcNS.IsPrivate() {
|
|
return errors.New("cannot set shmsize when running in the host IPC Namespace")
|
|
}
|
|
|
|
//
|
|
// ContainerSecurityConfig
|
|
//
|
|
// capadd and privileged are exclusive
|
|
if len(s.CapAdd) > 0 && s.Privileged {
|
|
return exclusiveOptions("CapAdd", "privileged")
|
|
}
|
|
// apparmor and privileged are exclusive
|
|
if len(s.ApparmorProfile) > 0 && s.Privileged {
|
|
return exclusiveOptions("AppArmorProfile", "privileged")
|
|
}
|
|
// userns and idmappings conflict
|
|
if s.UserNS.IsPrivate() && s.IDMappings == nil {
|
|
return errors.Wrap(ErrInvalidSpecConfig, "IDMappings are required when not creating a User namespace")
|
|
}
|
|
|
|
//
|
|
// ContainerCgroupConfig
|
|
//
|
|
//
|
|
// None for now
|
|
|
|
//
|
|
// ContainerNetworkConfig
|
|
//
|
|
// useimageresolveconf conflicts with dnsserver, dnssearch, dnsoption
|
|
if s.UseImageResolvConf {
|
|
if len(s.DNSServers) > 0 {
|
|
return exclusiveOptions("UseImageResolvConf", "DNSServer")
|
|
}
|
|
if len(s.DNSSearch) > 0 {
|
|
return exclusiveOptions("UseImageResolvConf", "DNSSearch")
|
|
}
|
|
if len(s.DNSOptions) > 0 {
|
|
return exclusiveOptions("UseImageResolvConf", "DNSOption")
|
|
}
|
|
}
|
|
// UseImageHosts and HostAdd are exclusive
|
|
if s.UseImageHosts && len(s.HostAdd) > 0 {
|
|
return exclusiveOptions("UseImageHosts", "HostAdd")
|
|
}
|
|
|
|
// TODO the specgen does not appear to handle this? Should it
|
|
//switch config.Cgroup.Cgroups {
|
|
//case "disabled":
|
|
// if addedResources {
|
|
// return errors.New("cannot specify resource limits when cgroups are disabled is specified")
|
|
// }
|
|
// configSpec.Linux.Resources = &spec.LinuxResources{}
|
|
//case "enabled", "no-conmon", "":
|
|
// // Do nothing
|
|
//default:
|
|
// return errors.New("unrecognized option for cgroups; supported are 'default', 'disabled', 'no-conmon'")
|
|
//}
|
|
|
|
// Namespaces
|
|
if err := s.UtsNS.validate(); err != nil {
|
|
return err
|
|
}
|
|
if err := s.IpcNS.validate(); err != nil {
|
|
return err
|
|
}
|
|
if err := s.PidNS.validate(); err != nil {
|
|
return err
|
|
}
|
|
if err := s.CgroupNS.validate(); err != nil {
|
|
return err
|
|
}
|
|
if err := validateUserNS(&s.UserNS); err != nil {
|
|
return err
|
|
}
|
|
|
|
// The following are defaults as needed by container creation
|
|
if len(s.WorkDir) < 1 {
|
|
s.WorkDir = "/"
|
|
}
|
|
|
|
// Set defaults if network info is not provided
|
|
if s.NetNS.NSMode == "" {
|
|
s.NetNS.NSMode = Bridge
|
|
if rootless.IsRootless() {
|
|
s.NetNS.NSMode = Slirp
|
|
}
|
|
}
|
|
if err := validateNetNS(&s.NetNS); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|