mirror of
https://github.com/containers/podman.git
synced 2025-08-06 19:44:14 +08:00
4da5c5d3aa
Followup to #22270: wherever possible/practical, extend command error checks to include explicit exit status codes and error strings. Because #22346 is stalled, these are some trivial easy-to-review changes that get us closer to the goal. Signed-off-by: Ed Santiago <santiago@redhat.com>
45 lines
1.4 KiB
Go
45 lines
1.4 KiB
Go
package integration
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
|
|
. "github.com/containers/podman/v5/test/utils"
|
|
"github.com/containers/storage/pkg/homedir"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("podman image scp", func() {
|
|
|
|
BeforeEach(setupConnectionsConf)
|
|
|
|
It("podman image scp bogus image", func() {
|
|
scp := podmanTest.Podman([]string{"image", "scp", "FOOBAR"})
|
|
scp.WaitWithDefaultTimeout()
|
|
Expect(scp).Should(ExitWithError(125, "must specify a destination: invalid argument"))
|
|
})
|
|
|
|
It("podman image scp with proper connection", func() {
|
|
if _, err := os.Stat(filepath.Join(homedir.Get(), ".ssh", "known_hosts")); err != nil {
|
|
Skip("known_hosts does not exist or is not accessible")
|
|
}
|
|
cmd := []string{"system", "connection", "add",
|
|
"--default",
|
|
"QA",
|
|
"ssh://root@podman.test:2222/run/podman/podman.sock",
|
|
}
|
|
session := podmanTest.Podman(cmd)
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(ExitCleanly())
|
|
|
|
scp := podmanTest.Podman([]string{"image", "scp", ALPINE, "QA::"})
|
|
scp.WaitWithDefaultTimeout()
|
|
// exit with error because we cannot make an actual ssh connection
|
|
// This tests that the input we are given is validated and prepared correctly
|
|
// The error given should either be a missing image (due to testing suite complications) or a no such host timeout on ssh
|
|
Expect(scp).Should(ExitWithError(125, "failed to connect: dial tcp: lookup "))
|
|
})
|
|
|
|
})
|