mirror of
https://github.com/containers/podman.git
synced 2025-10-14 09:45:59 +08:00
17193af962
In the RHEL specific branches we want to ensure that all MRs link to at least one downstream Jira ticket. To do this we add a new test in validate-source similar to the existing pr-should-include-tests. This test only runs on actual pull requests. The syntax for linking to a Jira is "Fixes " or "Fixes: ", followed by one jira links, like so: ``` Fixes https://issues.redhat.com/browse/RHEL-50506 Fixes: https://issues.redhat.com/browse/RHEL-50506 ``` Note: This is the same syntax as for a regular github issue reference. Signed-off-by: Alexander Larsson <alexl@redhat.com>
147 lines
4.0 KiB
Bash
Executable File
147 lines
4.0 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# tests for pr-should-link-jira.t
|
|
#
|
|
|
|
ME=$(basename $0)
|
|
|
|
# Our test script queries github, for which we need token
|
|
if [[ -z "$CIRRUS_REPO_CLONE_TOKEN" ]]; then
|
|
if [[ -n "$GITHUB_TOKEN" ]]; then
|
|
export CIRRUS_REPO_CLONE_TOKEN="$GITHUB_TOKEN"
|
|
else
|
|
echo "$ME: Please set \$CIRRUS_REPO_CLONE_TOKEN" >&2
|
|
exit 1
|
|
fi
|
|
fi
|
|
|
|
###############################################################################
|
|
# BEGIN test cases
|
|
#
|
|
|
|
read -d '\n' msg_no_jira << EndOfText
|
|
This is some text
|
|
without a jira
|
|
EndOfText
|
|
|
|
read -d '\n' msg_invalid << EndOfText
|
|
This is some text
|
|
without a jira
|
|
Fixes #42
|
|
More text...
|
|
EndOfText
|
|
|
|
read -d '\n' msg_jira << EndOfText
|
|
This is some text
|
|
with a jira
|
|
Fixes https://issues.redhat.com/browse/RHEL-50507
|
|
More text...
|
|
EndOfText
|
|
|
|
read -d '\n' msg_jira2 << EndOfText
|
|
This is some text
|
|
with a jira
|
|
Fixes: https://issues.redhat.com/browse/RHEL-50507
|
|
More text...
|
|
EndOfText
|
|
|
|
read -d '\n' msg_multiple << EndOfText
|
|
This is some text
|
|
with multiple jira lines
|
|
Fixes https://issues.redhat.com/browse/RHEL-50507
|
|
More text...
|
|
Fixes: https://issues.redhat.com/browse/RHEL-50506
|
|
More text...
|
|
EndOfText
|
|
|
|
# Feel free to add as needed. Syntax is:
|
|
# <exit status> <pr> <commit message> <dest branch> # comments
|
|
#
|
|
# Where:
|
|
# exit status is the expected exit status of the script
|
|
# pr pr number (only used to get tag, 0000 if doesn't matter)
|
|
# commit message commit message
|
|
# dest branch name of branch
|
|
#
|
|
|
|
tests="
|
|
0 0000 msg_no_jira main not rhel branch, no link, should pass
|
|
0 0000 msg_jira main not rhel branch, link, should pass
|
|
0 0000 msg_invalid main not rhel branch, invalid link, should pass
|
|
0 0000 msg_no_jira v4.9 not rhel branch, no link, should pass
|
|
1 23514 msg_no_jira v4.9-rhel no link, no tag, should fail
|
|
0 8890 msg_no_jira v4.9-rhel no link, tag, should work
|
|
1 23514 msg_invalid v4.9-rhel invalid link, no tag, should fail
|
|
0 0000 msg_jira v4.9-rhel link, should work
|
|
0 0000 msg_jira2 v4.9-rhel link with colon, should work
|
|
0 0000 msg_multiple v4.9-rhel multiple links, should work
|
|
"
|
|
|
|
# The script we're testing
|
|
test_script=$(dirname $0)/$(basename $0 .t)
|
|
|
|
# END test cases
|
|
###############################################################################
|
|
# BEGIN test-script runner and status checker
|
|
|
|
function run_test_script() {
|
|
local expected_rc=$1
|
|
local testname=$2
|
|
|
|
testnum=$(( testnum + 1 ))
|
|
|
|
# DO NOT COMBINE 'local output=...' INTO ONE LINE. If you do, you lose $?
|
|
local output
|
|
output=$( $test_script )
|
|
local actual_rc=$?
|
|
|
|
if [[ $actual_rc != $expected_rc ]]; then
|
|
echo "not ok $testnum $testname"
|
|
echo "# expected rc $expected_rc"
|
|
echo "# actual rc $actual_rc"
|
|
if [[ -n "$output" ]]; then
|
|
echo "# script output: $output"
|
|
fi
|
|
rc=1
|
|
else
|
|
if [[ $expected_rc == 1 ]]; then
|
|
# Confirm we get an error message
|
|
if [[ ! "$output" =~ "Please add a reference" ]]; then
|
|
echo "not ok $testnum $testname"
|
|
echo "# Expected: ~ 'Please add a reference'"
|
|
echo "# Actual: $output"
|
|
rc=1
|
|
else
|
|
echo "ok $testnum $testname - rc=$expected_rc"
|
|
fi
|
|
else
|
|
echo "ok $testnum $testname - rc=$expected_rc"
|
|
fi
|
|
fi
|
|
}
|
|
|
|
# END test-script runner and status checker
|
|
###############################################################################
|
|
# BEGIN test-case parsing
|
|
|
|
rc=0
|
|
testnum=0
|
|
tested_override=
|
|
|
|
while read expected_rc pr msg branch rest; do
|
|
# Skip blank lines
|
|
test -z "$expected_rc" && continue
|
|
|
|
export DEST_BRANCH=$branch
|
|
export CIRRUS_CHANGE_MESSAGE="${!msg}"
|
|
export CIRRUS_PR=$pr
|
|
|
|
run_test_script $expected_rc "PR $pr $msg $branch - $rest"
|
|
done <<<"$tests"
|
|
|
|
echo "1..$testnum"
|
|
exit $rc
|
|
|
|
# END Test-case parsing
|
|
###############################################################################
|