opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-05-17 06:59:07 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
podman/libpod
History
Matt Heon 0ccb836156 Fix a potential deadlock during podman cp 
Have one function without a `defer lock.unlock()` as one of the
commands in it calls a function that also takes the same lock,
so the unlock has to happen prior to function completion.
Unfortunately, this is prone to errors, like the one here: I
missed a case, and we could return without unlocking, causing a
deadlock later in the cleanup code as we tried to take the same
lock again.

Refactor the command to use `defer unlock()` to simplify and
avoid any further errors of this type.

Introduced by e66b788a514fb8df2c8b8d3c000e0d543bbd60df - this
should be included in any backports of that commit.

Fixes #25585

Signed-off-by: Matt Heon <mheon@redhat.com>
2025-04-02 09:38:19 -04:00
..
define
test: adapt tests new crun error messages
2025-04-01 11:32:34 +02:00
driver
Bump Go module to v5
2024-02-08 09:35:39 -05:00
events
update golangci/golangci-lint to v1.63.4
2025-01-07 15:48:53 +01:00
layers
Initial checkin from CRI-O repo
2017-11-01 11:24:59 -04:00
linkmode
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
lock
Additional potential race condition on os.Readdir
2024-08-12 11:38:02 -04:00
logs
bump go to 1.22
2024-09-03 15:14:15 +02:00
plugin
libpod: use fileutils.(Le|E)xists
2024-04-19 09:52:14 +02:00
shutdown
Revert "libpod: remove shutdown.Unregister()"
2024-11-27 08:09:50 -05:00
boltdb_state_internal.go
Ignore result of EvalSymlinks on ENOENT
2024-07-11 09:39:56 -04:00
boltdb_state.go
libpod: use fileutils.(Le|E)xists
2024-04-19 09:52:14 +02:00
common_test.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
container_api.go
libpod: race in WaitForConditionWithInterval()
2025-03-10 13:14:10 -04:00
container_commit.go
api: Error checking before NULL dereference
2024-11-28 14:01:45 +03:00
container_config.go
Fix HealthCheck log destination, count, and size defaults
2025-03-17 15:10:59 +00:00
container_copy_common.go
Fix a potential deadlock during podman cp
2025-04-02 09:38:19 -04:00
container_copy_freebsd.go
Mount volumes before copying into a container
2024-11-27 08:09:50 -05:00
container_copy_linux.go
Mount volumes before copying into a container
2024-11-27 08:09:50 -05:00
container_exec.go
podman exec: correctly support detaching
2025-02-03 01:50:55 +00:00
container_freebsd.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
container_graph_test.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
container_graph.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
container_inspect_freebsd.go
libpod: fix HostConfig.Devices output from 'podman inspect' on FreeBSD
2024-09-02 11:21:35 +01:00
container_inspect_linux.go
Switch to moby/sys/capability
2024-10-01 12:52:18 -07:00
container_inspect.go
Fix HealthCheck log destination, count, and size defaults
2025-03-17 15:10:59 +00:00
container_internal_common.go
Fix a potential deadlock during podman cp
2025-04-02 09:38:19 -04:00
container_internal_freebsd.go
Add --no-hostname option
2025-01-15 06:51:32 -05:00
container_internal_linux_test.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
container_internal_linux.go
Add --no-hostname option
2025-01-15 06:51:32 -05:00
container_internal_test.go
Switch all calls of assert.Nil to assert.NoError
2025-01-15 07:08:27 -05:00
container_internal.go
Fix HealthCheck log destination, count, and size defaults
2025-03-17 15:10:59 +00:00
container_linux.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
container_log_linux.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
container_log_unsupported.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
container_log.go
libpod: log file use Wait() over event API
2024-11-01 18:53:08 +01:00
container_path_resolution_test.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
container_path_resolution.go
Mount volumes before copying into a container
2024-11-27 08:09:50 -05:00
container_stat_common.go
Mount volumes before copying into a container
2024-11-27 08:09:50 -05:00
container_stat_freebsd.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
container_stat_linux.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
container_top_freebsd.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
container_top_linux.c
libpod/container_top_linux.c: fix missing header
2024-06-27 10:50:17 +02:00
container_top_linux.go
update golangci-lint to 1.60.1
2024-08-19 11:41:28 +02:00
container_top_unsupported.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
container_validate.go
Add ExposedPorts to Inspect's ContainerConfig
2024-10-01 07:54:52 -04:00
container.go
Fix HealthCheck log destination, count, and size defaults
2025-03-17 15:10:59 +00:00
diff.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
doc.go
document that using libpod package directly is not supported
2022-03-23 19:05:29 +01:00
events.go
Fix HealthCheck log destination, count, and size defaults
2025-03-17 15:10:59 +00:00
healthcheck_config.go
Configure HealthCheck with podman update
2024-11-19 19:44:14 +01:00
healthcheck_linux.go
healthcheck: do not leak service on failed stop
2024-10-25 15:27:05 +02:00
healthcheck_nosystemd_linux.go
libpod: do not leak systemd hc startup unit timer
2024-06-04 18:03:46 +02:00
healthcheck_unsupported.go
libpod: do not leak systemd hc startup unit timer
2024-06-04 18:03:46 +02:00
healthcheck.go
Fix HealthCheck log destination, count, and size defaults
2025-03-17 15:10:59 +00:00
info_freebsd.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
info_linux.go
rootless: drop function ReadMappingsProc
2024-04-10 11:55:35 +02:00
info_test.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
info.go
Merge pull request #24731 from l0rd/additionalimagestores
2024-12-03 14:15:08 +00:00
kube.go
Kube volumes can not container _
2024-12-18 09:07:57 -05:00
mounts_linux.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
networking_common.go
Set network ID if available during container inspect
2025-01-20 15:55:26 +01:00
networking_freebsd.go
use new c/common pasta2 setup logic to fix dns
2024-03-19 12:09:31 +01:00
networking_linux_test.go
bump go to 1.22
2024-09-03 15:14:15 +02:00
networking_linux.go
libpod: setupNetNS() correctly mount netns
2024-09-20 15:19:22 +02:00
networking_machine.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
networking_pasta_linux.go
libpod: use pasta Setup() over Setup2()
2024-10-30 13:35:56 +01:00
networking_slirp4netns.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
oci_conmon_attach_common.go
fix race conditions in start/attach logic
2024-07-12 15:11:34 +02:00
oci_conmon_attach_freebsd.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
oci_conmon_attach_linux.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
oci_conmon_common.go
Remove persist directory when cleaning up Conmon files
2025-02-11 21:10:25 +00:00
oci_conmon_exec_common.go
Use persist dir for oom file
2024-02-12 09:13:39 -05:00
oci_conmon_exec_freebsd.go
Cease using deprecated runc userlookup
2024-02-02 11:02:43 -05:00
oci_conmon_exec_linux.go
Cease using deprecated runc userlookup
2024-02-02 11:02:43 -05:00
oci_conmon_freebsd.go
libpod: intermediate mount if UID not mapped into the userns
2024-06-21 18:01:26 +02:00
oci_conmon_linux.go
libpod: do not cover idmapped mountpoint
2025-04-01 11:39:12 +02:00
oci_conmon.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
oci_missing.go
Remove persist directory when cleaning up Conmon files
2025-02-11 21:10:25 +00:00
oci_util.go
oci: report empty exec path as ENOENT
2025-04-01 11:32:49 +02:00
oci.go
Remove persist directory when cleaning up Conmon files
2025-02-11 21:10:25 +00:00
options.go
Fix HealthCheck log destination, count, and size defaults
2025-03-17 15:10:59 +00:00
pod_api.go
Add --no-hostname option
2025-01-15 06:51:32 -05:00
pod_internal_freebsd.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
pod_internal_linux.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
pod_internal.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
pod_status.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
pod_top_freebsd.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
pod_top_linux.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
pod.go
podman pod stats: fix race when ctr process exits
2024-07-22 10:30:42 +02:00
reset.go
libpod: cleanup default cache on system reset
2024-05-29 11:10:55 +02:00
rlimit_int64.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
rlimit_uint64.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
runtime_cstorage.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
runtime_ctr_freebsd.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
runtime_ctr_linux.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
runtime_ctr.go
podman mount: some better error wrapping
2024-09-27 15:15:23 +02:00
runtime_freebsd.go
Detect unhandled reboots and require user intervention
2024-04-05 10:07:42 -04:00
runtime_img.go
libpod: pass down NoPivotRoot to Buildah
2024-11-18 12:41:47 +01:00
runtime_linux.go
Detect unhandled reboots and require user intervention
2024-04-05 10:07:42 -04:00
runtime_migrate_linux.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
runtime_migrate_unsupported.go
Remove Libpod special-init conditions
2024-01-12 09:19:34 -05:00
runtime_pod_common.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
runtime_pod_freebsd.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
runtime_pod_linux.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
runtime_pod.go
Replace golang.org/x/exp/slices with slices from std
2024-04-23 11:16:40 +02:00
runtime_pre_go1.20.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
runtime_renumber.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
runtime_test.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
runtime_volume_common.go
Create quota before _data dir for volumes
2025-03-10 14:18:41 +00:00
runtime_volume.go
libpod: remove duplicated HasVolume() check
2024-08-15 11:07:27 +02:00
runtime_worker.go
create runtime's worker queue before queuing any job
2024-07-09 11:15:29 +02:00
runtime.go
Clean up after unexpectedly terminated build
2025-01-27 14:21:27 +01:00
service.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
sqlite_state_internal.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
sqlite_state.go
In SQLite state, use defaults for empty-string checks
2025-02-11 11:01:00 -05:00
state_test.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
state.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
stats_common.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
stats_freebsd.go
Fix some comments
2024-04-13 15:20:19 +08:00
stats_linux.go
libpod: report cgroups deleted during Stat() call
2024-10-29 11:16:57 +01:00
storage.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
util_freebsd.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
util_linux_test.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
util_linux.go
libpod: fix rootless cgroup path with --cgroup-parent
2024-09-04 05:30:35 +00:00
util.go
podman exec: correctly support detaching
2025-02-03 01:50:55 +00:00
volume_inspect.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
volume_internal_common.go
Bump Go module to v5
2024-02-08 09:35:39 -05:00
volume_internal_freebsd.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
volume_internal_linux.go
chore: delete obsolete // +build lines
2024-01-04 11:53:38 +02:00
volume_internal.go
Only stop chowning volumes once they're not empty
2024-05-22 17:47:01 -04:00
volume.go
Only stop chowning volumes once they're not empty
2024-05-22 17:47:01 -04:00