mirror of
https://github.com/containers/podman.git
synced 2025-08-23 17:22:30 +08:00
6e7de438cc
The Docker `-XDELETE image/$name?force=true` endpoint only removes containers using an image if they are in a non running state. In Podman, when forcefully removing images we also forcefully delete containers using the image including running containers. This patch changes the Docker image force delete compat API to act like the Docker API while maintaining commands like `podman rmi -f $imagename` It also corrects the API return code returned when an image is requested to be deleted with running containers using it. Fixes: https://github.com/containers/podman/issues/25871 Signed-off-by: Lewis Roy <lewis@redhat.com>
81 lines
2.5 KiB
Go
81 lines
2.5 KiB
Go
//go:build !remote
|
|
|
|
package compat
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
|
|
"github.com/containers/podman/v5/libpod"
|
|
"github.com/containers/podman/v5/libpod/define"
|
|
"github.com/containers/podman/v5/pkg/api/handlers/utils"
|
|
api "github.com/containers/podman/v5/pkg/api/types"
|
|
"github.com/containers/podman/v5/pkg/domain/entities"
|
|
"github.com/containers/podman/v5/pkg/domain/infra/abi"
|
|
"github.com/containers/storage"
|
|
)
|
|
|
|
func RemoveImage(w http.ResponseWriter, r *http.Request) {
|
|
decoder := utils.GetDecoder(r)
|
|
runtime := r.Context().Value(api.RuntimeKey).(*libpod.Runtime)
|
|
|
|
query := struct {
|
|
Force bool `schema:"force"`
|
|
NoPrune bool `schema:"noprune"`
|
|
Ignore bool `schema:"ignore"`
|
|
}{
|
|
// This is where you can override the golang default value for one of fields
|
|
}
|
|
|
|
if err := decoder.Decode(&query, r.URL.Query()); err != nil {
|
|
utils.Error(w, http.StatusBadRequest, fmt.Errorf("failed to parse parameters for %s: %w", r.URL.String(), err))
|
|
return
|
|
}
|
|
name := utils.GetName(r)
|
|
possiblyNormalizedName, err := utils.NormalizeToDockerHub(r, name)
|
|
if err != nil {
|
|
utils.Error(w, http.StatusInternalServerError, fmt.Errorf("normalizing image: %w", err))
|
|
return
|
|
}
|
|
|
|
imageEngine := abi.ImageEngine{Libpod: runtime}
|
|
|
|
options := entities.ImageRemoveOptions{
|
|
Force: query.Force,
|
|
NoPrune: query.NoPrune,
|
|
Ignore: query.Ignore,
|
|
DisableForceRemoveContainers: true,
|
|
}
|
|
report, rmerrors := imageEngine.Remove(r.Context(), []string{possiblyNormalizedName}, options)
|
|
if len(rmerrors) > 0 && rmerrors[0] != nil {
|
|
err := rmerrors[0]
|
|
if errors.Is(err, storage.ErrImageUnknown) {
|
|
utils.ImageNotFound(w, name, fmt.Errorf("failed to find image %s: %w", name, err))
|
|
return
|
|
}
|
|
if errors.Is(err, storage.ErrImageUsedByContainer) {
|
|
utils.Error(w, http.StatusConflict, fmt.Errorf("image %s is in use: %w", name, err))
|
|
return
|
|
}
|
|
if errors.Is(err, define.ErrCtrStateInvalid) {
|
|
utils.Error(w, http.StatusConflict, fmt.Errorf("image %s is in an invalid state: %w", name, err))
|
|
return
|
|
}
|
|
utils.Error(w, http.StatusInternalServerError, err)
|
|
return
|
|
}
|
|
response := make([]map[string]string, 0, len(report.Untagged)+1)
|
|
for _, d := range report.Deleted {
|
|
deleted := make(map[string]string, 1)
|
|
deleted["Deleted"] = d
|
|
response = append(response, deleted)
|
|
}
|
|
for _, u := range report.Untagged {
|
|
untagged := make(map[string]string, 1)
|
|
untagged["Untagged"] = u
|
|
response = append(response, untagged)
|
|
}
|
|
utils.WriteResponse(w, http.StatusOK, response)
|
|
}
|