Commit Graph

22034 Commits

Author SHA1 Message Date
Paul Holzinger
02403c2e6d Makefile: podman should have correct selinux label
pasta only works when we run as container_runtime_exec_t, now that pasta
is the default this means that the current binary will not work when
doing local dev without manually fixing the label.

There are also other parts where the correct label is important. So as a
simple fix always set the proper label in the bin/podman target.
This also means we can drop this line from the hack/bats script.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-03-05 11:08:23 +01:00
Paul Holzinger
9ee96a9569 properly implement pull-error event status
Commit 03f6589f3 added basic support for pull-error event from libimage
but it contains several problems:
1. storing the error as error type prevents it from being unmarshalled,
   thus change it to a string
2. the error was never propagated from the libimage event to the podman
   event struct
3. the error message was not wired into the cli and API

This commit fixes these problems.

Fixes #21458

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-03-05 10:50:42 +01:00
openshift-merge-bot[bot]
3e1d2ab874 Merge pull request #21942 from containers/renovate/golang.org-x-tools-0.x
fix(deps): update module golang.org/x/tools to v0.19.0
2024-03-05 09:35:31 +00:00
openshift-merge-bot[bot]
e7a23b0ee2 Merge pull request #21941 from containers/renovate/golang.org-x-net-0.x
fix(deps): update module golang.org/x/net to v0.22.0
2024-03-05 09:13:25 +00:00
renovate[bot]
155cd463da fix(deps): update module golang.org/x/tools to v0.19.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-05 06:58:51 +00:00
Jason T. Greene
6272abbbb8 Resurrect auto-port reassignment, but for all providers
- Updates common to pull in new locked edit

[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2024-03-04 23:55:36 -06:00
Jason T. Greene
ef7727238a Refactor env dir and port functions into new leaf pkgs
[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2024-03-04 23:54:31 -06:00
openshift-merge-bot[bot]
e58b168e11 Merge pull request #21924 from hadirgax/patch-1
[CI:DOCS] Update podman-for-windows.md
2024-03-05 03:18:39 +00:00
renovate[bot]
eabf0acfa3 fix(deps): update module golang.org/x/net to v0.22.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-05 03:15:32 +00:00
openshift-merge-bot[bot]
d395610462 Merge pull request #21940 from containers/renovate/golang.org-x-term-0.x
fix(deps): update module golang.org/x/term to v0.18.0
2024-03-05 03:13:11 +00:00
Chris Evich
3b72f9178f Revert "Expose as-tested Mac/Windows repository state"
Fix artifacts task error:

```
Failed to upload artifacts:
rpc error: code = FailedPrecondition
desc = Artifacts size is too big!
```

This reverts commit 698219cf98.

Signed-off-by: Chris Evich <cevich@redhat.com>
2024-03-04 15:08:37 -05:00
renovate[bot]
24516f3ef8 fix(deps): update module golang.org/x/term to v0.18.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-04 19:40:35 +00:00
openshift-merge-bot[bot]
231118cc5c Merge pull request #21933 from edsantiago/logformatter-mac
logformatter: fixes for Macintosh
2024-03-04 16:52:39 +00:00
openshift-merge-bot[bot]
8532d3ef1d Merge pull request #21930 from vrothberg/fix-21856
machine init: print output to improve UX
2024-03-04 16:49:31 +00:00
Hadir Garcia
e8bf9a323a Update podman-for-windows.md
Signed-off-by: Hadir Garcia <22103698+hadirgax@users.noreply.github.com>
2024-03-04 16:12:30 +00:00
openshift-merge-bot[bot]
a61f89527e Merge pull request #21921 from containers/renovate/github.com-containers-libhvee-digest
fix(deps): update github.com/containers/libhvee digest to 0ff33af
2024-03-04 15:07:47 +00:00
renovate[bot]
8c92228482 fix(deps): update github.com/containers/libhvee digest to 0ff33af
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-04 13:51:06 +00:00
Valentin Rothberg
e09444327a machine init: print output to improve UX
As outlined in #21856, it can take a number of seconds until an image
gets pulled.  That is because init is hitting the registry first to look
up the image.  To improve the UX, add a new line indicating what
happens.

[NO NEW TESTS NEEDED]

Fixes: #21856
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2024-03-04 14:46:38 +01:00
Ed Santiago
530782e11d logformatter: fixes for Macintosh
Lots of small special-case tweaks to logformatter because Macs
have to be different.

Also fix:
 - Wrong slash in printf-newline, leading to gray [It] blocks
 - echo gitCommit, so we can link to sources
 - --image-path is deprecated

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-03-04 05:52:00 -07:00
openshift-merge-bot[bot]
5a4864c340 Merge pull request #18442 from Luap99/e2e-noerrout
test/e2e: check for stderr errors in cleanup()
2024-03-04 11:45:55 +00:00
Paul Holzinger
ebce0e71da test/e2e: check for stderr errors in cleanup()
There are many code paths which only do logrus but still exit 0 so this
should catch more bugs. Unfortunately runc logs way to much random stuff
so we ignore this check for runc right now.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-03-04 11:25:22 +01:00
openshift-merge-bot[bot]
c77f0031f9 Merge pull request #21928 from n1hility/fix-freebsd-ci
Fix CI: Bump to FreeBSD 13.3 (13.2 vanished)
2024-03-04 01:23:43 +00:00
Jason T. Greene
ef6d387525 Bump to FreeBSD 13.3 (13.2 vanished)
[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2024-03-03 18:02:45 -06:00
openshift-merge-bot[bot]
413819de07 Merge pull request #21908 from containers/renovate/github.com-stretchr-testify-1.x
fix(deps): update module github.com/stretchr/testify to v1.9.0
2024-03-02 19:08:40 +00:00
openshift-merge-bot[bot]
445d0e2362 Merge pull request #20847 from BlackHole1/remove-k8s-dep
Copy past golang/expansion form ks8.io/kubernetes
2024-03-02 18:35:39 +00:00
openshift-merge-bot[bot]
460fc4d65f Merge pull request #21909 from mheon/bump_500_rc4
Bump to v5.0.0-RC4
2024-03-01 19:24:13 +00:00
Matt Heon
fc4e16366c Bump to v5.0.0-dev
Signed-off-by: Matt Heon <mheon@redhat.com>
2024-03-01 13:17:43 -05:00
renovate[bot]
bce14b1e67 fix(deps): update module github.com/stretchr/testify to v1.9.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-01 18:17:25 +00:00
Matt Heon
cfc5b8e0fd Bump to v5.0.0-RC4
Signed-off-by: Matt Heon <mheon@redhat.com>
v5.0.0-rc4
2024-03-01 13:17:21 -05:00
openshift-merge-bot[bot]
0ace66f1ae Merge pull request #21904 from containers/renovate/python-dateutil-2.x
chore(deps): update dependency python-dateutil to ~=2.9.0
2024-03-01 18:15:34 +00:00
openshift-merge-bot[bot]
959c97b035 Merge pull request #21906 from baude/issue21874
Use stop timeout of zero for system reset
2024-03-01 18:12:56 +00:00
Brent Baude
0898b338b0 Use stop timeout of zero for system reset
when performing a system reset with containers that run somewhere where
a soft kill wont work (like sleep), containers will wait 10 seconds
before terminating with a sigkill.  But for a forceful action like
system reset, we should outright set no timeout so containers stop
quickly and are not waiting on a timeout

Fixes #21874

Signed-off-by: Brent Baude <bbaude@redhat.com>
2024-03-01 10:51:58 -06:00
renovate[bot]
542883b9ba chore(deps): update dependency python-dateutil to ~=2.9.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-01 14:45:10 +00:00
openshift-merge-bot[bot]
032cd5b402 Merge pull request #21900 from containers/renovate/github.com-shirou-gopsutil-v3-3.x
fix(deps): update module github.com/shirou/gopsutil/v3 to v3.24.2
2024-03-01 14:43:43 +00:00
openshift-merge-bot[bot]
70faffa87c Merge pull request #21891 from edsantiago/no-new-tests-label
CI: must-add-tests check: use GH label, not text
2024-03-01 13:40:28 +00:00
Ed Santiago
99bb2bfce4 CI: must-add-tests check: use GH label, not text
Old way: edit commit message, add magic string, re-push

New way: repo maintainer adds a Github label to PR, hits Rerun

I've looked and looked for the history behind this script
and why I didn't do it this way in the first place. I've
concluded that I just never thought of it.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-03-01 05:32:06 -07:00
renovate[bot]
c5c294a35a fix(deps): update module github.com/shirou/gopsutil/v3 to v3.24.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-01 12:07:18 +00:00
openshift-merge-bot[bot]
4fdec1a19a Merge pull request #21880 from rhatdan/VENDOR
Vendor in containers/(buildah,common, image)
2024-03-01 12:04:14 +00:00
Daniel J Walsh
3abc488c84 Vendor in containers/(buildah, common)
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-02-29 20:06:28 -05:00
openshift-merge-bot[bot]
38546de7b6 Merge pull request #21892 from rhatdan/codespell
[SKIP-ci] Run codespell on code
2024-03-01 00:34:01 +00:00
openshift-merge-bot[bot]
b736c461bb Merge pull request #21563 from mheon/test_pasta_default
Vendor c/common pasta branch for testing
2024-02-29 22:13:47 +00:00
Daniel J Walsh
4a03da22ad Run codespell on code
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-02-29 16:55:31 -05:00
openshift-merge-bot[bot]
87729cc666 Merge pull request #21862 from ashley-cui/ocidisk
Use machine image as specified in containers.conf
2024-02-29 20:51:23 +00:00
openshift-merge-bot[bot]
1519c04212 Merge pull request #21886 from containers/renovate/pytest-7.x
Update dependency pytest to v7.4.4
2024-02-29 20:45:48 +00:00
Matt Heon
03f6589f34 Fix events by fully adding the new PullError event
Signed-off-by: Matt Heon <mheon@redhat.com>
2024-02-29 15:23:17 -05:00
openshift-merge-bot[bot]
b681209efe Merge pull request #21653 from nalind/fun-with-artifacts
podman manifest add: support creating artifact manifest on the fly
2024-02-29 19:04:03 +00:00
renovate[bot]
52fd284fd4 Update dependency pytest to v7.4.4
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-02-29 18:42:48 +00:00
openshift-merge-bot[bot]
98a9aee2d2 Merge pull request #21601 from flobz/feature/docker_v1.44_compat
Make inspect compatible with docker v1.44 API
2024-02-29 18:42:01 +00:00
Ashley Cui
2b86ab5a1e Change image-path to image for tests
As we deprecate image-path for image.

Signed-off-by: Ashley Cui <acui@redhat.com>
2024-02-29 13:38:53 -05:00
Ashley Cui
527b3793b8 Use machine image as specified in containers.conf
For podman machine init, deprecate the --image-path option for --image.
--image now accepts the correct image from containers.conf

Also, add the ability to specify an OCI image from the --image flag using the docker:// transport.

Signed-off-by: Ashley Cui <acui@redhat.com>
2024-02-29 13:38:43 -05:00