Commit Graph

7612 Commits

Author SHA1 Message Date
Chris Evich
6e60772dc3 Cirrus: Utilize new base images
Signed-off-by: Chris Evich <cevich@redhat.com>
2020-04-30 13:21:03 -04:00
Chris Evich
7c44c05425 cirrus: Update to Fedora 32 proper
Now that it's officially released, update to it from the beta.  Also
(and significant), adjust the SELinux context of the GCP metadata
service.  Add a comment to the code explaining why this is necessary.

Signed-off-by: Chris Evich <cevich@redhat.com>
2020-04-30 13:21:03 -04:00
Sujil02
c3c030f550 Enable prune integration test. Fixes container prune.
Fixes container prune to prune created and configured containers.
Disables couple of system prune test as not yet in with v2.

Signed-off-by: Sujil02 <sushah@redhat.com>
2020-04-30 12:03:09 -04:00
Giuseppe Scrivano
aef7836b38 test: enable start tests
`docker start` doesn't resolve partial ID -> full ID, adapt test.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-30 15:49:12 +02:00
OpenShift Merge Robot
fc9451ed15 Merge pull request #6047 from QiWang19/attach-test
testv2: enable attach test
2020-04-30 15:27:37 +02:00
Giuseppe Scrivano
9d373408b5 podman, start: propagate back the raw input
this is necessary as we expect "podman start $ID_NAME" to print the
same arguments the user passed in instead of the full ID.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-30 12:23:19 +02:00
Giuseppe Scrivano
1d34977b4c test: enable remaining run tests
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-30 11:33:37 +02:00
Giuseppe Scrivano
9c67a9c155 test: enable entrypoint tests
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-30 11:33:36 +02:00
Giuseppe Scrivano
ed7a9739e4 test: enable create tests
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-30 11:33:35 +02:00
Giuseppe Scrivano
c11cff4542 cmd, podman: do not override entrypoint if unset
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-30 11:33:34 +02:00
Giuseppe Scrivano
32564df172 cmd, podman: use String instead of variable+StringVar
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-30 11:33:34 +02:00
Giuseppe Scrivano
65d7f22720 cmd, podman: handle --pod new:POD
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-30 11:33:33 +02:00
Giuseppe Scrivano
27f5145445 create: propagate override-arch and override-os
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-30 11:33:32 +02:00
Qi Wang
75eeb40f41 testv2: enable attach test
testv2: enable attach test

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-04-29 23:47:15 -04:00
Jhon Honce
22d5b2e305 V2 enable ps tests
* Combine cobra.Command helper functions into validate package
  from registry and common packages
* Introduce ChoiceValue for flags

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-29 15:51:37 -07:00
OpenShift Merge Robot
99f8cfc2dc Merge pull request #5956 from jwhonce/wip/version
V2 restore podman -v command
2020-04-29 20:50:43 +02:00
OpenShift Merge Robot
a2127efbf8 Merge pull request #6042 from baude/systemtestfinal
enable final system test
2020-04-29 20:33:40 +02:00
baude
e1f1dee006 enable final system test
Signed-off-by: baude <bbaude@redhat.com>
2020-04-29 12:01:18 -05:00
OpenShift Merge Robot
06dce0c770 Merge pull request #5949 from jwhonce/jira/796
V2 Restore images list tests
2020-04-29 18:53:06 +02:00
Jhon Honce
6a586992c1 V2 restore podman -v command
* Removed extra spaces and improved error message
* Updated tests to use gomega matchers

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-29 09:15:24 -07:00
Jhon Honce
a9cc13448e V2 Restore images list tests
* Fix history --quiet formatting
* Fix image inspect --format=json
* Fix image list --sort

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-29 08:24:56 -07:00
OpenShift Merge Robot
27aa3a7837 Merge pull request #6039 from vrothberg/enable-search-tests
Enable search tests
2020-04-29 17:04:22 +02:00
OpenShift Merge Robot
d1196d08d0 Merge pull request #6010 from TomSweeneyRedHat/dev/tsweeney/ctrimagefixes
Update podmanimage files to adjust perms on containers.conf for rootless
2020-04-29 16:59:37 +02:00
OpenShift Merge Robot
620baafa07 Merge pull request #5853 from cevich/unify_in_podman_build
Unify in_podman container packaging & VM packaging
2020-04-29 16:38:24 +02:00
Valentin Rothberg
5ee3af2d03 enable search tests
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 16:28:18 +02:00
Valentin Rothberg
2d10471b8d pull/search options: tls verify -> skip
Change the logic in the options from tls-verify to skipping
verification.  It require a constant brain yoga to translate
from doing verification (CLI logic) to skipping it (c/image logic).
As the code is using c/image, let's make it consistent.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 16:28:12 +02:00
OpenShift Merge Robot
c5a035b032 Merge pull request #6038 from giuseppe/v2-enable-copy
test: enable cp tests
2020-04-29 16:26:07 +02:00
OpenShift Merge Robot
a76a99352a Merge pull request #6037 from vrothberg/enable-push-tests
Enable push tests
2020-04-29 16:20:44 +02:00
OpenShift Merge Robot
6246165f16 Merge pull request #6036 from giuseppe/fix-rootlessport-panic
rootlessport: use two different channels
2020-04-29 16:07:44 +02:00
OpenShift Merge Robot
de77e4b3f1 Merge pull request #6031 from mheon/release_191_in_master
Update release notes and README for 1.9.1 release
2020-04-29 16:05:11 +02:00
Giuseppe Scrivano
b74508fff0 test: enable cp tests
and fix them to use a distinct directory.  I've seen a test failing as
it was using the same directory as another test, that is not related
to v2 itself.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-29 15:40:31 +02:00
Valentin Rothberg
5c108f75eb login system test: enable "push ok"
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 15:23:30 +02:00
OpenShift Merge Robot
a22dacfa1b Merge pull request #6035 from giuseppe/move-rootless-open-before-fork
rootless: move ns open before fork
2020-04-29 15:07:07 +02:00
Valentin Rothberg
4177641875 enable the push e2e tests
With the recent changes, push is working now.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 14:35:48 +02:00
Valentin Rothberg
d6d1e3860c push: fix --tls-verify
Fix --tls-verify parsing and make the associated options reflect the
correct logic.  Other commands are affected as well but will be fixed
later.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 14:33:00 +02:00
Valentin Rothberg
46b185942c push: simplify cmd
The indirection via a 2nd variable isn't needed.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 14:14:02 +02:00
Giuseppe Scrivano
6d545bb2f7 rootlessport: use two different channels
The same channel is written to by two different goroutines.

Use a different channel for each of them so to avoid writing to a
closed channel.

Closes: https://github.com/containers/libpod/issues/6018

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-29 12:35:23 +02:00
Giuseppe Scrivano
b8db112436 specgen: honor slirp4netns
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-29 12:13:05 +02:00
Giuseppe Scrivano
89d4940a37 rootless: move ns open before fork
commit 788fdc685b introduced a race
where the target process dies before the child process opens the
namespace files.  Move the open before the fork so if it fails the
parent process can attempt to join a different container instead of
failing.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-29 11:44:24 +02:00
Valentin Rothberg
854293a59a push: fix push with one argument
When doing a `podman push $IMG`, $IMG acts as the source and the
destination.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 11:42:36 +02:00
OpenShift Merge Robot
3e912f711b Merge pull request #6022 from vrothberg/enable-inspect-tests
enable inspect tests
2020-04-29 11:21:47 +02:00
OpenShift Merge Robot
62a4befe04 Merge pull request #5998 from vrothberg/generate-systemd
generate systemd
2020-04-29 11:19:15 +02:00
OpenShift Merge Robot
4e21d09f98 Merge pull request #6029 from rhatdan/env
User specified environment happen after other environments are set
2020-04-29 08:52:14 +02:00
Valentin Rothberg
8700c2fd03 enable inspect tests
A surprisingly big change.  A core problem was that `podman inspect`
allows for passing containers AND images with the default `--type=all`.
This only worked partially as the data was processed in isolation which
caused various issues (e.g., two separate outputs instead of one) but it
also caused issues regarding error handling.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 07:25:31 +02:00
Valentin Rothberg
b2414b580e generate systemd
Implement `podman generate systemd` for Podman v2 and enable associated
tests.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 07:22:18 +02:00
Matthew Heon
af0d99f942 Update release notes and README for 1.9.1 release
Signed-off-by: Matthew Heon <mheon@redhat.com>
2020-04-28 18:08:59 -04:00
TomSweeneyRedHat
9229312f2a Update podmanimage files to adjust perms on containers.conf for rootless
Adding the changes to the Podman image Docker/Containerfiles similar
to @rhatdan 's changes in https://github.com/containers/buildah/pull/2332

In short it changes the perms on containers.conf so it can be used by a
rootless user.

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2020-04-28 17:52:14 -04:00
OpenShift Merge Robot
bf4efc1953 Merge pull request #6026 from baude/v2forcesystemtests
system tests must pass
2020-04-28 23:29:20 +02:00
OpenShift Merge Robot
dcac908bbe Merge pull request #6011 from sujil02/podman-save-issue-5234
Fixes podman save fails when specifying an image using a digest fixes-5234
2020-04-28 23:10:20 +02:00
OpenShift Merge Robot
30b27819d0 Merge pull request #5991 from sujil02/pod-rm-test
Fix typos in messages pod rm
2020-04-28 22:40:09 +02:00