17564 Commits

Author SHA1 Message Date
480c7fbf53 Merge pull request #16708 from arixmkii/cross-build-fixes
Build cross-compilation fixes
2022-12-02 15:04:15 -05:00
b0bd257114 Merge pull request #16714 from alexlarsson/quadlet-use-regular-defaults
Quadlet use regular defaults
2022-12-02 14:59:04 -05:00
92ced4282f Merge pull request #16715 from dfr/freebsd-build
libpod: Track healthcheck API changes in healthcheck_unsupported.go
2022-12-02 14:37:55 -05:00
98a1b551fe Build cross-compilation fixes
Signed-off-by: Arthur Sengileyev <arthur.sengileyev@gmail.com>
2022-12-02 19:22:53 +02:00
6ed8dc17ce libpod: Track healthcheck API changes in healthcheck_unsupported.go
Extra function arguments were added in #13909.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
2022-12-02 16:41:21 +00:00
16cf34dc3a quadlet: Use same default capability set as podman run
Signed-off-by: Alexander Larsson <alexl@redhat.com>
2022-12-02 16:37:22 +01:00
b34ab8b5fa quadlet: Drop --pull=never
This is to match podman run default behaviour.

Signed-off-by: Alexander Larsson <alexl@redhat.com>
2022-12-02 16:33:09 +01:00
098ad52ecb quadlet: Change default of ReadOnly to no
This matches the default podman run behaviour.

Signed-off-by: Alexander Larsson <alexl@redhat.com>
2022-12-02 16:30:15 +01:00
1c3fddfaf7 quadlet: Change RunInit default to no
This matches the default of podman run.

Signed-off-by: Alexander Larsson <alexl@redhat.com>
2022-12-02 16:25:47 +01:00
d19ea6a60d quadlet: Change NoNewPrivileges default to false
This matches the default of podman run.

Signed-off-by: Alexander Larsson <alexl@redhat.com>
2022-12-02 16:24:47 +01:00
a93a390b8c test: podman run with checkpoint image
Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
2022-12-02 14:39:33 +00:00
f4401567cd Enable 'podman run' for checkpoint images
This patch extends the podman run command with support for checkpoint
images. When `podman run` is invoked with an image that contains
a checkpoint, it would restore the container from that checkpoint.

Example:
    podman run -d --name looper busybox /bin/sh -c \
	    'i=0; while true; do echo $i; i=$(expr $i + 1); sleep 1; done'

    podman container checkpoint --create-image checkpoint-image-1 looper

    podman run checkpoint-image-1

Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
2022-12-02 14:39:31 +00:00
3a362462c1 test: Add tests for checkpoint images
These tests were unintentionally removed in commit
b47b48f (Revert "Add checkpoint image tests"). They
verify the functionality of the `--create-image` option for
`podman container checkpoint`.

Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
2022-12-02 14:34:59 +00:00
bdd5f82458 CI setup: simplify environment passthrough code
The passthrough_env function was unnecessarily complicated,
hence fragile. Clean it up, and add regression tests.

For future reference: CI broke horribly because of this.
Rootless tests all failed with missing CI_DESIRED_NETWORK.
Root cause was that CIRRUS_CHANGE_TITLE had a trailing
space which, because of shell indirection, passthrough_env()
wrote as trailing backslash (not backslash-space) in the
/etc/ci_environment file, which then caused the next line
in the file to get glommed onto CIRRUS_CHANGE_TITLE.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-12-01 16:19:22 -07:00
51deb324a3 Merge pull request #16681 from n1hility/atomic-writeconfig
Improve atomicity of VM state persistence on Windows
2022-12-01 16:56:55 -05:00
10e020c651 Init containers should not be restarted
This is causing podman to wait about 25 seconds before starting
the primary container.

Fixes: https://github.com/containers/podman/issues/16343

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-12-01 14:50:45 -05:00
582394fc2c Merge pull request #16696 from mohanboddu/latest_release
[CI:DOCS] Set the latest release explicitly
2022-12-01 13:16:09 -05:00
c83efd0f07 Update c/storage after https://github.com/containers/storage/pull/1436
... and update to remove the now-deprecated Locker interface.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2022-12-01 16:05:13 +01:00
486790f619 Set the latest release explicitly
Mark the highest version release as the latest release so that
https://github.com/containers/podman/releases/latest will always
point to the highest version release.

Signed-off-by: Mohan Boddu <mboddu@redhat.com>
2022-12-01 09:29:41 -05:00
e7eb19c7cc Merge pull request #16680 from cevich/docs_skip_win_smoke
[CI:DOCS] Skip windows-smoke when not useful
2022-12-01 05:36:18 -05:00
c0f9a923e2 Merge pull request #16689 from rhatdan/VENDOR
Update vendor of containers/(image, buildah)
2022-12-01 03:48:09 -05:00
d19e1526d3 add friendly comment
Signed-off-by: karta0807913 <karta0807913@gmail.com>
2022-12-01 11:35:51 +08:00
1d84f0adb9 fix an overriding logic and load config problem
Fix an overriding logic in Inhearit function.
Alos, ToSpecGen function doesn't load the cgroup/image volume config from containers.conf.

Signed-off-by: karta0807913 <karta0807913@gmail.com>
2022-12-01 08:01:02 +08:00
c00d8a27d9 Merge pull request #13909 from mheon/startup_probe
Add support for startup healthchecks
2022-11-30 15:23:15 -05:00
2b6cf1d072 Update the issue templates
Adding "Bug Report" and "Feature Request" templates, this will
help with filing the tickets and also finding the information
once filed.

Signed-off-by: Mohan Boddu <mboddu@redhat.com>
2022-11-30 14:06:29 -05:00
d740b1593d Merge pull request #16686 from vrothberg/with-great-power-comes-great-responsibility
[CI:DOCS] OWNERS: add  Jason T. Greene
2022-11-30 13:06:14 -05:00
2862ecf288 Update vendor of containers/(image, buildah)
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-11-30 13:05:12 -05:00
66f352a6cb Merge pull request #16671 from vrothberg/snoopdate
[CI:docs] hack/podmansnoop: print arguments
2022-11-30 10:28:42 -05:00
1c1a8d33f6 [CI:DOCS] Skip windows-smoke when not useful
It's important to actually perform a windows build for a `[CI:DOCS]` PR
since it verifies and includes a copy of the docs.  However, it's not
necessary to actually test if the installer functions or not. That task
should happen in other contexts.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-11-30 10:17:44 -05:00
190bab5534 [CI:DOCS] Remove broken gate-container docs
This container hasn't been used/maintained in ages, remove the related
instructions from the contributions doc.

Fixes: #16415

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-11-30 10:09:31 -05:00
d8d84e92c0 Merge pull request #16655 from jelly/restore-doc
[CI:DOCS] Expand and fix checkpoint restore documentation
2022-11-30 09:33:49 -05:00
f0d7ce9fc4 Merge pull request #16659 from n1hility/custom-install-loc
Allow manual override of install location in Windows installer
2022-11-30 09:28:27 -05:00
bb10095ec1 OWNERS: add Jason T. Greene
Add @n1hility to the OWNERS file.  They are maintaining various
subsystems of Podman including machine on Windows.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2022-11-30 14:56:14 +01:00
b294b7c37c Merge pull request #16672 from lsm5/copr-podman-restart
[CI:BUILD] copr: enable podman-restart.service on rpm installation
2022-11-30 04:48:01 -05:00
68d41c68d9 hack/podmansnoop: print arguments
Update the snoop script to also include the arguments to make the output
more useful.

```
$ sudo hack/podmansnoop
PCOMM            PID     PPID    AGE(ms) ARGV
conmon           14964   14952   1.01    /usr/bin/conmon --version
podman           14952   14139   26.07   /usr/bin/podman ps
```

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2022-11-30 10:38:08 +01:00
009f5ec672 Improve atomicity of VM state persistence on Windows
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2022-11-29 12:38:47 -06:00
0521748911 [CI:BUILD] copr: enable podman-restart.service on rpm installation
Resolves: #16669

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2022-11-29 21:18:41 +05:30
e15ffc1a76 Merge pull request #16599 from vrothberg/RUN-1702
container create: add inspect data to event
2022-11-29 09:10:57 -05:00
54ef7f98d9 macos: pkg: Use -arm64 suffix instead of -aarch64
All files released in
https://github.com/containers/podman/releases/tag/v4.3.1 use -arm64 for
the arch name except podman-installer-macos-aarch64.pkg

Related: https://github.com/containers/podman/issues/16612
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
2022-11-29 11:18:21 +01:00
fe548dd0b0 linux: Add -linux suffix to podman-remote-static binaries
This is more consistent with the name of the other released files, and
makes identification of the binaries easier among the Windows/macOS
ones.

Related: https://github.com/containers/podman/issues/16612
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
2022-11-29 11:18:20 +01:00
d223950078 linux: Build amd64 and arm64 podman-remote-static binaries
Looking at https://github.com/containers/podman/releases/tag/v4.3.1,
it's not explicit which arch the podman-remote-static binary is built
for, so this commit adds an -$(goarch) suffix to it. It builds both
arm64 and amd64 binaries as I need both for crc.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
2022-11-29 11:18:18 +01:00
71f92d263c container create: add inspect data to event
When the new `events_container_create_inspect_data` option is enabled in
containers.conf set the `ContainersInspectData` event field for each
container-create event.

The data was requested for the purpose of auditing (e.g., intrusion
detection).

Jira: https://issues.redhat.com/browse/RUN-1702
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2022-11-29 10:40:24 +01:00
d2ac99d65c Allow manual override of install location
Also reuse install location for previous installs if present

Example Usage: .\podman-4.3.2-setup.exe InstallFolder=C:\Other\Loc

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2022-11-28 15:46:35 -06:00
c49de2210c Merge pull request #16651 from rhatdan/codespell
Run codespell on code
2022-11-28 16:44:19 -05:00
ee8b6ec01d Merge pull request #16653 from mheon/metric_docs
[CI:DOCS] Add information on metrics to the `network create` docs
2022-11-28 15:16:20 -05:00
f17479c711 Run codespell on code
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-11-28 15:13:43 -05:00
cb96eac45b Add missing parameters for checkpoint/restore endpoint
Document the remaining missing options for container checkpoint and
restore.

[NO NEW TESTS NEEDED]

Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
2022-11-28 20:48:28 +01:00
40aefe9830 Merge pull request #16628 from ingobecker/fix-netio-stats
Fix swapped NetInput/-Output stats
2022-11-28 14:42:47 -05:00
6c7b836cb9 Merge pull request #16609 from arixmkii/whpx-docs
Documenting Hyper-V QEMU acceleration settings
2022-11-28 14:34:18 -05:00
d16129330d Add support for startup healthchecks
Startup healthchecks are similar to K8S startup probes, in that
they are a separate check from the regular healthcheck that runs
before it. If the startup healthcheck fails repeatedly, the
associated container is restarted.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2022-11-28 13:30:29 -05:00