Commit Graph

23515 Commits

Author SHA1 Message Date
Jake Correnti
e041f2a7b7 Remove RemoveFilesAndConnections
The `RemoveFilesAndConnections` function is not being used, so its safe
to remove it and not carry unnecessary code that we need to maintain.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2024-09-12 14:40:24 -04:00
Jake Correnti
54b71b637c Add GetAllMachinesAndRootfulness
Adds the function `GetAllMachinesAndRootfulness` which creates a map of
all podman machines, of any supported provider, on the system and
whether it is rootful or not.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2024-09-12 14:31:55 -04:00
openshift-merge-bot[bot]
40ca23077d Merge pull request #23649 from pwright/patch-1
typo
2024-09-12 14:53:13 +00:00
Paul Wright
ac4a31cc4a rewrite typo osascript
Signed-off-by: Paul Wright <pwright@redhat.com>
2024-09-12 14:57:55 +01:00
Paul Wright
089d2513d8 typo
Signed-off-by: Paul Wright <pwright@redhat.com>
2024-09-12 14:57:41 +01:00
openshift-merge-bot[bot]
7764bea981 Merge pull request #23819 from l0rd/kube-play-image-type-volumes
Add `kube play` support for volumes of type image
2024-09-11 18:32:24 +00:00
openshift-merge-bot[bot]
c66d46c39a Merge pull request #23899 from edsantiago/new-vms
Bump VMs. ShellCheck is now built-in
2024-09-11 13:46:14 +00:00
openshift-merge-bot[bot]
5afc21d87e Merge pull request #23926 from giuseppe/update-common
vendor: update c/common
2024-09-11 13:40:44 +00:00
Giuseppe Scrivano
b9fe4097dd vendor: update c/common
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-09-11 12:53:24 +02:00
openshift-merge-bot[bot]
b1efc500b4 Merge pull request #23893 from afbjorklund/ssh-config-refactor
refactor: add sshClient function
2024-09-10 20:32:13 +00:00
openshift-merge-bot[bot]
c38c197c71 Merge pull request #23907 from edsantiago/safename-020
CI: make 020-tag parallel-safe
2024-09-10 19:09:45 +00:00
Mario Loriedo
db12343e27 Add kube play support for image volume source
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-09-10 12:37:06 +00:00
openshift-merge-bot[bot]
ff0f6eb8c6 Merge pull request #23906 from edsantiago/safename-410
CI: make 410-selinux parallel-safe
2024-09-10 10:39:45 +00:00
openshift-merge-bot[bot]
5be750208a Merge pull request #23910 from containers/renovate/golang.org-x-tools-0.x
fix(deps): update module golang.org/x/tools to v0.25.0
2024-09-10 09:53:00 +00:00
Anders F Björklund
837755e643 refactor: add sshClient function
The ssh options needs some weird parameters like (the raw) uri
and machine (insecure), so it is not enough with url and identity.

The "secure" query parameter was removed in Podman v4.3, it is now
replaced with the "machine" option parameter (InsecureIgnoreHostKey)

I think that url.Parse will fail to add any url.Port that is not
an integer, so the strconv.Atoi error probably can never happen?

But since it is only a validation error and not a connection error,
it cannot be wrapped in a ConnectError so that goes into function.

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
2024-09-10 07:19:39 +02:00
renovate[bot]
a83fef34a9 fix(deps): update module golang.org/x/tools to v0.25.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-09 21:51:16 +00:00
Ed Santiago
18932e0339 CI: make 020-tag parallel-safe
Use safename, with guaranteed-adjacent image names

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-09-09 13:37:57 -06:00
Ed Santiago
a165289574 CI: make 410-selinux parallel-safe
Use safename for containers and pods. Add ci:parallel tags.
And reenable distro-integration tests that had been skipped
due to a container-selinux bug that is now fixed.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-09-09 13:09:37 -06:00
openshift-merge-bot[bot]
c12c86e303 Merge pull request #23891 from eriksjolund/troubleshooting-userns-auto
troubleshooting: add tip about --userns=auto and --userns=keep-id
2024-09-09 19:01:56 +00:00
openshift-merge-bot[bot]
649730c9a1 Merge pull request #23887 from Luap99/sort-tags
podman images: sort repository with tags
2024-09-09 16:39:15 +00:00
Ed Santiago
359092e463 Bump VMs. ShellCheck is now built-in
Minor bump. Fedora VMs now include ShellCheck, so we can
remove the 'dnf install' at CI run time.

Also, FWIW, Debian *vark are now at 1.12 (from 1.9)

VMs built in https://github.com/containers/automation_images/pull/385

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-09-09 06:16:20 -06:00
Erik Sjölund
005d9b543b troubleshooting: add tip about auto, keep-id, nomap
Add tip about --userns=auto, --userns=keep-id,
--userns=nomap and the error message:
"not enough unused IDs in user namespace"

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2024-09-07 09:50:35 +02:00
openshift-merge-bot[bot]
f22f4cfe50 Merge pull request #23791 from Luap99/pasta-map-guest-addr
libpod: make use of new pasta option from c/common
2024-09-06 14:05:22 +00:00
Paul Holzinger
a1e6603133 libpod: make use of new pasta option from c/common
pasta added a new --map-guest-addr to option that maps a to the actual
host ip. This is exactly what we need for host.containers.internal
entry. So we now make use of this option by default but still have to
keep the exclude fallback because the option is very new and some
users/distros will not have it yet.

This also fixes an issue where the --dns-forward ip were not used when
using the bridge network mode, only useful when not using aardvark-dns
as this used the proper ips there already from the rootless netns
resolv.conf file.

Fixes #19213

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-09-06 14:43:18 +02:00
Paul Holzinger
2f858675b3 vendor latest c/common
Includes my pasta changes.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-09-06 14:42:56 +02:00
Paul Holzinger
0abbcfa50a podman images: sort repository with tags
When you sort by repository a user most likely also want the tags to be
sorted as well. At the very least to get a stable output as the order
could be changed pull podman tag/pull even if they keep using the same
tag name.

Fixes #23803

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-09-06 14:17:17 +02:00
openshift-merge-bot[bot]
2be86b72af Merge pull request #23884 from containers/renovate/golang.org-x-net-0.x
fix(deps): update module golang.org/x/net to v0.29.0
2024-09-06 11:43:03 +00:00
openshift-merge-bot[bot]
d91c00ad6c Merge pull request #23866 from containers/renovate/github.com-mattn-go-sqlite3-1.x
fix(deps): update module github.com/mattn/go-sqlite3 to v1.14.23
2024-09-06 11:15:34 +00:00
renovate[bot]
2840b21862 fix(deps): update module golang.org/x/net to v0.29.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-06 10:25:08 +00:00
openshift-merge-bot[bot]
bfc7e92215 Merge pull request #23880 from containers/renovate/golang.org-x-crypto-0.x
fix(deps): update module golang.org/x/crypto to v0.27.0
2024-09-06 10:23:18 +00:00
renovate[bot]
38555305c2 fix(deps): update module github.com/mattn/go-sqlite3 to v1.14.23
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-06 10:07:31 +00:00
openshift-merge-bot[bot]
dde031076b Merge pull request #23722 from umohnani8/jobs
Add support for Job to kube generate & play
2024-09-06 09:02:55 +00:00
openshift-merge-bot[bot]
b645f708f8 Merge pull request #23875 from rhatdan/rootless
Add podman-rootless.7 man page
2024-09-06 08:51:55 +00:00
renovate[bot]
1c23bd5acf fix(deps): update module golang.org/x/crypto to v0.27.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-06 08:12:21 +00:00
openshift-merge-bot[bot]
a26a493f6b Merge pull request #23881 from edsantiago/fix-ci
Fix CI
2024-09-05 21:27:27 +00:00
Ed Santiago
133bbd3769 Fix CI
Collision between new spellcheck CI hook and a parallel typo

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-09-05 13:55:34 -06:00
openshift-merge-bot[bot]
ae14dff812 Merge pull request #23398 from yarikoptic/enh-codespell
Add codespell support (config, workflow to detect/not fix) and make it fix few typos
2024-09-05 18:53:25 +00:00
openshift-merge-bot[bot]
094fed7dbe Merge pull request #23846 from flouthoc/prune-cleancachemount
prune: add `--build-cache` to support clearing build cache using `CleanCacheMount`
2024-09-05 18:47:56 +00:00
openshift-merge-bot[bot]
858b25df27 Merge pull request #23879 from Luap99/prune-flake
test/e2e: fix network prune flake
2024-09-05 18:34:16 +00:00
Yaroslav Halchenko
c203c48c70 Detect and fix typos using codespell
Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
2024-09-05 13:56:39 -04:00
Yaroslav Halchenko
12b3d01438 Fix typo: replace buildin with built-in
Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
2024-09-05 13:56:03 -04:00
Yaroslav Halchenko
4700b5a58a Add codespell config, pre-commit definition, and move options from Makefile
Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
2024-09-05 13:56:03 -04:00
flouthoc
901f621daa prune: support clearing build cache using CleanCacheMount
`podman builder prune` and `podman image prune` should also support
cleaning build cache using buildah's public `CleanCacheMount` API.

Reference: https://docs.docker.com/reference/cli/docker/builder/prune/
Context: https://github.com/containers/podman/discussions/15612#discussioncomment-10532721
Context: https://github.com/containers/buildah/pull/4490

Signed-off-by: flouthoc <flouthoc.git@gmail.com>
2024-09-05 10:40:07 -07:00
Paul Holzinger
1543c5f0ad test/e2e: fix network prune flake
Creating networks in a different dir is not parallel safe when running
containers on them as the network configs may end up using the same
bridge names which then causes conflicts on the host.

Fixes #23876

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-09-05 17:47:53 +02:00
Urvashi Mohnani
bdf96e7df2 Add support for Job to kube generate & play
The kube generate command can now generate a yaml for
the Job kind and the kube play command can create a pod
and containers with podman when passed in a Job yaml.
Add relevant tests and docs for this.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2024-09-05 11:36:38 -04:00
Daniel J Walsh
c317da8deb Add podman-rootless.7 man page
This is a follow up to 5389eee737
to add rooltess.md information to man pages to help users
discover solutions to troubleshooting and rooless issues.

Specicifally I was surprised when binding to ports < 1024 was
not covered in podman-troubleshooting.7 man page.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-09-05 09:56:48 -04:00
openshift-merge-bot[bot]
8578fddf0f Merge pull request #23868 from toadstule/quadlet-pod-dns
Add DNS, DNSOption and DNSSearch to quadlet pod
2024-09-05 10:07:15 +00:00
openshift-merge-bot[bot]
ba7d4edb13 Merge pull request #23864 from edsantiago/run-hook-sigpipe
e2e: flake fix: SIGPIPE in hook test
2024-09-05 10:04:28 +00:00
openshift-merge-bot[bot]
04ad9b6748 Merge pull request #23865 from bcdarwin/23849-manpage-policy-json-paths
podman.1.md: improve policy.json section
2024-09-04 21:11:39 +00:00
Steve Jibson
15bde1abdb Add DNS, DNSOption and DNSSearch to quadlet pod
Signed-off-by: Steve Jibson <steve@jibson.com>
2024-09-04 11:31:32 -06:00