2179 Commits

Author SHA1 Message Date
2444ac9926 Move rootless directory handling to the libpod/pkg/util directory
This should allow us to share this code with buildah.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2018-10-22 09:43:59 -04:00
bb98a9cd2f Fix podman port -l
Running 'podman port -l' on a system without any containers created
gives:

 $ podman port -l
 panic: runtime error: invalid memory address or nil pointer dereference
 [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0xf3cef1]

 goroutine 1 [running]:
 github.com/containers/libpod/libpod.(*Container).State(0x0, 0x0, 0x0, 0x0)
 	/share/go/src/github.com/containers/libpod/libpod/container.go:658 +0x41
 main.portCmd(0xc420094580, 0x0, 0x0)
 	/share/go/src/github.com/containers/libpod/cmd/podman/port.go:118 +0x406

This fixes it by making sure the variable 'containers' is nil and not [<nil>].

Signed-off-by: Adrian Reber <areber@redhat.com>
2018-10-19 08:47:52 +02:00
0fefe3b191 Merge pull request #1673 from stickster/patch-1
Fix trivial missing markup in manpage
2018-10-18 14:32:57 -07:00
a7a3a5ca2a Fix trivial missing markup in manpage
Signed-off-by: Paul W. Frields <stickster@gmail.com>
2018-10-18 14:22:24 -04:00
89b5484ad2 Cirrus: Install CRIU in test images
Signed-off-by: Chris Evich <cevich@redhat.com>
2018-10-18 12:37:09 -04:00
a18494a345 Cirrus: Use different CNI_COMMIT for Fedora
Just noticed this in Dockerfile.Fedora.  Updated all the right
places to make this happen.

Signed-off-by: Chris Evich <cevich@redhat.com>
2018-10-18 12:37:08 -04:00
02bc3c9962 Fix Cirrus/Packer VM image building
An invalid GCE value is being passed to packer, preventing it from
building VM images.  Fix this, and centralize the definition of the
image name suffix by setting it at ``setup_environment.sh`` call-time,
rather encoding inside packer's `libpod_images.json`.  This makes
the value available for use by other scripts.

Also, switch the unique component of the name, to be based on the
commit-sha being tested.  This will improve traceability, since the git
history is more permanent than the `CIRRUS_BUILD_ID` env. var.  The
later is subject to log-rotation, destroying evidence of the images
source state.

Signed-off-by: Chris Evich <cevich@redhat.com>
2018-10-18 12:37:08 -04:00
4de69da7bd Revert "Cirrus: Enable debugging delay on non-zero exit"
This reverts commit b610913ef55ac36d0b145a7d20461649650cc5a1.

Signed-off-by: Chris Evich <cevich@redhat.com>
2018-10-18 12:33:36 -04:00
0c17f2010a Cirrus: IRC message when cirrus testing successful
Signed-off-by: Chris Evich <cevich@redhat.com>
2018-10-18 12:33:36 -04:00
a50410467a cirrus: Add simple IRC messenger
Add a naive python script that's able to connect to IRC and send a
single line of text to the #podman channel.  Wrap this in a new
library function to ensure nick-name collisions are unlikely.

Signed-off-by: Chris Evich <cevich@redhat.com>
2018-10-18 12:33:36 -04:00
a75a888640 Merge pull request #1647 from baude/notify
fix NOTIFY_SOCKET in e2e testfix NOTIFY_SOCKET in e2e tests
2018-10-18 09:07:53 -07:00
4662d06efd fix NOTIFY_SOCKET in e2e testfix NOTIFY_SOCKET in e2e tests
Signed-off-by: baude <bbaude@redhat.com>
2018-10-18 10:38:16 -05:00
05cadf31d2 Merge pull request #1679 from mheon/bump-0.10.1.3
Bump to  v0.10.1.3
2018-10-17 18:53:20 -04:00
683d8b579b Bump gitvalidation epoch
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-10-17 18:51:37 -04:00
27a5c1a203 Bump to v0.10.2-dev
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-10-17 18:51:36 -04:00
db08685af5 Bump to v0.10.1.3
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
v0.10.1.3
2018-10-17 18:51:33 -04:00
733cfe9681 Merge pull request #1678 from mheon/release_notes_0.10.1.3
Update release notes for 0.10.1.3
2018-10-17 18:49:42 -04:00
98f30f69cf Update release notes for 0.10.1.3
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-10-17 18:49:54 -04:00
d01382aed1 Merge pull request #1676 from baude/updatebuildah
Vendor in new new buildah/ci
2018-10-17 18:44:56 -04:00
bfc473f982 Vendor in new new buildah/ci
libpod requires new buildah and container image versions to resolve
bug #1640298

Signed-off-by: baude <bbaude@redhat.com>
2018-10-17 17:04:19 -05:00
19c150bef1 Merge pull request #1672 from rhatdan/podman
Fix podman in podman
2018-10-17 13:52:57 -04:00
854eb5c541 Fix podman in podman
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2018-10-17 13:17:02 -04:00
2d14ba9e6f Merge pull request #1669 from mheon/bump-0.10.1.2
Bump to v0.10.1.2
2018-10-17 11:35:36 -04:00
6a32daad08 Bump gitvalidation epoch
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-10-17 11:34:13 -04:00
74cce34e31 Bump to v0.10.2-dev
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-10-17 11:34:13 -04:00
2b4f8d1f5f Bump to v0.10.1.2
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
v0.10.1.2
2018-10-17 11:34:09 -04:00
d12eb5f35a Merge pull request #1668 from mheon/release_notes_0.10.1.2
Update release notes for 0.10.1.2
2018-10-17 11:33:47 -04:00
9002efcb77 Update release notes for 0.10.1.2
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-10-17 11:34:11 -04:00
4ad2904261 Merge pull request #1667 from mheon/fix_systemd_cgroup_path
Fix CGroup paths used for systemd CGroup mount
2018-10-17 11:29:03 -04:00
4a60656dbb Fix CGroup paths used for systemd CGroup mount
We already have functions for retrieving the container's CGroup
path, so use them instead of manually generating a path.

Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-10-17 10:45:58 -04:00
604728d65d Merge pull request #1658 from mheon/bump-0.10.1.1
Bump to 0.10.1.1
2018-10-16 13:53:49 -04:00
f98c4a9c73 Bump gitvalidation epoch
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-10-16 13:52:16 -04:00
a9d9444b70 Bump to v0.10.2-dev
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-10-16 13:52:15 -04:00
4bea3e9466 Bump to v0.10.1.1
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
v0.10.1.1
2018-10-16 13:52:10 -04:00
4aeaadb857 Merge pull request #1657 from mheon/release_notes_0.10.1.1
Update release notes for 0.10.1.1
2018-10-16 13:51:25 -04:00
58ad6ec779 Update release notes for 0.10.1.1
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-10-16 13:50:20 -04:00
a2266c63b4 Merge pull request #1650 from rhatdan/systemd
Mount proper cgroup for systemd to manage inside of the container.
2018-10-16 13:26:20 -04:00
81e63ac309 Merge pull request #1609 from giuseppe/fix-volume-rootless
volume: resolve symlink paths in volumes
2018-10-16 13:25:27 -04:00
57a8c2e5e8 Mount proper cgroup for systemd to manage inside of the container.
We are still requiring oci-systemd-hook to be installed in order to run
systemd within a container.  This patch properly mounts

/sys/fs/cgroup/systemd/libpod_parent/libpod-UUID on /sys/fs/cgroup/systemd inside of container.

Since we need the UUID of the container, we needed to move Systemd to be a config option of the
container.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2018-10-15 16:19:11 -04:00
2bc9a3c4bb Merge pull request #1645 from cevich/flake_delay
Cirrus: Enable debugging delay on non-zero exit
2018-10-15 07:26:29 -07:00
f667a782a4 Merge pull request #1644 from TomSweeneyRedHat/dev/tsweeney/nofileo
Touchup fileo typo
2018-10-15 07:12:54 -07:00
b610913ef5 Cirrus: Enable debugging delay on non-zero exit
There have been some python-podman flakes observed across multiple CI
systems.  Support capturing a VM for further investigation in the
event of a non-zero exit.  This is done by printing a warning message
and delaying script-exit for a long time.  Hopefully a human will notice
and have an opportunity to enable deletion-protection on the VM.

Signed-off-by: Chris Evich <cevich@redhat.com>
2018-10-15 09:48:19 -04:00
d8d4c0f0e1 Touchup fileo typo
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2018-10-15 08:13:42 -04:00
3639ac1ad0 Merge pull request #1631 from giuseppe/papr-drop-double-process
papr_prepare: remove double process for starting up .papr.sh
2018-10-15 03:52:39 -07:00
6dd6ce1ebc volume: resolve symlinks in paths
ensure the volume paths are resolved in the mountpoint scope.

Otherwise we might end up using host paths.

Closes: https://github.com/containers/libpod/issues/1608

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2018-10-14 16:57:30 +02:00
2ad6012ea1 volume: write the correct ID of the container in error messages
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2018-10-14 16:57:29 +02:00
5691938563 vendor: update containers/buildah
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2018-10-14 16:57:28 +02:00
83f79dbacc papr: relabel GOPATH/github.com/containers/libpod
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2018-10-14 16:52:32 +02:00
1f8b844c2b tests: do not fail in the cleanup phase
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2018-10-14 16:52:31 +02:00
e1521c6323 tests: do not make assumptions on the mount output
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2018-10-14 16:52:30 +02:00