14995 Commits

Author SHA1 Message Date
c75030590c Merge pull request #13565 from naveensrinivasan/naveen/feat/dependabot-update
Updated dependabot to GitHub actions
2022-03-28 21:41:54 +02:00
1821eb3837 Pin actions to a full length commit SHA
- Pinned actions by SHA https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies
- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

>Pin actions to a full length commit SHA

>Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

Also dependabot supports upgrades based on SHA.

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
2022-03-28 19:00:16 +00:00
9cfa9695a0 Merge pull request #13674 from baude/refactor1
Machine refactor - part 1
2022-03-28 18:14:23 +02:00
2ac897aa0d Machine refactor - part 1
the way machine was written was very adjunct and as such is in dire need
of refactoring to better structures and structure methods where
appropriate.  the weekest part is specifically around all the files that
machine requires and how some are just dynamically built on the fly.

this pr defines a new machinefile type which allows us to work with the
file and also takes into account the use of symlinks which are going to
be needed on macos due to its relatively short file length restriction.

also, added unit tests for new methods as well as anywhere else I saw a
need.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2022-03-28 09:12:08 -05:00
b76d717bbf Merge pull request #13640 from Luap99/slirp4netns-fail
network setup: fail if slirp4netns is not installed
2022-03-28 15:51:51 +02:00
54f808e4dd Merge pull request #13651 from jwmatthews/fix13650
Fixes errors from 'manifest push' being dropped in remote case
2022-03-28 15:37:50 +02:00
ffe87c0bdf Merge pull request #13677 from flouthoc/rename-event
libpod, event: generate a valid event on container `rename` operation
2022-03-28 15:15:51 +02:00
e1699d8591 Merge pull request #13668 from rhatdan/walk
Switch all calls to filepath.Walk to filepath.WalkDir
2022-03-28 15:14:19 +02:00
aeae598049 Merge pull request #13592 from containers/dependabot/go_modules/google.golang.org/protobuf-1.28.0
build(deps): bump google.golang.org/protobuf from 1.27.1 to 1.28.0
2022-03-28 15:09:51 +02:00
7df6849f16 Merge pull request #13648 from adamaze/main
[CI:DOCS] clarifying "loginctl enable-linger" section in doc
2022-03-28 09:08:00 -04:00
38bd4010cf network setup: fail if slirp4netns is not installed
I do not see why we should only log an error. If slirp4netns is
requested but not installed we should error.

[NO NEW TESTS NEEDED]

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-03-28 12:49:55 +02:00
82ed99b6af event: generate a valid event on container rename operation
Following commit ensures that podman generates a valid event on `podman
container rename` where event specifies that it is a rename event and
container name swtichted to the latest name.

Signed-off-by: Aditya R <arajan@redhat.com>
2022-03-28 15:07:02 +05:30
0ebf0bc560 Merge pull request #13611 from rvandernoort/vendor_filters
Vendor c/common for filters
2022-03-28 00:49:28 +02:00
7989880509 Fixes errors from 'manifest push' being dropped in remote case
Signed-off-by: John Matthews <jwmatthews@gmail.com>
2022-03-27 07:33:13 -04:00
d106b294b4 Switch all calls to filepath.Walk to filepath.WalkDir
WalkDir should be faster the Walk, since we often do
not need to stat files.

[NO NEW TESTS NEEDED] Existing tests should find errors.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-03-27 07:18:25 -04:00
463c0b9f2d Merge pull request #13607 from rvandernoort/filter_docs
[CI:DOCS]: Update docs for image filters
2022-03-27 13:17:31 +02:00
56b2937f87 Merge pull request #13653 from jmontleon/fix-manifest-push-header
Resolves #13629 Add RegistryAuthHeader to manifest push
2022-03-27 13:13:42 +02:00
ddfa087d00 Merge pull request #13660 from rhatdan/error
Remove error stutter
2022-03-27 13:11:31 +02:00
28504f5dd4 Merge pull request #13639 from containers/dependabot/go_modules/github.com/docker/docker-20.10.14incompatible
build(deps): bump github.com/docker/docker from 20.10.13+incompatible to 20.10.14+incompatible
2022-03-27 07:10:09 -04:00
446c35efdf Vendor common
Added patch provided by rhatdan to add support for shareable

[NO NEW TESTS NEEDED]

Signed-off-by: rvandernoort <s.r.vandernoort@student.tudelft.nl>
2022-03-27 13:01:52 +02:00
ab41037c87 Update filter docs with missing entries and add negation option.
[NO NEW TESTS NEEDED]

Signed-off-by: rvandernoort <s.r.vandernoort@student.tudelft.nl>
2022-03-27 12:59:22 +02:00
3cc1739373 Resolves #13629 Add RegistryAuthHeader to manifest push
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
2022-03-26 16:39:11 -04:00
730f1db4da Merge pull request #13659 from rhatdan/codespell
Run codespell to cleanup typos
2022-03-26 10:24:44 +01:00
7680211ede Remove error stutter
When podman gets an error it prints out "Error: " before
printing the error string.  If the error message starts with
error, we end up with

Error: error ...

This PR Removes all of these stutters.

logrus.Error() also prints out that this is an error, so no need for the
error stutter.

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-03-25 21:47:04 -04:00
76614c4613 build(deps): bump google.golang.org/protobuf from 1.27.1 to 1.28.0
Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.27.1 to 1.28.0.
- [Release notes](https://github.com/protocolbuffers/protobuf-go/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash)
- [Commits](https://github.com/protocolbuffers/protobuf-go/compare/v1.27.1...v1.28.0)

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-25 20:00:23 +00:00
dd2a28bfe6 Merge pull request #13658 from containers/dependabot/go_modules/github.com/rootless-containers/rootlesskit-1.0.0
build(deps): bump github.com/rootless-containers/rootlesskit from 0.14.6 to 1.0.0
2022-03-25 20:59:01 +01:00
ffbab30d7b Run codespell to cleanup typos
[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-03-25 15:34:41 -04:00
25345c0870 build(deps): bump github.com/rootless-containers/rootlesskit
Bumps [github.com/rootless-containers/rootlesskit](https://github.com/rootless-containers/rootlesskit) from 0.14.6 to 1.0.0.
- [Release notes](https://github.com/rootless-containers/rootlesskit/releases)
- [Commits](https://github.com/rootless-containers/rootlesskit/compare/v0.14.6...v1.0.0)

---
updated-dependencies:
- dependency-name: github.com/rootless-containers/rootlesskit
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-25 17:49:08 +00:00
1fad1413fd Merge pull request #13662 from giuseppe/fix-ci-test-run
test: fix podman run test as rootless
2022-03-25 13:41:46 -04:00
640c2d53a8 test: fix podman run test as rootless
aafa80918a245edcbdaceb1191d749570f1872d0 introduced the regression.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-03-25 15:50:31 +01:00
37bb6aa346 Merge pull request #13657 from Akasurde/misc_spell
Misc typo fixes
2022-03-25 08:01:43 -04:00
4f73cf3fc7 Misc typo fixes
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2022-03-25 16:22:42 +05:30
206dcd48e9 Merge pull request #13656 from giuseppe/drop-rhel-7-doc
[CI:DOCS] docs: drop note about upcoming RHEL 7.7
2022-03-25 06:16:13 -04:00
c01d1f8e37 [CI:DOCS] docs: drop note about upcoming RHEL 7.7
it was released more than two years ago.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-03-25 11:08:52 +01:00
7934b77dd5 Merge pull request #13531 from cdoern/build
Add Context Directory to tar
2022-03-24 19:15:46 +01:00
e657c7a170 Merge pull request #13622 from rhatdan/systemd1
When running systemd in a container set container_uuid
2022-03-24 19:05:44 +01:00
b6c713f4d7 Merge pull request #13636 from Luap99/machine-port-proxy
podman machine: fix port forwarding with proxy
2022-03-24 13:53:57 -04:00
38e89f39d6 Merge pull request #13647 from lsm5/main-cve-2022-21698
Bump github.com/prometheus/client_golang to v1.11.1
2022-03-24 13:53:21 -04:00
cd10432b09 Merge pull request #13637 from Luap99/conmon-err
readConmonPipeData: try to improve error
2022-03-24 18:52:44 +01:00
3b1d7a7d24 Merge pull request #13621 from Luap99/doc-libpod
[CI:DOCS] document that using libpod package directly is not supported
2022-03-24 18:49:43 +01:00
4d271912e8 Merge pull request #13602 from edsantiago/size_check_part2
Binary growth check, part 2 of 2
2022-03-24 18:47:51 +01:00
712777e0aa Merge pull request #13274 from jwhonce/wip/manifest_4_main
Fix manifest 4.0 endpoints
2022-03-24 18:25:45 +01:00
c61b06c46c Merge pull request #13620 from Luap99/qemu-path
podman machine start: lookup qemu path again if not found
2022-03-24 18:11:45 +01:00
caaaf07c1e Merge pull request #13587 from giuseppe/clone-to-pod
container: allow clone to an existing pod
2022-03-24 18:09:43 +01:00
32748492e9 Merge pull request #13635 from Luap99/rpm-remote
[CI:DOCS] Remove experimental warning from podman-remote rpm
2022-03-24 18:05:48 +01:00
5e893765bc Merge pull request #13638 from Luap99/machine-set-doc
[CI:DOCS] podman machine set: clarify --rootful option
2022-03-24 17:59:46 +01:00
d4bf6b4d78 clarifying "loginctl enable-linger" section in doc
Signed-off-by: Adam Maryniuk <adamaze@gmail.com>
2022-03-24 12:33:05 -04:00
ab8e15f6ac Merge pull request from GHSA-qvf8-p83w-v58j
do not set the inheritable capabilities
2022-03-24 17:02:20 +01:00
61b2d8844f Bump github.com/prometheus/client_golang to v1.11.1
Resolves: CVE-2022-21698

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2022-03-24 11:15:03 -04:00
b469bf5c05 container: allow clone to an existing pod
Closes: https://github.com/containers/podman/issues/3979

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-03-24 14:24:50 +01:00