5025 Commits

Author SHA1 Message Date
7e38a73c4b tests: enable memory tests for cgroups v2
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-13 21:43:37 +02:00
04d333f0ef runtime: honor --runtime flag to build
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-13 21:43:36 +02:00
231b6cb758 test: fix option name
the option is --quiet, not --q

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-13 21:43:35 +02:00
bc6e1f1136 removMergeDir from inspect result if not mounted
Remove GraphDriver.Data.MergedDir from the result of podman inspect if the container not mounte. Because the /var/lib/containers/.../merged directory is no longer created by default; it only exists during the scope of podman mount.

Signed-off-by: Qi Wang <qiwan@redhat.com>
2019-08-13 15:13:20 -04:00
6aa4fbb0ea Running Podman with a nonexistent hooks dir is nonfatal
Even explicitly defined hooks directories may not exist under
some circumstances. It's not worth a hard-fail if we hit an
ENOENT in these cases.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-08-13 15:05:42 -04:00
ce64c1403d Merge pull request #3772 from haircommander/snapcraft
fork https://github.com/abitrolly/podman
2019-08-13 18:44:24 +02:00
7a859f064a Merge pull request #3791 from cevich/install_libvarlink
Cirrus: Install varlink in VM images
2019-08-13 16:24:32 +02:00
316e51f0a9 Add support & documentation to run containers with different file types
Udica is adding new features to allow users to define container process
and file types. This would allow us to setup trusted communications channels
between multiple security domains.  ContainerA -> ContainerB -> ContainerC

Add tests to make sure users can change file types

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-08-13 10:16:01 -04:00
b6c9b10867 Merge pull request #3662 from marusak/user_socket_service
Add user systemd service and socket
2019-08-13 15:57:27 +02:00
4e21e56406 Merge pull request #3649 from cevich/brent_is_back
Revert "Cirrus: Temp. workaround missing imgprune image"
2019-08-13 15:29:02 +02:00
386e939acb Cirrus: Install varlink on Ubuntu
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-08-13 09:16:37 -04:00
0bf7d599f8 Cirrus: Install varlink on Fedora
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-08-13 09:16:37 -04:00
e9365c1a81 Add missing stage-packages in snapcraft.yaml.
Signed-off-by: Jindrich Novy <jnovy@redhat.com>
2019-08-13 08:57:07 -04:00
c606b3d3f1 Add RHEL and SUSE to snap doc
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-08-13 08:57:07 -04:00
1ed4d1fa58 start groundwork for adding snap
by forking https://github.com/abitrolly/podman

Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-08-13 08:57:07 -04:00
031437bf5b Merge pull request #3794 from ashley-cui/macpkg
Homebrew installation in install.md
2019-08-13 14:36:07 +02:00
daf7044aa9 Add user systemd service and socket
This enables user to interact with varlink and create/manage rootless
containers through it.

Using as:
`varlink call unix:/run/user/1000/podman/io.podman/io.podman.ListContainers`

Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-08-13 07:00:56 +02:00
c48243ee1e Merge pull request #3797 from mheon/test_events_revert
Revert #3745 and fix missing exit code for journald
2019-08-13 03:33:06 +02:00
62e8c328d8 Small optimization - only store exit code when nonzero
JSON optimizes it out in that case anyways, so don't waste cycles
doing an Itoa (and Atoi on the decode side).

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-08-12 19:05:44 -04:00
d3a433181d Fix container exit code with Journald backend
We weren't actually storing this, so we'd lose the exit code for
containers run with --rm or force-removed while running if the
journald backend for events was in use.

Fixes #3795

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-08-12 19:05:44 -04:00
f634fd3900 Merge pull request #3607 from cevich/cgroup2_vm
Add another Fedora VM with cgroups v2 enabled
2019-08-12 21:28:56 +02:00
3cf4567e1d Merge pull request #3753 from baude/varlinkrequiresroot
varlink endpoint for containerstats requires root
2019-08-12 21:09:26 +02:00
d36c62d88d Revert "Cirrus: Temp. workaround missing imgprune image"
This reverts commit 9b2e98f1e872354f0708a86b59e16b8b86e9f8b2.

Signed-off-by: Chris Evich <cevich@redhat.com>
2019-08-12 15:04:30 -04:00
99494b55bc Homebrew installation in install.md
Add brew installation instructions to docs & small fix to brew makefile

Signed-off-by: Ashley Cui <ashleycui16@gmail.com>
2019-08-12 15:03:20 -04:00
55cc80d3c9 varlink endpoint for containerstats requires root
obtaining containerstats requires the use of cgroups. at present,
rootless users do not have privileges to create cgroups.  add an error
message that catches this for the varlink endpoint and return a proper
error.

Fixes: #3749

Signed-off-by: baude <bbaude@redhat.com>
2019-08-12 13:08:57 -05:00
9bee6907a5 Merge pull request #3751 from TomSweeneyRedHat/dev/tsweeney/squishnits
Squish a few tpyo nits in container.go doc
2019-08-12 19:51:19 +02:00
ca7bae7f89 Merge pull request #3789 from giuseppe/cirrus-add-crun
cirrus: run tests with crun
2019-08-12 19:14:20 +02:00
341f0bf664 Merge pull request #3793 from stefanb2/topic-pr-3788
image: add user agent to Docker registry options
2019-08-12 19:02:20 +02:00
b843804d51 Adjust get_ci_vm.sh for substitution
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-08-12 12:01:55 -04:00
5f99703594 Cirrus: Add verification for cgroupv2 image
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-08-12 12:01:55 -04:00
7508179ed9 Cirrus: Add experimental fedora VM image & test
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-08-12 12:01:55 -04:00
e7fdaf48db image: add user agent to Docker registry options
Set the string to "libpod/VERSION" so that we don't use the unspecific
default of "Go-http-client/xxx".

Fixes #3788

Signed-off-by: Stefan Becker <chemobejk@gmail.com>
2019-08-12 18:28:36 +03:00
fd312ae30a Cirrus: Minor, use newer Ubuntu base image
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-08-12 11:02:02 -04:00
ec93c9d875 Merge pull request #3786 from giuseppe/fix-rootless-checks
rootless: drop some superflous checks
2019-08-12 16:53:46 +02:00
9f67cde9f8 tests: disable some tests currently failing when not using runc
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 16:09:34 +02:00
f18cfa4768 Merge pull request #3787 from giuseppe/rootless-cherry-pick-oci-runtime
rootless: cherry-pick runtime from the system configuration
2019-08-12 16:06:47 +02:00
efa26eedee containers: look also for 'file not found' in the error message
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 15:47:26 +02:00
2f8451468c cirrus: add tests with crun on Fedora 30
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 15:01:51 +02:00
79aeed9681 rootless: cherry-pick runtime from the system configuration
when creating the default libpod.conf file, be sure the default OCI
runtime is cherry picked from the system configuration.

Closes: https://github.com/containers/libpod/issues/3781

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 14:19:59 +02:00
0798fc5fc4 cirrus: install crun
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 14:11:59 +02:00
9e2f9c8b78 cmd: drop check for euid==0
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 12:33:28 +02:00
0ecf0aa1b8 storage: drop unused geteuid check
it is always running with euid==0 at this point.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 12:30:20 +02:00
dcf2037744 cmd, stats: fix check for rootless mode
and enable rootless stats when running on cgroups v2.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 12:03:53 +02:00
1ef5c4ea8f oci: drop check for euid==0
we are always running with euid==0 at this point.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-12 11:58:18 +02:00
2348c2873f Merge pull request #3785 from giuseppe/podman-build-use-configured-runtime
build: use the configured runtime
2019-08-12 01:55:59 +02:00
2aa35d25b3 build: use the configured runtime
Now buildah honors the runtime configured with podman.

Closes: https://github.com/giuseppe/crun/issues/69

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-08-11 23:25:51 +02:00
146719718e Merge pull request #3782 from eriksjolund/fix_realloc_in_rootless_linux.c
Fix incorrect use of realloc()
2019-08-11 19:44:58 +02:00
7bbaa36a13 Merge pull request #3783 from eriksjolund/fix_read_count
Adjust read count so that a newline can be added afterwards
2019-08-11 19:22:59 +02:00
39ce3626e0 Adjust read count so that a newline can be added afterwards
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2019-08-11 16:44:26 +02:00
4d3cf9b576 Fix incorrect use of realloc()
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2019-08-11 15:58:20 +02:00