9991 Commits

Author SHA1 Message Date
1491b20f08 Merge pull request #8282 from jwhonce/issues/7942
Stop binding layer from changing line endings
2020-11-09 19:59:51 +00:00
8f33751b57 Merge pull request #8283 from kierdavis/docs
[CI:DOCS] man pages: add an example, tweak formatting
2020-11-09 19:58:09 +00:00
f44af20561 Cirrus: Detailed CPU/Memory/Time runner.sh stats
On several occasions, there have been questions about CPU/Memory/IO
trends in testing over time. Start collecting this data for all jobs,
using a common/stable format so that trending analysis can be performed
within/across multiple Cirrus-CI builds. This PR doesn't add any related
tooling, it simply arranges for the collection of the data.

Stats generation is done at the orchestration level to guarantee they
reflect everything happening inside `runner.sh`.  For example, the
container-based tests re-exec `runner.sh` inside a container, but
we're only interested in the top-level stats.

Update all tasks to include collection of the stats file.
Unfortunately, due to the way the Cirrus-CI YAML parser works,
it is *not* possible to alias the artifacts collection more clearly,
for example:

```yaml
    always:
        <<: *runner_stats
        <<: *logs_artifacts
```

Signed-off-by: Chris Evich <cevich@redhat.com>
2020-11-09 14:32:39 -05:00
71fe822434 podman-pull.1.md: add example for pulling an image by hash
Signed-off-by: Kier Davis <me@kierdavis.com>
2020-11-09 13:18:38 -06:00
c20a70f8c3 podman-import.1.md: fix paragraph formatting
Signed-off-by: Kier Davis <me@kierdavis.com>
2020-11-09 13:18:38 -06:00
f29cda6d92 podman-import.1.md: fix shell syntax
Signed-off-by: Kier Davis <me@kierdavis.com>
2020-11-09 13:18:38 -06:00
2d50ec6996 Update CI tests to run python docker library against API
* Update reference to docker-py to docker to reflect change in library
  name
* Update tests to create storage sandbox
* Enable all tests that endpoints support
* Refactor containers/{id}/rename to return 404 not 500
* Refactor tests to use quay.io vs. docker.io

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-11-09 10:45:54 -07:00
a722ba6478 Stop binding layer from changing line endings
The binding layer attempted to help the CLI, which just made things
worse.

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-11-09 10:37:18 -07:00
abc77b4221 Merge pull request #8245 from baude/rootlesscreatecompat
rootless container creation settings
2020-11-09 15:56:50 +00:00
f14cb5ef61 Add support for podman search --format json
Fixes #8274

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2020-11-09 12:59:59 +01:00
f3355d9697 Add --log-driver to play kube
addresses #6604

Signed-off-by: Andy Librian <andylibrian@gmail.com>
2020-11-08 08:59:18 +07:00
e2b82e6245 Merge pull request #8264 from joelsmith/master
Show error on bad name filter in podman ps
2020-11-06 23:39:52 +00:00
708d62078d Show error on bad name filter in podman ps
Signed-off-by: Joel Smith <joelsmith@redhat.com>
2020-11-06 09:11:11 -07:00
dc58d4e285 Merge pull request #8241 from rhatdan/tmpfile
Use /tmp/podman-run-* for backup XDG_RUNTIME_DIR
2020-11-06 15:43:33 +00:00
47a1c96526 Merge pull request #8260 from mbargull/check-scripts-env-cc
Use CPP, CC and flags in dep check scripts
2020-11-06 15:34:33 +00:00
06d2d0c6ef Use CPP, CC and flags in dep check scripts
Allow build systems without standard cc to successfully run the
dependency checking helper scripts from the Makefile.
This supports custom compilers specified by the common CC environment
variable, preprocessors given as CPP and additional preprocessor flags
from CPPFLAGS.
Additional flags from CFLAGS and LDFLAGS are considered for compiling/linking.
Overall, this facilitates cross-compilation and similar setups.

Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
2020-11-06 10:44:27 +01:00
07293bc30a Merge pull request #8255 from rhatdan/readme
[ci:docs] Fix link to point at correct content
2020-11-06 09:49:19 +01:00
5acf35e771 Fix link to point at correct content
Version of runtime.spec was incorrect.

Fixes: https://github.com/containers/podman/issues/8244

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-11-05 19:34:04 -05:00
f1be2dcbfc Merge pull request #8254 from yangm97/adopt-existing-volumes
fix: allow volume creation when the _data directory already exists
2020-11-06 01:28:42 +01:00
14d18deb94 Merge pull request #8246 from containers/dependabot/go_modules/github.com/rootless-containers/rootlesskit-0.11.0
Bump github.com/rootless-containers/rootlesskit from 0.10.1 to 0.11.0
2020-11-06 01:26:50 +01:00
d722cbf9cc Merge pull request #8248 from alvistack/master-linux-amd64
Update nix pin with `make nixpkgs`
2020-11-06 01:25:01 +01:00
ca7dcff5a8 fix: allow volume creation when the _data directory already exists
This restores pre f7e72bc86aff2ff986290f190309deceb7f22099 behavior

Signed-off-by: Yan Minari <yangm97@gmail.com>
2020-11-05 17:09:12 -03:00
71a4676404 rootless container creation settings
when running container creation as rootless on the compatibility layer,
we need to make sure settings are not being done for memory and memory
swappiness.

Signed-off-by: baude <bbaude@redhat.com>
2020-11-05 12:27:48 -06:00
4d013caffc Merge pull request #8249 from marcnuri-forks/fix/doc-typo
[CI:DOCS] fix: podman-system-service doc time is seconds
2020-11-05 16:03:52 +01:00
59a3078853 fix: podman-system-service doc time is seconds
Signed-off-by: Marc Nuri <marc@marcnuri.com>
2020-11-05 14:44:25 +01:00
ab1d3a58d4 Merge pull request #8185 from rhatdan/mount
Add support for mounting external containers
2020-11-05 14:39:16 +01:00
e60739a7ec Bump github.com/rootless-containers/rootlesskit from 0.10.1 to 0.11.0
Bumps [github.com/rootless-containers/rootlesskit](https://github.com/rootless-containers/rootlesskit) from 0.10.1 to 0.11.0.
- [Release notes](https://github.com/rootless-containers/rootlesskit/releases)
- [Commits](https://github.com/rootless-containers/rootlesskit/compare/v0.10.1...v0.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-11-05 08:38:21 -05:00
e7842dcb61 Update nix pin with make nixpkgs
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
2020-11-05 19:44:00 +08:00
cdc50e9d19 Merge pull request #8205 from rhatdan/home
Only use container/storage/pkg/unshare.HomeDir()
2020-11-05 12:08:15 +01:00
3ef721fa1f Merge pull request #8238 from joelsmith/master
Use regex for "pod ps" name filter to match "ps" behavior
2020-11-05 01:54:22 +01:00
3daef2e826 Use /tmp/podman-run-* for backup XDG_RUNTIME_DIR
We need to block systemd from cleaning up this directory
by dropping a /usr/lib/tmpfiles.d/podman.conf file in place.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-11-04 15:32:00 -05:00
5a032acff6 Only use container/storage/pkg/homedir.Get()
We are resolving the homedir of the user in many different
places.  This Patch consolodates them to use container/storage
version.

This PR also fixes a failure mode when the homedir does not
exists, and the user sets a root path.  In this situation
podman should continue to work. Podman does not require a users
homedir to exist in order to run.

Finally the rootlessConfigHomeDirOnce and rootlessRuntimeDirOnce
were broken, because if an error ever happened, they would not be recorded
the second time, and "" would be returned as the path.

Fixes: https://github.com/containers/podman/issues/8131

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-11-04 14:47:54 -05:00
6ca705bf1a Add support for mounting external containers
Continue progress on use of external containers.

This PR adds the ability to mount, umount and list the
storage containers whether they are in libpod or not.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-11-04 13:52:08 -05:00
ab273a9cbd Merge pull request #8074 from cevich/new_f33_images
Cirrus: Use F33 VM image
2020-11-04 19:33:36 +01:00
4fb7378ee4 Merge pull request #8156 from mheon/add_net_aliases_db
Add network aliases for containers to DB
2020-11-04 16:53:49 +01:00
46498331a3 Cirrus: Use F33beta VM image
Includes disk-space increase for all Fedora images to accommodate
the static-build job disk space requirements.  This job substantially
leverages task-cache, which was previously failing to restore early on
in the Cirrus-CI task setup, due to disk-space limitations.

Also simplify .cirrus.yml slightly by removing an unncessary setup
and run directory change step.

Signed-off-by: Chris Evich <cevich@redhat.com>
2020-11-04 09:40:38 -05:00
55a1aecc74 Cirrus: Simplify artifact collection
On several occasions, fatal task failures were observed
during the upload of artifacts after a otherwise successful
testing.  Prior to this commit, most tasks were storing both
logs and binary artifacts.  Avoid possible major inconveniences
of upload failures, by only collecting binary artifacts when
necessary.

Signed-off-by: Chris Evich <cevich@redhat.com>
2020-11-04 09:37:35 -05:00
f37d1d2175 Use ping from alpine
As of this commit, in Fedora 33, without without `CAP_NET_ADMIN` and
`CAP_NET_RAW`, require setting `net.ipv3.ping_group_range` in order for
the `ping` command to work inside a container.  However, not all images
`ping` are created equal.  For whatever reason, the busybox version in
the busybox container image, does not function.  Switch to the Alpine
image's busybox ping, which seems to work fine.

Signed-off-by: Chris Evich <cevich@redhat.com>
2020-11-04 09:37:35 -05:00
303191bf52 Merge pull request #8239 from containers/dependabot/go_modules/github.com/containers/storage-1.23.9
Bump github.com/containers/storage from 1.23.8 to 1.23.9
2020-11-04 14:46:07 +01:00
7699557b5d Merge pull request #8225 from debarshiray/wip/rishi/exec_test-use-containsubstring
Improve error messages from failing tests
2020-11-04 06:18:08 -05:00
dfecb48f61 Merge pull request #8237 from vorburger/patch-1
Add tip re. typical root cause of "Exec format error" to troubleshooting.md
2020-11-04 05:49:43 -05:00
0a0988e6b9 Merge pull request #8229 from vrothberg/pr-template
[CI:DOCS] add a PR template
2020-11-04 05:15:34 -05:00
47a1934631 Bump github.com/containers/storage from 1.23.8 to 1.23.9
Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.23.8 to 1.23.9.
- [Release notes](https://github.com/containers/storage/releases)
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md)
- [Commits](https://github.com/containers/storage/compare/v1.23.8...v1.23.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-11-04 05:09:44 -05:00
9d78203570 add a PR template
Add a pull-request template that points to the section in the
contributing guidelines and to remind users to use the `[CI:DOCS]`
prefix if applicable.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-11-04 11:02:37 +01:00
a47fe37a97 Use regex for "pod ps" name filter to match "ps" behavior
Signed-off-by: Joel Smith <joelsmith@redhat.com>
2020-11-03 15:31:39 -07:00
52dd64596a Merge pull request #8209 from mwhahaha/issue-8208
Change http ConnState actions between new and active
2020-11-03 16:58:43 -05:00
99df7c9336 Add tip re. typical root cause of "Exec format error" to troubleshooting.md
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
2020-11-03 22:54:34 +01:00
844d540d04 Add tests for network aliases
As part of this, we need two new functions, for retrieving all
aliases for a network and removing all aliases for a network,
both required to test.

Also, rework handling for some things the tests discovered were
broken (notably conflicts between container name and existing
aliases).

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-11-03 16:26:42 -05:00
5f897d2abe Merge pull request #8232 from ashley-cui/volfilt
Make volume filters inclusive
2020-11-03 16:25:39 -05:00
55433450c2 Merge pull request #8233 from baude/umohnani8
[CI:DOCS]Add Urvashi to podman OWNERS
2020-11-03 14:44:29 -05:00