Commit Graph

26327 Commits

Author SHA1 Message Date
Philipp Wagner
c5c6e44d7d Fix documentation around checkpoints
Checkpoint archives can now be zstd compressed, and are so by default.
Update the documentation to match.

Signed-off-by: Philipp Wagner <phw@ibm.com>
2025-07-06 17:16:29 +02:00
openshift-merge-bot[bot]
c8272b23a5 Merge pull request #26552 from AgentEpsilon/quadlet-service-unsupported-keys
Quadlet - Error when units define User, Group, or DynamicUser in Serv…
2025-07-04 14:56:04 +00:00
openshift-merge-bot[bot]
fe3e83faa7 Merge pull request #26568 from l0rd/debug-WSL
cirrus: setup WSL logging
2025-07-04 14:33:51 +00:00
Mario Loriedo
4410fcb394 cirrus: setup WSL logging
To debug some of the WSL issues we are seeing try to setup logging,
the script parts are taken from the offical logging script[1].

[1] https://raw.githubusercontent.com/microsoft/WSL/master/diagnostics/collect-wsl-logs.ps1

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2025-07-04 14:28:58 +02:00
openshift-merge-bot[bot]
00c431c3ca Merge pull request #26238 from ArthurWuTW/26102
tmpfs: Add support for noatime mount option
2025-07-04 10:55:02 +00:00
openshift-merge-bot[bot]
98c271985d Merge pull request #26570 from containers/renovate/common-image-and-storage-deps
fix(deps): update github.com/containers/image/v5 digest to 3532547
2025-07-04 10:10:57 +00:00
openshift-merge-bot[bot]
293a2ed3e7 Merge pull request #26564 from mheon/fix_rhel_96776
Fix `podman inspect` to correctly handle log_size_max
2025-07-04 09:45:33 +00:00
renovate[bot]
99e719aec8 fix(deps): update github.com/containers/image/v5 digest to 3532547
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-07-04 02:53:24 +00:00
Matt Heon
13816eb86f Fix podman inspect to correctly handle log_size_max
When generating Conmon's command line, we read containers.conf to
get log_size_max and used it if the container didn't override it.
However, `podman inspect` only reads from the container's own
config, and ignores containers.conf. Unify the way we determine
maximum log size with a single function and use it for both
inspect and containers.conf, and add a test for this behavior.

Fixes https://issues.redhat.com/browse/RHEL-96776

Signed-off-by: Matt Heon <mheon@redhat.com>
2025-07-03 16:04:48 -04:00
Evan Miller
31b4efcaec warn instead of error, lift logic to main.go
Signed-off-by: Evan Miller <miller.evan815@gmail.com>
2025-07-02 18:23:00 -07:00
Mario Loriedo
68e7136536 Enforce wsl.exe UTF-8 encoded output
Currently WSL uses UTF-16 encoded output by default but is planning
to use UTF-8.

See https://github.com/containers/podman/issues/26527

To get ready for the change we are enforcing UTF-8 encoded output by
setting the environment variable `WSL_UTF8=1` and by updating the
code that transfomed wsl output from UTF-16 to UTF-8.

Fixes https://github.com/containers/podman/issues/26527

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2025-07-02 20:18:52 +00:00
Mario Loriedo
9fbe2fffe9 WSL commands execution refactoring
Introduced a new function to encapsulate the code to execute WSL
commands.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2025-07-02 20:18:52 +00:00
openshift-merge-bot[bot]
8234879708 Merge pull request #26559 from zeha/patch-1
Clarify meaning of --syslog
2025-07-02 17:50:26 +00:00
Chris Hofstaedtler
0f403ac43e Clarify meaning of --syslog
Given container logs end up in syslog by default, somewhat-clarify that `--syslog` is about podman logs, not container logs.

Signed-off-by: Chris Hofstaedtler <zeha@users.noreply.github.com>
2025-07-02 18:32:52 +02:00
openshift-merge-bot[bot]
2a6f190e8f Merge pull request #26540 from cevich/add_release_test
Add conditional release-checking system test
2025-07-02 12:34:47 +00:00
openshift-merge-bot[bot]
cb2de88d13 Merge pull request #26551 from containers/renovate/common-image-and-storage-deps
fix(deps): update common, image, and storage deps
2025-07-02 11:58:05 +00:00
Evan Miller
4b1f7bcb9a Quadlet - Error when units define User, Group, or DynamicUser in Service group
Fixes: #26543

Signed-off-by: Evan Miller <miller.evan815@gmail.com>
2025-07-02 00:34:46 -07:00
renovate[bot]
5391721aa3 fix(deps): update common, image, and storage deps
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-07-02 03:28:11 +00:00
openshift-merge-bot[bot]
5d48c0b299 Merge pull request #26541 from Luap99/grpcnotrace
add grpcnotrace build tag to reduce binary size
2025-07-01 19:27:55 +00:00
openshift-merge-bot[bot]
72393c1c53 Merge pull request #26522 from ygalblum/quadlet-pod-service-environment
Quadlet - Do not override existing Environment in Service group for Pod units
2025-07-01 19:25:06 +00:00
openshift-merge-bot[bot]
313c48872f Merge pull request #26537 from Luap99/update-CI-img
update CI images 2025-06-27
2025-07-01 19:22:15 +00:00
openshift-merge-bot[bot]
c9f6feb6d5 Merge pull request #26545 from containers/renovate/github.com-shirou-gopsutil-v4-4.x
fix(deps): update module github.com/shirou/gopsutil/v4 to v4.25.6
2025-07-01 16:26:26 +00:00
openshift-merge-bot[bot]
6355a15082 Merge pull request #25922 from jakecorrenti/krunkit-cmdline
machine: enable nested virt on libkrun by default
2025-07-01 13:39:19 +00:00
renovate[bot]
10a5f9715b fix(deps): update module github.com/shirou/gopsutil/v4 to v4.25.6
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-07-01 07:13:01 +00:00
Paul Holzinger
d8599658ff Makefile: add Makefile to sources
During my binary size reduce experiments I often switch build tags
around but make binaries does not recompile in these cases.
It is annoying to always do touch cmd/podman/main.go so let's add it to
the SOURCES instead so the Makefile will recompile on changes.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-30 19:39:45 +02:00
Paul Holzinger
145fb74dbf rpm: add grpcnotrace build tag
Like done in the Makefile.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-30 19:39:45 +02:00
Paul Holzinger
3d453572a9 Makefile: add grpcnotrace build tag
The build tag was added to remove the "golang.org/x/net/trace"
dependency[1]. So let's use that.
With that we reoduce the binary size by 432KB.

[1] https://github.com/grpc/grpc-go/pull/6954

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-30 19:22:08 +02:00
Chris Evich
62bfeb5d88 Add conditional release-checking system test
Unfortunately on a number of occasions, Podman has been released
officially with a `-dev` suffix in the version number.  Assist in
catching this mistake at release time by the addition of a simple
conditional test.  Note that it must be positively enabled by a
magic env. var. before executing the system tests.

Also (thanks to @lsm5) update the TMT test to trigger the new
condition for future Fedora releases.

Signed-off-by: Chris Evich <cevich@redhat.com>
2025-06-30 11:28:32 -04:00
openshift-merge-bot[bot]
87d88c3b09 Merge pull request #26432 from stefwalter/dont-html-escape-json
api: Don't HTML escape application/json responses
2025-06-30 14:47:55 +00:00
openshift-merge-bot[bot]
43b74b1754 Merge pull request #26322 from NotSoFancyName/issue-26247
quadlet: handle generate environment params that inherit from host
2025-06-30 11:44:33 +00:00
Stef Walter
fed198eaf9 api: Don't HTML escape application/json responses
An HTTP response with Content-Type application/json does not need
to be HTML escaped. Doing this causes encoding issues in the Podman
REST API output as seen in the issue:

Fixes #17769

Remove the HTML escaping from Content-Type: application/json responses.

Signed-off-by: Stef Walter <stef@thewalter.net>
Co-Authored-By: Claude <noreply@anthropic.com>
2025-06-30 12:54:19 +02:00
openshift-merge-bot[bot]
2a399c5c90 Merge pull request #26532 from containers/renovate/golangci-golangci-lint-2.x
chore(deps): update dependency golangci/golangci-lint to v2.2.1
2025-06-30 10:40:42 +00:00
openshift-merge-bot[bot]
2673ca264b Merge pull request #26525 from Luap99/vendor
vendor: update docker v28.3.0 and c/{common,image,storage} to main
2025-06-30 10:26:55 +00:00
Paul Holzinger
ffbb0ed7b0 update CI images 2025-06-27
from https://github.com/containers/automation_images/pull/408

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-30 12:05:56 +02:00
renovate[bot]
92a6298729 chore(deps): update dependency golangci/golangci-lint to v2.2.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-06-30 09:46:18 +00:00
openshift-merge-bot[bot]
7321c16752 Merge pull request #26508 from actionmancan/update-neil-smith-github-username
Update Neil Smith's GitHub username in MAINTAINERS.md
2025-06-29 22:26:47 +00:00
Paul Holzinger
38ed6c6589 vendor: update c/{common,image,storage} to main
Mainly to pull in the rekor removal from c/image which removes a bunch
of dependencies.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-27 16:35:40 +02:00
Paul Holzinger
5786d5f846 fix new lint errors from the docker update
Some new deprecated fields, we still have to set them since clients
might still use them.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-27 16:35:40 +02:00
Ygal Blum
f1a1948b23 Quadlet - Do not override existing Environment in Service group for Pod units
Fixes: #26521

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2025-06-27 09:56:43 -04:00
Paul Holzinger
cf87278e66 vendor: update docker to v28.3.0
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-27 15:46:38 +02:00
openshift-merge-bot[bot]
1a3b35673d Merge pull request #26461 from Luap99/deadcode
remove deadcode
2025-06-26 19:36:02 +00:00
openshift-merge-bot[bot]
3000b1e239 Merge pull request #26512 from Luap99/machine-tls-cert
pkg/machine/e2e: add CVE-2025-6032 regression test
2025-06-26 17:40:10 +00:00
Paul Holzinger
570fbf0078 pkg/domain/infra/tunnel: ignore error from removeContainer()
All callers ignore the error anyways so no reason to return it as the
function itself already logs it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-26 19:37:17 +02:00
Paul Holzinger
247c1dfb53 libpod: remove deadcode
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-26 19:37:16 +02:00
Paul Holzinger
09caf60687 remove test/framework/framework.go
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-26 19:37:16 +02:00
Paul Holzinger
d2291d7f1a pkg/util: remove deadcode
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-26 19:37:16 +02:00
Paul Holzinger
552e38ec6d remove pkg/util/camelcase
It is not used here.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-26 19:37:16 +02:00
Paul Holzinger
6893ecc469 pkg/rootless: remove deadcode
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-26 19:37:16 +02:00
Paul Holzinger
880808dfb9 pkg/parallel: remove deadcode
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-26 19:37:15 +02:00
Paul Holzinger
6bfd28bc6f pkg/namespaces: remove deadcode
These types are not used.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-26 19:37:15 +02:00