opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-11-29 01:28:22 +08:00
Code Issues Packages Projects Releases Wiki Activity
26,204 Commits 57 Branches 257 Tags
b63a210dd977630e2335acb92a60bf84251df8c7
Commit Graph

81 Commits

Author SHA1 Message Date
Jan Rodák
2b848cca36 Fix copyUIDGID parameter inversion in Docker compat API 
Docker API's copyUIDGID=true means "preserve UID/GID from archive"
but Podman's internal Chown=true means "chown to container user".
This caused Docker SDK clients to have files incorrectly chowned
to root:root instead of preserving the archive's UID/GID.

Fixes: https://github.com/containers/podman/issues/27332
Fixes: https://issues.redhat.com/browse/RUN-3643

Signed-off-by: Jan Rodák <hony.com@seznam.cz>
 2025-10-27 12:47:49 +01:00
rcmadhankumar
bf7dcd5619 Fix: Remove appending rw as the default mount option 
The backstory for this is that runc 1.2 (opencontainers/runc#3967)
fixed a long-standing bug in our mount flag handling (a bug that crun
still has). Before runc 1.2, when dealing with locked mount flags that
user namespaced containers cannot clear, trying to explicitly clearing
locked flags (like rw clearing MS_RDONLY) would silently ignore the rw
flag in most cases and would result in a read-only mount. This is
obviously not what the user expects.

What runc 1.2 did is that it made it so that passing clearing flags
like rw would always result in an attempt to clear the flag (which was
not the case before), and would (in all cases) explicitly return an
error if we try to clear locking flags. (This also let us finally fix a
bunch of other long-standing issues with locked mount flags causing
seemingly spurious errors).

The problem is that podman sets rw on all mounts by default (even if
the user doesn't specify anything). This is actually a no-op in
runc 1.1 and crun because of a bug in how clearing flags were handled
(rw is the absence of MS_RDONLY but until runc 1.2 we didn't correctly
track clearing flags like that, meaning that rw would literally be
handled as if it were not set at all by users) but in runc 1.2 leads to
unfortunate breakages and a subtle change in behaviour (before, a ro
mount being bind-mounted into a container would also be ro -- though
due to the above bug even setting rw explicitly would result in ro in
most cases -- but with runc 1.2 the mount will always be rw even if
the user didn't explicitly request it which most users would find
surprising). By the way, this "always set rw" behaviour is a departure
from Docker and it is not necesssary.

Signed-off-by: rcmadhankumar <madhankumar.chellamuthu@suse.com>
 2025-04-23 17:18:03 +05:30
openshift-merge-bot[bot]
52fe111b51 Merge pull request #23562 from cevich/rm_docker_py_dupe 
De-duplicate docker-py testing
 2024-08-12 12:05:41 +00:00
Chris Evich
a48cd241ad Drop APIv2 CNI configuration 
**Depends on PR 23538**

CNI is no longer needed/supported.

Signed-off-by: Chris Evich <cevich@redhat.com>
 2024-08-09 10:20:38 -04:00
Chris Evich
dcdb5408de De-duplicate docker-py testing 
Previously there were two CI tasks that ended up both testing docker-py
compatibility.  Remove the duplicate from the `localapiv2-python` make
target, and symlink the identical requirements file.

Signed-off-by: Chris Evich <cevich@redhat.com>
 2024-08-09 10:13:02 -04:00
Chris Evich
7936809f75 Reduce python APIv2 test net dependency 
Previously these tests pulled some test images from quay, opening them up
to networking-flake induced failures.  As has already been done for
other tests, update to utilize the locally running registry server.

Also: Add `test/python/**` into the apiv2 task conditions as referenced
by the `Makefile` `localapiv2-python` target.

Signed-off-by: Chris Evich <cevich@redhat.com>
 2024-08-08 10:40:22 -04:00
renovate[bot]
8b5b9d0bb5 Update dependency setuptools to v72 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-07-29 15:45:43 +00:00
renovate[bot]
a493a584c0 chore(deps): update dependency setuptools to ~=71.1.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-07-22 16:43:28 +00:00
renovate[bot]
ed71000e6d chore(deps): update dependency setuptools to v71 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-07-17 22:13:43 +00:00
renovate[bot]
4487f17a47 chore(deps): update dependency setuptools to ~=70.3.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-07-09 18:53:42 +00:00
renovate[bot]
b6f151ad1c chore(deps): update dependency setuptools to ~=70.2.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-07-02 18:40:18 +00:00
renovate[bot]
83549ba11f chore(deps): update dependency setuptools to ~=70.1.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-06-19 13:37:57 +00:00
renovate[bot]
b146f9126a chore(deps): update dependency requests to ~=2.32.3 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-05-31 13:12:50 +00:00
renovate[bot]
1766a1a24b chore(deps): update dependency setuptools to v70 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-05-21 11:48:22 +00:00
renovate[bot]
60b5488308 Update dependency pytest to v8.1.2 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-04-26 18:14:28 +00:00
renovate[bot]
0e291ce760 chore(deps): update dependency setuptools to ~=69.5.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-04-13 17:31:33 +00:00
renovate[bot]
26f866b5df chore(deps): update dependency pytest to v8 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-04-10 12:39:09 +00:00
renovate[bot]
beb4fd1b4a Update dependency requests-mock to ~=1.12.1 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-04-04 18:37:25 +00:00
renovate[bot]
d5e0ecc619 Update dependency setuptools to ~=69.2.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-03-14 02:36:50 +00:00
renovate[bot]
542883b9ba chore(deps): update dependency python-dateutil to ~=2.9.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-03-01 14:45:10 +00:00
renovate[bot]
52fd284fd4 Update dependency pytest to v7.4.4 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-02-29 18:42:48 +00:00
Florian Bezannier
1de94dceb5 ci: fix module not found 
Signed-off-by: Florian Bezannier <florian.bezannier@hotmail.fr>
 2024-02-28 19:45:03 +01:00
Florian Bezannier
facad62afe tests: fix after make podman inspect cmd return compatible with Docker API v1.44 
Signed-off-by: Florian Bezannier <florian.bezannier@hotmail.fr>
 2024-02-28 19:45:03 +01:00
Florian Bezannier
2cd72c272f tests: add docker api compatibility test 
Signed-off-by: Florian Bezannier <florian.bezannier@hotmail.fr>
 2024-02-28 19:45:03 +01:00
renovate[bot]
45b701b125 chore(deps): update dependency setuptools to ~=69.1.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-02-13 19:38:50 +00:00
renovate[bot]
e75fbe54e2 Update dependency setuptools to v69 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2023-11-20 18:13:43 +00:00
renovate[bot]
1211518e82 chore(deps): update dependency setuptools to ~=68.2.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2023-09-07 02:07:32 +00:00
renovate[bot]
6a3f09e8a7 Update dependency setuptools to ~=68.1.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2023-08-15 20:35:31 +00:00
Matej Vasek
f33b01b731 fix: Docker API compatible bool deserialization 
In Docker anything but "", "0", "no", "false", "none" (ignoring case) is considered to be true.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
 2023-08-14 15:09:14 +02:00
renovate[bot]
f8f337501b chore(deps): update dependency setuptools to v68 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2023-06-19 18:59:03 +00:00
renovate[bot]
44ec044c49 chore(deps): update dependency requests-mock to ~=1.11.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2023-06-08 17:01:24 +00:00
renovate[bot]
9969374b6b chore(deps): update dependency requests to ~=2.31.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-05-22 15:55:35 +00:00
renovate[bot]
8fbcf8bce8 chore(deps): update dependency setuptools to ~=67.8.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-05-19 22:15:28 +00:00
renovate[bot]
1bf057e8cf chore(deps): update dependency docker to ~=6.1.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-05-05 19:24:45 +00:00
renovate[bot]
773b457048 chore(deps): update dependency requests to ~=2.30.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-05-04 16:51:16 +00:00
OpenShift Merge Robot
7430d9d777 Merge pull request #18364 from containers/renovate/requests-2.x 
chore(deps): update dependency requests to ~=2.29.0
 2023-04-27 07:31:50 -04:00
Daniel J Walsh
edaf3b4d5e Add sha256: to images history id for docker compatibility 
Fixes: https://github.com/containers/podman/issues/17762

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
 2023-04-26 14:38:07 -04:00
renovate[bot]
ba45863753 chore(deps): update dependency requests to ~=2.29.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-04-26 16:38:23 +00:00
renovate[bot]
77f86f48ef chore(deps): update dependency setuptools to ~=67.7.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-04-20 15:40:33 +00:00
renovate[bot]
8125bab9b8 chore(deps): update dependency setuptools to v67 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-04-19 08:46:21 +00:00
OpenShift Merge Robot
c8eb15114b Merge pull request #17854 from matejvasek/enable-test-test_wait_next_exit 
test: enable test_wait_next_exit
 2023-04-12 14:36:50 -04:00
renovate[bot]
f544971b76 chore(deps): update dependency docker to v6 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-04-12 14:30:01 +00:00
Matej Vasek
d28656403e test: enable test_wait_next_exit 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
 2023-04-12 14:50:13 +02:00
renovate[bot]
f312c85335 Update dependency PyYAML to v6 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-04-12 12:09:04 +00:00
renovate[bot]
176c329f95 Update dependency requests-mock to ~=1.10.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-04-12 09:19:18 +00:00
renovate[bot]
b75ee05d3b Update dependency requests to ~=2.28.2 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-04-12 07:14:52 +00:00
Erik Sjölund
a5ca732256 Fix typos 
Software version used
https://github.com/crate-ci/typos/releases/tag/v1.13.10

The binary was downloaded from
https://github.com/crate-ci/typos/releases/download/v1.13.10/typos-v1.13.10-x86_64-unknown-linux-musl.tar.gz

Command that was run:

typos --write-changes docs cmd cni contrib dependencies docs hack libpod pkg utils

False positives were manually removed.
A few marshaling/existant typos were manually fixed.

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
 2023-02-11 18:23:24 +01:00
Matej Vasek
80405a2a5f test: added test from wait endpoint with to long label 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
 2022-12-14 16:28:11 +01:00
Erik Sjölund
a1b32866cc Fix language. Mostly spelling a -> an 
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
 2022-11-20 19:41:06 +01:00
Jake Torrance
85f4d37173 Make sure we can build and read each line of docker py's api client 
Signed-off-by: Jake Torrance <jaket1234@hotmail.com>
 2022-11-06 10:30:18 +00:00