f95b0995e5
remove pkg/registries
...
Pull the trigger on the `pkg/registries` package which acted as a proxy
for `c/image/pkg/sysregistriesv2`. Callers should be using the packages
from c/image directly, if needed at all.
Also make use of libimage's SystemContext() method which returns a copy
of a system context, further reducing the risk of unintentionally
altering global data.
[NO TESTS NEEDED]
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-06-25 09:56:21 +02:00
5fc622f945
create: support images with invalid platform
...
Much to my regret, there is a number of images in the wild with invalid
platforms breaking the platform checks in libimage that want to make
sure that a local image is matching the expected platform.
Imagine a `podman run --arch=arm64 fedora` with a local amd64 fedora
image. We really shouldn't use the local one in this case and pull down
the arm64 one.
The strict platform checks in libimage in combination with invalid
platforms in images surfaced in Podman being able to pull an image but
failing to look it up in subsequent presence checks. A `podman run`
would hence pull such an image but fail to create the container.
Support images with invalid platforms by vendoring the latest HEAD from
containers/common. Also remove the partially implemented pull-policy
logic from Podman and let libimage handle that entirely. However,
whenever --arch, --os or --platform are specified, the pull policy will
be forced to "newer". This way, we pessimistically assume that the
local image has an invalid platform and we reach out to the registry.
If there's a newer image (i.e., one with a different digest), we'll pull
it down.
Please note that most of the logic has either already been implemented
in libimage or been moved down which allows for removing some clutter
from Podman.
[NO TESTS NEEDED] since c/common has new tests. Podman can rely on the
existing tests.
Fixes : #10648
Fixes : #10682
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-06-23 15:42:13 +02:00
e014608539
Do not use inotify for OCICNI
...
Podman does not need to watch the cni config directory. If a network is
not found in the cache, OCICNI will reload the networks anyway and thus
even podman system service should work as expected.
Also include a change to not mount a "new" /var by default in the
rootless cni ns, instead try to use /var/lib/cni first and then the
parent dir. This allows users to store cni configs under /var/... which
is the case for the CI compose test.
[NO TESTS NEEDED]
Fixes #10686
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2021-06-22 16:00:47 +02:00
ed511d27d7
Merge pull request #10719 from containers/dependabot/go_modules/k8s.io/api-0.21.2
...
Bump k8s.io/api from 0.21.1 to 0.21.2
2021-06-22 06:31:07 -04:00
9ec4d04592
Merge pull request #10723 from rhatdan/tmpdir
...
fix systemcontext to use correct TMPDIR
2021-06-21 03:50:31 -04:00
4cf3861168
Merge pull request #10718 from containers/dependabot/go_modules/github.com/containers/storage-1.32.3
...
Bump github.com/containers/storage from 1.32.2 to 1.32.3
2021-06-20 05:59:29 -04:00
9cc3473b58
Bump k8s.io/api from 0.21.1 to 0.21.2
...
Bumps [k8s.io/api](https://github.com/kubernetes/api ) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/kubernetes/api/releases )
- [Commits](https://github.com/kubernetes/api/compare/v0.21.1...v0.21.2 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-20 09:50:04 +00:00
7864108ff1
fix systemcontext to use correct TMPDIR
...
Users are complaining about read/only /var/tmp failing
even if TMPDIR=/tmp is set.
This PR Fixes: https://github.com/containers/podman/issues/10698
[NO TESTS NEEDED] No way to test this.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-06-18 19:53:24 -04:00
b56d6c6460
Bump github.com/containers/storage from 1.32.2 to 1.32.3
...
Bumps [github.com/containers/storage](https://github.com/containers/storage ) from 1.32.2 to 1.32.3.
- [Release notes](https://github.com/containers/storage/releases )
- [Changelog](https://github.com/containers/storage/blob/main/docs/containers-storage-changes.md )
- [Commits](https://github.com/containers/storage/compare/v1.32.2...v1.32.3 )
---
updated-dependencies:
- dependency-name: github.com/containers/storage
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-18 14:46:38 +00:00
d398230853
Bump k8s.io/apimachinery from 0.21.1 to 0.21.2
...
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/kubernetes/apimachinery/releases )
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.21.1...v0.21.2 )
---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-18 14:46:21 +00:00
b6662eed3f
Vendor in containers/common v0.40.0
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-06-17 14:59:42 -04:00
b5890fc86b
Bump github.com/containers/storage from 1.32.1 to 1.32.2
...
Bumps [github.com/containers/storage](https://github.com/containers/storage ) from 1.32.1 to 1.32.2.
- [Release notes](https://github.com/containers/storage/releases )
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md )
- [Commits](https://github.com/containers/storage/compare/v1.32.1...v1.32.2 )
---
updated-dependencies:
- dependency-name: github.com/containers/storage
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-10 06:28:23 +00:00
346c7fda69
Bump github.com/containers/buildah from 1.21.0 to 1.21.1
...
Bumps [github.com/containers/buildah](https://github.com/containers/buildah ) from 1.21.0 to 1.21.1.
- [Release notes](https://github.com/containers/buildah/releases )
- [Changelog](https://github.com/containers/buildah/blob/v1.21.1/CHANGELOG.md )
- [Commits](https://github.com/containers/buildah/compare/v1.21.0...v1.21.1 )
---
updated-dependencies:
- dependency-name: github.com/containers/buildah
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-08 12:36:15 +00:00
cbcf0a1dd7
Merge pull request #10545 from containers/dependabot/go_modules/go.etcd.io/bbolt-1.3.6
...
Bump go.etcd.io/bbolt from 1.3.5 to 1.3.6
2021-06-03 17:58:24 +02:00
0f8ec8e366
Merge pull request #10543 from containers/dependabot/go_modules/github.com/opencontainers/selinux-1.8.2
...
Bump github.com/opencontainers/selinux from 1.8.1 to 1.8.2
2021-06-03 17:57:25 +02:00
735470ff23
Bump go.etcd.io/bbolt from 1.3.5 to 1.3.6
...
Bumps [go.etcd.io/bbolt](https://github.com/etcd-io/bbolt ) from 1.3.5 to 1.3.6.
- [Release notes](https://github.com/etcd-io/bbolt/releases )
- [Commits](https://github.com/etcd-io/bbolt/compare/v1.3.5...v1.3.6 )
---
updated-dependencies:
- dependency-name: go.etcd.io/bbolt
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-03 09:34:51 +00:00
48ea142ca5
Bump github.com/docker/docker
...
Bumps [github.com/docker/docker](https://github.com/docker/docker ) from 20.10.6+incompatible to 20.10.7+incompatible.
- [Release notes](https://github.com/docker/docker/releases )
- [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/docker/docker/compare/v20.10.6...v20.10.7 )
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-03 09:34:37 +00:00
b36278c3ef
Bump github.com/opencontainers/selinux from 1.8.1 to 1.8.2
...
Bumps [github.com/opencontainers/selinux](https://github.com/opencontainers/selinux ) from 1.8.1 to 1.8.2.
- [Release notes](https://github.com/opencontainers/selinux/releases )
- [Commits](https://github.com/opencontainers/selinux/compare/v1.8.1...v1.8.2 )
---
updated-dependencies:
- dependency-name: github.com/opencontainers/selinux
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-03 09:34:20 +00:00
366016fa85
Bump github.com/onsi/ginkgo from 1.16.3 to 1.16.4
...
Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo ) from 1.16.3 to 1.16.4.
- [Release notes](https://github.com/onsi/ginkgo/releases )
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/ginkgo/compare/v1.16.3...v1.16.4 )
---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-03 08:01:15 +00:00
24b364a230
Merge pull request #10486 from vrothberg/tag-digest-support
...
support tag@digest notation
2021-06-01 22:38:03 +02:00
7dd463bad1
Merge pull request #10504 from containers/dependabot/go_modules/github.com/onsi/ginkgo-1.16.3
...
Bump github.com/onsi/ginkgo from 1.16.2 to 1.16.3
2021-06-01 11:11:30 +02:00
d657a070d3
Bump github.com/uber/jaeger-client-go
...
Bumps [github.com/uber/jaeger-client-go](https://github.com/uber/jaeger-client-go ) from 2.28.0+incompatible to 2.29.1+incompatible.
- [Release notes](https://github.com/uber/jaeger-client-go/releases )
- [Changelog](https://github.com/jaegertracing/jaeger-client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/uber/jaeger-client-go/compare/v2.28.0...v2.29.1 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-31 12:55:49 +00:00
761466dcab
Bump github.com/onsi/ginkgo from 1.16.2 to 1.16.3
...
Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo ) from 1.16.2 to 1.16.3.
- [Release notes](https://github.com/onsi/ginkgo/releases )
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/ginkgo/compare/v1.16.2...v1.16.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-05-31 14:46:09 +02:00
fb4a0c572e
support tag@digest notation
...
Vendor in the latest HEAd of containers/common to implicitly support the
tag@digest notation for images. To remain compatible with Docker, the
tag will be stripped off the image reference and is entirely ignored.
Fixes : #6721
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-05-31 14:38:43 +02:00
c9609d820b
Vendor in containers/storage v1.32.1
...
Theoretically this should fix the aweful flake we have
been suffering with.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-05-27 12:34:26 -04:00
61167834f2
Bump github.com/onsi/gomega from 1.12.0 to 1.13.0
...
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega ) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/onsi/gomega/releases )
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/gomega/compare/v1.12.0...v1.13.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-27 07:02:40 +00:00
568e911b84
Bump github.com/containers/common from 0.38.4 to 0.39.0
...
Bumps [github.com/containers/common](https://github.com/containers/common ) from 0.38.4 to 0.39.0.
- [Release notes](https://github.com/containers/common/releases )
- [Commits](https://github.com/containers/common/compare/v0.38.4...v0.39.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-26 06:27:00 +00:00
94665bdf01
Bump github.com/containers/storage from 1.31.1 to 1.31.2
...
Bumps [github.com/containers/storage](https://github.com/containers/storage ) from 1.31.1 to 1.31.2.
- [Release notes](https://github.com/containers/storage/releases )
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md )
- [Commits](https://github.com/containers/storage/compare/v1.31.1...v1.31.2 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-21 07:25:04 +00:00
c553181fd0
Vendor in containers/buildah v1.21.0
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-05-20 09:51:36 -04:00
7bcec8697f
Merge pull request #10219 from vrothberg/image-events
...
add libimage events
2021-05-20 09:49:22 -04:00
8352e5bc3b
add libimage events
...
libimage now supports events which `libpod.Runtime` now uses for image
events.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-05-20 12:33:09 +02:00
26652111b8
Bump github.com/opencontainers/runc from 1.0.0-rc94 to 1.0.0-rc95
...
Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc ) from 1.0.0-rc94 to 1.0.0-rc95.
- [Release notes](https://github.com/opencontainers/runc/releases )
- [Commits](https://github.com/opencontainers/runc/compare/v1.0.0-rc94...v1.0.0-rc95 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-20 10:10:22 +00:00
898a8ad285
update c/common
...
Update containers common to the latest HEAD. Some bug fixes in libimage
forced us to have a clearer separation between ordinary images and
manifest lists. Hence, when looking up manifest lists without recursing
into any of their instances, we need to use `LookupManifestList()`.
Also account for some other changes in c/common (e.g., the changed order
in the security labels).
Further vendor the latest HEAD from Buildah which is required to get the
bud tests to pass.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-05-20 10:21:27 +02:00
44c4937177
Bump k8s.io/api from 0.21.0 to 0.21.1
...
Bumps [k8s.io/api](https://github.com/kubernetes/api ) from 0.21.0 to 0.21.1.
- [Release notes](https://github.com/kubernetes/api/releases )
- [Commits](https://github.com/kubernetes/api/compare/v0.21.0...v0.21.1 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-19 11:59:01 +00:00
4002589546
Merge pull request #10396 from containers/dependabot/go_modules/github.com/vbauerster/mpb/v6-6.0.4
...
Bump github.com/vbauerster/mpb/v6 from 6.0.3 to 6.0.4
2021-05-19 07:41:58 -04:00
af748b94ed
Bump k8s.io/apimachinery from 0.21.0 to 0.21.1
...
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) from 0.21.0 to 0.21.1.
- [Release notes](https://github.com/kubernetes/apimachinery/releases )
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.21.0...v0.21.1 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-19 06:51:21 +00:00
6b187e4458
Bump github.com/vbauerster/mpb/v6 from 6.0.3 to 6.0.4
...
Bumps [github.com/vbauerster/mpb/v6](https://github.com/vbauerster/mpb ) from 6.0.3 to 6.0.4.
- [Release notes](https://github.com/vbauerster/mpb/releases )
- [Commits](https://github.com/vbauerster/mpb/compare/v6.0.3...v6.0.4 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-19 06:50:18 +00:00
b9b386075b
make vendor
...
Signed-off-by: Ivan Font <ifont@redhat.com>
2021-05-13 10:07:23 -07:00
4dc52f61cc
Merge pull request #10316 from containers/dependabot/go_modules/github.com/containers/storage-1.30.3
...
Bump github.com/containers/storage from 1.30.2 to 1.30.3
2021-05-12 20:53:08 -04:00
d32863bbb4
podman image tree: restore previous behavior
...
The initial version of libimage changed the order of layers which has
now been restored to remain backwards compatible.
Further changes:
* Fix a bug in the journald logging which requires to strip trailing
new lines from the message. The system tests did not pass due to
empty new lines. Triggered by changing the default logger to
journald in containers/common.
* Fix another bug in the journald logging which embedded the container
ID inside the message rather than the specifid field. That surfaced
in a preceeding whitespace of each log line which broke the system
tests.
* Alter the system tests to make sure that the k8s-file and the
journald logging drivers are executed.
* A number of e2e tests have been changed to force the k8s-file driver
to make them pass when running inside a root container.
* Increase the timeout in a kill test which seems to take longer now.
Reasons are unknown. Tests passed earlier and no signal-related
changes happend. It may be CI VM flake since some system tests but
other flaked.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-05-12 17:56:59 +02:00
eccd03f3c4
Bump github.com/containers/storage from 1.30.2 to 1.30.3
...
Bumps [github.com/containers/storage](https://github.com/containers/storage ) from 1.30.2 to 1.30.3.
- [Release notes](https://github.com/containers/storage/releases )
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md )
- [Commits](https://github.com/containers/storage/compare/v1.30.2...v1.30.3 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-12 06:22:36 +00:00
30544f225e
fix restart always with slirp4netns
...
When a container is automatically restarted due its restart policy and
the container used the slirp4netns netmode, the slirp4netns process
died. This caused the container to lose network connectivity.
To fix this we have to start a new slirp4netns process.
Fixes #8047
Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-11 22:37:32 +02:00
8dcd5b893f
Merge pull request #10304 from containers/dependabot/go_modules/github.com/opencontainers/runc-1.0.0-rc94
...
Bump github.com/opencontainers/runc from 1.0.0-rc93 to 1.0.0-rc94
2021-05-11 10:36:54 -04:00
d71672c57b
Bump github.com/opencontainers/runc from 1.0.0-rc93 to 1.0.0-rc94
...
Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc ) from 1.0.0-rc93 to 1.0.0-rc94.
- [Release notes](https://github.com/opencontainers/runc/releases )
- [Commits](https://github.com/opencontainers/runc/compare/v1.0.0-rc93...v1.0.0-rc94 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-11 06:19:24 +00:00
0c05919e90
Bump github.com/coreos/go-systemd/v22 from 22.3.1 to 22.3.2
...
Bumps [github.com/coreos/go-systemd/v22](https://github.com/coreos/go-systemd ) from 22.3.1 to 22.3.2.
- [Release notes](https://github.com/coreos/go-systemd/releases )
- [Commits](https://github.com/coreos/go-systemd/compare/v22.3.1...v22.3.2 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-11 06:19:04 +00:00
d2f7d5cbab
Bump github.com/containers/storage from 1.30.1 to 1.30.2
...
Bumps [github.com/containers/storage](https://github.com/containers/storage ) from 1.30.1 to 1.30.2.
- [Release notes](https://github.com/containers/storage/releases )
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md )
- [Commits](https://github.com/containers/storage/compare/v1.30.1...v1.30.2 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-10 10:16:27 +00:00
a3fb15dffb
Bump github.com/docker/docker
...
Bumps [github.com/docker/docker](https://github.com/docker/docker ) from 20.10.3-0.20210216175712-646072ed6524+incompatible to 20.10.6+incompatible.
- [Release notes](https://github.com/docker/docker/releases )
- [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/docker/docker/commits/v20.10.6 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-07 08:04:42 +00:00
3de369fd69
Bump github.com/onsi/gomega from 1.11.0 to 1.12.0
...
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega ) from 1.11.0 to 1.12.0.
- [Release notes](https://github.com/onsi/gomega/releases )
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/gomega/compare/v1.11.0...v1.12.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-06 08:07:07 +00:00
7b50af42c3
Merge pull request #10214 from containers/dependabot/go_modules/github.com/containers/image/v5-5.12.0
...
Bump github.com/containers/image/v5 from 5.11.1 to 5.12.0
2021-05-05 14:05:11 -04:00
4b427df80c
Bump github.com/onsi/ginkgo from 1.16.1 to 1.16.2
...
Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo ) from 1.16.1 to 1.16.2.
- [Release notes](https://github.com/onsi/ginkgo/releases )
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/ginkgo/compare/v1.16.1...v1.16.2 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-05 13:35:02 +00:00
