a8092a105b
Rework port code
...
Rework port code for generalized clean up and to address
issue #269 where additional portbindings between host
and containers we being introduced by error.
Signed-off-by: baude <bbaude@redhat.com>
Closes : #308
Approved by: mheon
2018-02-09 16:13:20 +00:00
fa9658cbfa
podman logs: fix tailing
...
Fix issues with tailing of container logs as described
in issue #16 . Also add in the ability to use a duration or
known time stamp formats for the --since flag.
Signed-off-by: baude <bbaude@redhat.com>
Closes : #317
Approved by: mheon
2018-02-09 15:27:52 +00:00
75914199f3
Fix further style issues
...
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
c8e296c83e
Allow removing pods with running containers if --force is given
...
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
9e6855f348
Address style issues in in_memory_state
...
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
86d549f2cd
Fix gofmt and lint
...
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
19840e0b3d
Finish unit tests for pods
...
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
cb28a1d284
Fix bugs identified by unit tests
...
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
4bc9a6d633
HACK: monkey-patch gosqlite3 to rollback unconditionally after tx error
...
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
4ecebf20b4
Rework state tests to avoid boilerplate. Begin adding pod tests.
...
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
0920e8de5a
Unify Pod and Container ID and Name registries for in-memory state
...
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
044139dca9
Remove read-only from DB, it's in the spec
...
Don't need to store it separately
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
6b7b4b03a8
Add pod removal code
...
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
cfd6da22df
Implement pod operations in SQL state
...
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
6214be07c2
Tear out pod containers map. Instead rely on state
...
This ensures that there is only one canonical place where
containers in a pod are stored, in the state itself.
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
Closes : #268
Approved by: rhatdan
2018-02-09 15:01:34 +00:00
bf981fc873
Update pause tests per QE suggestions and move to gingko
...
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
Closes : #285
Approved by: mheon
2018-02-08 22:14:36 +00:00
9e3a5da69d
Add some global options to build
...
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
Closes : #312
Approved by: mheon
2018-02-08 20:17:17 +00:00
250ec9adc2
Merge pull request #316 from baude/copr3
...
Spec file changes for COPR
2018-02-08 13:53:45 -06:00
401953ed82
Spec file changes for COPR
...
COPR needed slight tweaks to our spec file.
Signed-off-by: baude <bbaude@redhat.com>
2018-02-08 13:52:41 -06:00
7ef886fe34
Merge pull request #315 from baude/copr2
...
COPR setup
2018-02-08 13:40:03 -06:00
7092d2d40d
COPR setup
...
Changing the spec file location and adding a COPR Makefile
so the package can get a dynamic name.
Signed-off-by: baude <bbaude@redhat.com>
2018-02-08 13:38:41 -06:00
851bdc3251
Merge pull request #314 from baude/ginkgo_last
...
Final ginkgo migration
2018-02-08 14:19:58 -05:00
c089cb9c92
Final ginkgo migration
...
Completion of the migration from bats to ginkgo. This includes:
* load
* mount
* pause
* port
* run_networking
* search
Note: build will be done within a different PR
Signed-off-by: baude <bbaude@redhat.com>
2018-02-08 12:37:07 -06:00
5529143877
Merge pull request #302 from rhatdan/cleanup
...
cleanup network stack as well as storage when container shuts down.
2018-02-08 13:35:43 -05:00
2a58bdc89d
Merge pull request #311 from baude/updateTutorial
...
docs/tutorials/podman_tutorial.md
2018-02-08 13:12:25 -05:00
3921f10a72
cleanup network stack as well as storage when container shuts down.
...
This patch will cleanup the network stack when the container exits
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2018-02-08 06:42:21 -05:00
8fdccb7764
remove shebang from bash completion
...
shebang presence causes rpmlint error:
"non-executable-script
/usr/share/bash-completion/completions/podman 644 /bin/bash"
completions aren't executable in themselves so there's no need for
a shebang there.
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Closes : #313
Approved by: rhatdan
2018-02-08 11:25:37 +00:00
e47c2e390a
Merge pull request #293 from rhatdan/sd_notify
...
Need to add LISTEN_PID environment variable to conmon command
2018-02-07 18:59:50 -05:00
dd9ecc7a23
Merge pull request #290 from umohnani8/templates
...
Fix when the --format flag prints a new line at the end
2018-02-07 16:50:23 -05:00
c40888cf9f
Merge pull request #300 from baude/ginkgo_version
...
More ginkgo migration
2018-02-07 16:49:56 -05:00
5e8fcbcd29
Merge pull request #310 from baude/copr
...
Add the spec file to podman
2018-02-07 15:13:49 -06:00
11eb18cec6
Merge pull request #309 from mheon/pause_state_error
...
Change pause so only running containers are valid
2018-02-07 16:07:46 -05:00
4cfd0f50fb
docs/tutorials/podman_tutorial.md
...
Update now that more of the podman commands are working
correctly, esp top and friends.
Signed-off-by: baude <bbaude@redhat.com>
2018-02-07 15:07:31 -06:00
d26023e4a8
More ginkgo migration
...
* attach
* run_exit
* save
* tag
* version
* run_privileged -> privileged
Signed-off-by: baude <bbaude@redhat.com>
2018-02-07 14:55:20 -06:00
590084d0bd
Add the spec file to podman
...
Taking the fedora spec file and adding it to the git repo
for copr
Signed-off-by: baude <bbaude@redhat.com>
2018-02-07 14:16:17 -06:00
588c9bb5de
Merge pull request #289 from TomSweeneyRedHat/dev/tsweeney/username
...
Change un/pwd handling to match Buildah's
2018-02-07 14:07:54 -05:00
6716581545
Merge pull request #303 from umohnani8/certs
...
Change default certs dir to /etc/containers/certs.d
2018-02-07 14:06:25 -05:00
ca7ebcac64
Change pause so only running containers are valid
...
Signed-off-by: Matthew Heon <mheon@redhat.com>
2018-02-07 10:47:43 -05:00
363cfcb0ce
Fix when the --format flag prints a new line at the end
...
If the output is to a terminal, return a new line at the end of the
output so that the output is visually appealing. If the output is being
piped, or saved to a file, basically not being outputted to a terminal, do
not print a new line at the end of the output. This ensures any further data
manipulation with the results happens smoothly without requiring to remember
the '/n' at the end of the output.
Signed-off-by: umohnani8 <umohnani@redhat.com>
2018-02-07 10:43:16 -05:00
3f0170227d
Merge pull request #307 from rhatdan/sudo
...
Change sudo examples to use $ instead of $
2018-02-07 10:24:51 -05:00
1fde1a0de7
Change sudo examples to use $ instead of $
...
sudo is not required when running as root, and # indicates
that you are already root. $ indicates you are not root.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2018-02-07 09:34:04 -05:00
8fbfb93947
Error on attempting to restart container
...
Signed-off-by: Matthew Heon <mheon@redhat.com>
Closes : #304
Approved by: baude
2018-02-07 01:56:11 +00:00
fff9a1ee20
Change default certs dir to /etc/containers/certs.d
...
Updated man pages to reflect the change
Signed-off-by: umohnani8 <umohnani@redhat.com>
2018-02-06 17:10:10 -05:00
2df8a32352
Vendor in latest containers/image
...
Changes the default certs directory to /etc/containers/certs.d
Signed-off-by: umohnani8 <umohnani@redhat.com>
2018-02-06 17:09:02 -05:00
367213a394
Match podman inspect output to docker inspect
...
Made a change to make sure that the output paths of podman inspect
matches that of docker inspect. For example to get the stop signal
you should be able to do podman inspect ctr --format {{.Config.StopSignal}}
and the same thing in docker will give the same results.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes : #292
Approved by: rhatdan
2018-02-06 19:31:55 +00:00
69d75a8251
Touchup podman kill manpage
...
Signed-off-by: Matthew Heon <mheon@redhat.com>
Closes : #299
Approved by: rhatdan
2018-02-06 19:03:57 +00:00
d20c1a9911
Change stop signal default to SIGTERM
...
Signed-off-by: Matthew Heon <mheon@redhat.com>
Closes : #299
Approved by: rhatdan
2018-02-06 19:03:57 +00:00
0d7e6fa22f
Add podman search command
...
podman search queries a registry for a matching image and prints
the output.
I added a new flag called "registry" giving the user the option
to search a specific registry if they don't want to search all
their default registries.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes : #241
Approved by: rhatdan
2018-02-06 18:09:31 +00:00
1a48a7a7c0
Vendor in latest containers/image
...
Latest containers/image has support for searching registries.
Signed-off-by: umohnani8 <umohnani@redhat.com>
Closes : #241
Approved by: rhatdan
2018-02-06 18:09:31 +00:00
31c56e2b9c
avoid period character at the beginning of newline
...
Otherwise causes rpmlint error for manpage
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Closes : #296
Approved by: baude
2018-02-06 16:18:49 +00:00