17236 Commits

Author SHA1 Message Date
0d270ae380 support podman-remote to connect tcpURL with proxy
1. proxy value from env `CONTAINER_PROXY`
2. proxy socks5 && socks5h is supported
3. the proxy dial timeout is 3s

Signed-off-by: shuai.yang <shuai.yang@mihoyo.com>
2022-11-17 18:12:52 +08:00
607cd39e15 Removing the RawInput from the API output
Including the RawInput in the API output is meaningless.

Fixes: #16497

[NO NEW TESTS NEEDED]

Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
2022-11-17 15:41:01 +09:00
14ef6a91bd fix port issues for CONTAINER_HOST
if no port is specified for an ssh style url, default to 22

resolves #16509

Signed-off-by: Charlie Doern <cdoern@redhat.com>
2022-11-16 11:01:30 -05:00
34020b353a CI: Package versions: run in the 'main' step
...not as a separate post-main step. Reasons:

 1) If main test times out, Cirrus won't run subsequent steps
 2) It really belongs in the main log anyway, because when
    looking at test results, you want to have instant access
    to versions, you don't want to have to clickety-click
    ten steps.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-11-16 06:52:07 -07:00
54b1fd35bd Merge pull request #16518 from ashley-cui/noout
Fix podman --noout to suppress all output
2022-11-15 21:57:33 +00:00
d1ac0dcd49 Merge pull request #16513 from vrothberg/fix-16502
remove pod if creation has failed
2022-11-15 21:54:57 +00:00
7cd3baeb13 Merge pull request #16186 from ashley-cui/shh
Add --quiet and --no-info flags to podman machine start
2022-11-15 21:52:25 +00:00
a53e152d36 Merge pull request #16503 from cevich/reuse_workflows
[skip-ci] Reuse workflows
2022-11-15 14:21:21 -05:00
db34c913b8 build(deps): bump github.com/rootless-containers/rootlesskit
Bumps [github.com/rootless-containers/rootlesskit](https://github.com/rootless-containers/rootlesskit) from 1.0.1 to 1.1.0.
- [Release notes](https://github.com/rootless-containers/rootlesskit/releases)
- [Commits](https://github.com/rootless-containers/rootlesskit/compare/v1.0.1...v1.1.0)

---
updated-dependencies:
- dependency-name: github.com/rootless-containers/rootlesskit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-11-15 13:55:02 -05:00
5502ddb3c5 Merge pull request #16506 from edsantiago/healthcheck_flake
healthcheck system tests: try to fix flake
2022-11-15 16:28:15 +00:00
4c1294ccb7 pkg/domain: Make checkExecPreserveFDs platform-specific
Also add a FreeBSD version.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
2022-11-15 16:27:33 +00:00
320d507517 Merge pull request #16522 from edsantiago/podman_restart_flake
e2e tests: fix restart race
2022-11-15 16:23:05 +00:00
58869dcc30 e2e tests: fix restart race
It's so easy to forget that "podman start" is nonblocking.
So podman create, start, restart has a race where "restart"
can run before the container actually starts.

Solution: start --attach. Thanks to @vrothberg for noticing that.

There are still a handful of other suspicious-looking restarts
in this test, but all involve "top" which of course has to be
detached. Since those don't have any flakes that I know of, I
choose to ignore them.

Fixes: #16505

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-11-15 07:44:52 -07:00
7c1ad8a582 Fix podman --noout to suppress all output
Podman --noout was not suppressing output from commands that do not
create the podman engine. Now, podman --noout properly suppresses output
from every command.

Fixes: https://github.com/containers/podman/issues/16201

Signed-off-by: Ashley Cui <acui@redhat.com>
2022-11-15 08:16:46 -05:00
6c37cf3324 Merge pull request #16380 from flouthoc/compat-build-fix
compat,build: handle `docker's` preconfigured `cacheTo`,`cacheFrom`
2022-11-15 12:44:50 +00:00
9610d4c7b4 remove pod if creation has failed
Make sure to remove the pod if its creation has failed.

Fixes: #16502
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2022-11-15 13:36:57 +01:00
b73c0f253a Merge pull request #16507 from edsantiago/more_logs_flakes
Fix more podman-logs flakes
2022-11-15 08:48:24 +00:00
f36b3bc811 pkg/rootless: Implement rootless.IsFdInherited on FreeBSD
This is needed to support --preserve-fds in create and exec.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
2022-11-15 08:18:41 +00:00
0253d3cca2 Merge pull request #16504 from giuseppe/add-check-for-ESRCH
libpod: treat ESRCH from /proc/PID/cgroup as ENOENT
2022-11-15 07:08:43 +00:00
ee1c92108c Merge pull request #16489 from Luap99/pasta-docs
[CI:DOCS] docs: deprecate pasta network name
2022-11-14 21:28:31 +00:00
725f17bb6f Merge pull request #16495 from dfr/freebsd-unit-test
Fix unit tests for FreeBSD
2022-11-14 21:23:21 +00:00
21f6902ec3 Fix more podman-logs flakes
No issue filed, because I thought these were related to 16132.
They're not: they're actual test bugs, running "play kube"
without actually waiting for the container to run. Fix that.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-11-14 13:09:45 -07:00
1a839a96dc healthcheck system tests: try to fix flake
Weird one-off flake seen:

   # ... healthcheck run <containername>
   Error: container SHA is not running

The only way I can see this happening is if the healthcheck
auto-timer triggered, which seems impossible because that
should be 30s and the log timestamps show this test taking
18s. But, shrug, let's see if disabling the timer works. I
don't have high hopes that this will fix anything, but it's
probably a good idea regardless.

Also, since this test loops over different policies, include
policy name in error messages as a courtesy. (It's obtainable
anyway by scrolling up)

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-11-14 12:33:34 -07:00
36f8dfaa0d libpod: treat ESRCH from /proc/PID/cgroup as ENOENT
when reading from the /proc/$PID/cgroup file, treat ESRCH in the same
way as ENOENT since the kernel returns ESRCH if the file was opened
correctly but the target process exited before the open could be
performed.

Closes: https://github.com/containers/podman/issues/16383

[NO NEW TESTS NEEDED] it is a race condition that is difficult to
reproduce.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-11-14 20:15:48 +01:00
021a23b349 GHA: Configure workflows for reuse
It's possible to reuse a GHA workflow from another repo with minimal
YAML.  However there are certain requirements, like spelling out all the
required secret values.  Also any mention of `ACTIONS_STEP_DEBUG` will
cause failures and must be removed.

As usual, there's no convenient way to test these changes without pushing
to a `main` branch somewhere that also has all the proper secrets
configured.  However, I did pattern these changes off of a working setup
in buildah:

fd2d05c0a7/.github/workflows/check_cirrus_cron.yml

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-11-14 13:52:03 -05:00
c7073b5fc5 compat,build: handle docker's preconfigured cacheTo,cacheFrom
Docker's newer clients popuates `cacheFrom` and `cacheTo` parameter
by default as empty array for all commands but buildah's design of
distributed cache expects this to be a repo not image hence parse
only the first populated repo and igore if empty array.

Signed-off-by: Aditya R <arajan@redhat.com>
2022-11-14 22:08:09 +05:30
dceaa7603f docs: deprecate pasta network name
Since pasta is now considered a network mode using it as network name
causes a conflict. For now we will prefer the named network but in a
future major version bump we want to remove this and just use pasta(1).

The docs should reflect that this name is considered deprecated.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-11-14 16:14:47 +01:00
43cef625b5 Merge pull request #16496 from anjannath/bump-qemu
pkginstaller: bump Qemu to version 7.1.0
2022-11-14 15:02:21 +00:00
da6f2657e5 Merge pull request #16434 from flouthoc/wasm-hook
specgen,wasm: switch to crun-wasm wherever applicable
2022-11-14 14:53:39 +00:00
a9852aa8ff utils: Enable cgroup utils for FreeBSD
This probably makes sense when using podman-remote and it lets the unit
tests pass which makes 'make localunit' happy.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
2022-11-14 14:22:36 +00:00
e5f7fbcbe6 pkg/specgen: Disable kube play tests on FreeBSD
We are a long way from being able to run Kubernetes on FreeBSD.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
2022-11-14 14:22:36 +00:00
978c528500 libpod/lock: Fix build and tests for SHM locks on FreeBSD
On FreeBSD, the path argument to shm_open is not a filesystem path and we
must use shm_unlink to remove it. This changes the Linux build to also use
shm_unlink which avoids assuming that shared memory segments live in
/dev/shm.

Signed-off-by: Doug Rabson <dfr@rabson.org>
2022-11-14 14:22:36 +00:00
94e34cc795 Merge pull request #16498 from vrothberg/fix-16421
podman cp: fix copying with "." suffix
2022-11-14 13:46:44 +00:00
e656cf43fe Merge pull request #16328 from cdoern/config
fix connection usage with containers.conf
2022-11-14 12:46:03 +00:00
bd73050ad2 Merge pull request #16492 from rhatdan/VENDOR
Vendor in latest containers/(common,image,storage)
2022-11-14 12:34:32 +00:00
3371c9d25e podman cp: fix copying with "." suffix
Fix a bug for special-casing "." where Podman has mistakenly been
looking for a "." suffix instead of interpreting it as a path.

Add regression tests for the host-to-container, container-to-host and
container-to-container use cases.  Have separate tests for each to
verify that previous Podman versions fail each case.

Fixes: #16421
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2022-11-14 09:38:02 +01:00
f0dba82bb3 pkginstaller: bump Qemu to version 7.1.0
this updates the Makefile qemu version to make use new qemu released at
https://github.com/containers/podman-machine-qemu/releases/tag/v7.1.0-1

[NO NEW TESTS NEEDED]

Signed-off-by: Anjan Nath <kaludios@gmail.com>
2022-11-14 11:59:06 +05:30
f6da2b0608 specgen,wasm: switch to crun-wasm wherever applicable
Whenever image has `arch` and `os` configured for `wasm/wasi` switch to
`crun-wasm` as extension if applicable, following will only work if
`podman` is using `crun` as default runtime.

[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
A test for this can be added when `crun-wasm` is part of CI.

Signed-off-by: Aditya R <arajan@redhat.com>
2022-11-14 11:36:34 +05:30
2b4068a039 vendor: bump c/common to v0.50.2-0.20221111184705-791b83e1cdf1
Signed-off-by: Aditya R <arajan@redhat.com>
2022-11-14 11:36:04 +05:30
f50ce4aea4 Merge pull request #16473 from containers/dependabot/go_modules/github.com/onsi/gomega-1.24.1
Bump github.com/onsi/gomega from 1.24.0 to 1.24.1
2022-11-13 12:17:14 +00:00
1c79b01f6b libpod: Make unit test for statToPercent Linux only
This function is only used by info_linux.go.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
2022-11-13 10:56:15 +00:00
95bb6efffc Update vendor of containers/storage
Signed-off-by: Doug Rabson <dfr@rabson.org>
2022-11-13 10:56:14 +00:00
25c67d6b9b Merge pull request #16462 from rhatdan/manifest
Add hidden podman manifest inspect -v option
2022-11-12 10:51:53 +00:00
d8f483284e Merge pull request #16467 from rhatdan/volume
Add podman volume create -d short option for driver
2022-11-12 10:46:31 +00:00
69d737ef15 fix connection usage with containers.conf
--connection was failing due to the servicedestinations array being empty on runtime.
Fix by making sure the cached config is used

resolves #16282

Signed-off-by: Charlie Doern <cdoern@redhat.com>
2022-11-11 16:15:02 -05:00
dd98e3cc64 Add --quiet and --no-info flags to podman machine start
Add quiet and no-info flags to podman machine start.
No-info suppresses helpful informational tips
Quiet suppresses machine start progress output, as well as informational
tips.

Signed-off-by: Ashley Cui <acui@redhat.com>
2022-11-11 16:14:20 -05:00
00b2bc9b65 Add hidden podman manifest inspect -v option
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-11-11 15:22:31 -05:00
05c48402b2 Bump github.com/onsi/gomega from 1.24.0 to 1.24.1
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.24.0 to 1.24.1.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.24.0...v1.24.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-11-11 15:18:35 -05:00
836ca6c008 Add podman volume create -d short option for driver
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-11-11 14:43:07 -05:00
5df00c6f79 Vendor in latest containers/(common,image,storage)
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-11-11 14:40:03 -05:00