101571dc6b
Merge pull request #10093 from eriksjolund/fix_markdown_table_bug
...
[CI:DOCS] Fix Markdown table layout bugs
2021-04-20 22:14:53 -04:00
c1f117e526
[CI:DOCS] Fix Markdown table layout bugs
...
* Fix the Markdown table layout bugs that manifest themselves in
corrupted tables in the generated HTML pages
http://docs.podman.io/en/latest/markdown/podman-create.1.html
http://docs.podman.io/en/latest/markdown/podman-run.1.html
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2021-04-20 22:18:44 +02:00
659dc7843c
podman-remote should show podman.sock info
...
Currently podman-remote info does not show socket information.
Fixes: https://github.com/containers/podman/issues/10077
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-04-20 15:56:45 -04:00
fd9dd7065d
rmi: don't break when the image is missing a manifest
...
In libpod/image.Image.Remove(), if the attempt to find the image's
parent fails for any reason, log a warning and proceed as though it
didn't have one instead of failing, which would leave us unable to
remove the image without resetting everything.
In libpod/Runtime.RemoveImage(), if we can't determine if an image has
children, log a warning, and assume that it doesn't have any instead of
failing, which would leave us unable to remove the image without
resetting everything.
In pkg/domain/infra/abi.ImageEngine.Remove(), when attempting to remove
all images, if we encounter an error checking if a given image has
children, log a warning, and assume that it doesn't have any instead of
failing, which would leave us unable to remove the image without
resetting everything.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2021-04-20 15:44:39 -04:00
2a32fc3e40
Merge pull request #10072 from eriksjolund/rewrite_uidmap_documenation
...
[CI:DOCS] Rewrite --uidmap doc in podman-create.1.md and podman-run.1.md
2021-04-20 15:07:11 -04:00
6e5bb9d1d3
[CI:DOCS] Rewrite --uidmap doc in podman-create.1.md and podman-run.1.md
...
Introduce the concept of "intermediate UID" to explain
how --uidmap works when running rootless.
Add Markdown tables to show examples of how UIDs are mapped.
Co-authored-by: Tom Sweeney <tsweeney@redhat.com>
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2021-04-20 20:28:11 +02:00
db7cff8c86
Add support for CDI device configuration
...
- Persist CDIDevices in container config
- Add e2e test
- Log HasDevice error and add additional condition for safety
Signed-off-by: Sebastian Jug <seb@stianj.ug>
2021-04-20 09:18:52 -04:00
cf2c3a1f13
Merge pull request #10087 from TomSweeneyRedHat/dev/tsweeney/quickimportfix
...
[CI:DOCS] Add missing dash to verbose option
2021-04-19 22:28:04 -04:00
d84422e14e
Merge pull request #10085 from containers/dependabot/go_modules/github.com/uber/jaeger-client-go-2.27.0incompatible
...
Bump github.com/uber/jaeger-client-go from 2.25.0+incompatible to 2.27.0+incompatible
2021-04-19 16:38:04 -04:00
7f6bcc2008
[CI:DOCS] Add missing dash to verbose option
...
The `--verbose` option in the import man page was
missing a dash, this corrects it.
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2021-04-19 16:24:52 -04:00
a94360a3f7
Merge pull request #10041 from chenk008/add_pidfile_flag
...
Add flag "--pidfile" for podman create/run
2021-04-19 16:22:05 -04:00
37a00c9964
Bump github.com/uber/jaeger-client-go
...
Bumps [github.com/uber/jaeger-client-go](https://github.com/uber/jaeger-client-go ) from 2.25.0+incompatible to 2.27.0+incompatible.
- [Release notes](https://github.com/uber/jaeger-client-go/releases )
- [Changelog](https://github.com/jaegertracing/jaeger-client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/uber/jaeger-client-go/compare/v2.25.0...v2.27.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-19 17:12:04 +00:00
b5e0b292bf
Merge pull request #10056 from mheon/misc_cleanup
...
[NO TESTS NEEDED] Make an advanced layer diff function private
2021-04-19 10:51:58 -04:00
a917bae67d
Merge pull request #10025 from zhangguanzhang/remote-save-dir
...
Fixes podman-remote save to directories does not work
2021-04-19 10:22:52 -04:00
db21c1c0ea
Remove an advanced layer diff function
...
Noticed this while I was poking around in the runtime doing DB
work. The signature of this function makes me a bit uncomfortable
(why should we let people apply arbitrary diffs to layers? Seems
like a good way to break things...) and it's completely unused,
so let's just remove it.
[NO TESTS NEEDED] since this is a pure removal.
Signed-off-by: Matthew Heon <mheon@redhat.com>
2021-04-19 09:17:04 -04:00
69085570f7
Merge pull request #10070 from TomSweeneyRedHat/dev/tsweeney/fixintrotypo
...
[CI:DOCS] Fix introduction page typo
2021-04-19 06:39:53 -04:00
21ae073034
Merge pull request #10069 from EduardoVega/clean-mounts-9618
...
Ensure mount destination is clean, no trailing slash
2021-04-19 05:01:52 -04:00
18d462c41b
Ensure mount destination is clean, no trailing slash
...
Signed-off-by: Eduardo Vega <edvegavalerio@gmail.com>
2021-04-18 09:57:04 -06:00
4ffaa50d05
add it for inspect pidfile
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-18 21:29:12 +08:00
53a1edc3db
[CI:DOCS] Fix introduction page typo
...
Fixes a small typo on the introduction pages.
Fixes : #10042
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2021-04-17 15:13:16 -04:00
a35e16c234
support pidfile on container restore
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-18 00:02:50 +08:00
a1002beb78
fix start it
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 23:35:27 +08:00
4ce7aa6ee8
skip pidfile test on remote
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 22:30:43 +08:00
022bf589c8
improve document
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 21:25:11 +08:00
728b73d7c4
set pidfile default value int containerconfig
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 21:15:23 +08:00
b963a5eb4a
add pidfile in inspection
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 20:56:08 +08:00
f3f7ae5cdd
add pidfile it for container start
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 20:42:21 +08:00
c9f347e9a8
skip pidfile it on remote
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 20:33:37 +08:00
6ff56ab50a
Merge pull request #10018 from jmguzik/more-network-bindings-tests
...
Add network bindings tests: remove and list
2021-04-17 06:35:49 -04:00
676c33f079
Merge pull request #10043 from Luap99/play-kube-ip
...
add --ip to podman play kube
2021-04-17 05:52:51 -04:00
80c1dd0651
Modify according to comments
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 16:08:08 +08:00
6af4c08a50
WIP: drop test requirement
...
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2021-04-16 17:45:52 -04:00
90d7f67138
runtime: bump required conmon version
...
2.0.24 introduced the new behavior with --full-attach, allowing podman to no longer use the socketDir
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2021-04-16 17:45:52 -04:00
b2c6663a9f
runtime: return findConmon to libpod
...
I believe moving the conmon probing code to c/common wasn't the best strategy.
Different container engines have different requrements of which conmon version is required
(based on what flags they use).
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2021-04-16 17:45:52 -04:00
452b9e204f
oci: drop ExecContainerCleanup
...
without the socketsDir, we no longer need to worry about cleaning up after an exec.
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2021-04-16 17:45:52 -04:00
fdfff1dab2
oci: use --full-path option for conmon
...
and stop relying on socket path
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2021-04-16 17:45:52 -04:00
6708bc235f
use AttachSocketPath when removing conmon files
...
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2021-04-16 17:45:52 -04:00
f331c9445f
hide conmon-pidfile flag on remote mode
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-16 23:10:19 +08:00
35b62ef19f
Merge pull request #10050 from Luap99/image-prune-panic
...
Fix possible panic in libpod/image/prune.go
2021-04-16 07:43:38 -04:00
12bcfa360d
Fix possible panic in libpod/image/prune.go
...
podman image prune paniced locally for me. The error handling was not
done correctly and we could end up with a nil pointer dereference.
[NO TESTS NEEDED] I have no idea how I could force an error in img.Size().
Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-04-16 11:21:47 +02:00
4c88035f09
Merge pull request #10021 from zhangguanzhang/invalid-save-expression
...
Fix invalid expression in save command
2021-04-16 04:28:14 -04:00
d7292dbf27
add --ip to podman play kube
...
Add a new --ip flag to podman play kube. This is used to specify a
static IP address which should be used for the pod. This option can be
specified several times because play kube can create more than one pod.
Fixes #8442
Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-04-16 09:55:03 +02:00
e16200ac9f
add flag autocomplete
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-16 15:52:59 +08:00
4fb5fee412
add ut
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-16 15:12:57 +08:00
8fbe06b8cb
add flag "--pidfile" for podman create/run
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-16 13:43:14 +08:00
b82ae19acf
Merge pull request #10046 from edsantiago/bats
...
system tests: build --pull-never: deal with flakes
2021-04-16 01:19:12 -04:00
1af1c35efb
Add network bindings tests: remove and list
...
Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
2021-04-15 22:41:06 +02:00
373f15f617
Merge pull request #10010 from lsm5/GO111MODULE-OFF-fix-build
...
fix build with with GO111MODULE=off
2021-04-15 16:03:10 -04:00
f7ab6b8554
Merge pull request #10045 from Luap99/compose-test-debug
...
compose test: diagnose flakes v3
2021-04-15 15:18:09 -04:00
81ce39f10b
Merge pull request #10044 from Luap99/fix-10015
...
podman play kube apply correct log driver
2021-04-15 14:26:09 -04:00
