11923 Commits

Author SHA1 Message Date
f65d9309cb Merge pull request #10270 from rhatdan/mtab
Create the /etc/mtab file if does not exists
2021-05-17 15:35:20 -04:00
cf30f160ad Support uid,gid,mode options for secrets
Support UID, GID, Mode options for mount type secrets. Also, change
default secret permissions to 444 so all users can read secret.

Signed-off-by: Ashley Cui <acui@redhat.com>
2021-05-17 14:35:55 -04:00
0a3444613e Merge pull request #10328 from Luap99/completions
Several shell completion fixes
2021-05-17 14:11:20 -04:00
93c3e03227 Merge pull request #10363 from vrothberg/fix-10350
image prune: remove unused images only with `--all`
2021-05-17 11:17:21 -04:00
62a7d4b61e Merge pull request #9972 from bblenard/issue-5651-hostname-for-container-gateway
Add host.containers.internal entry into container's etc/hosts
2021-05-17 10:45:23 -04:00
9d2bc4cae8 Merge pull request #10356 from Luap99/network-reload-rootless
podman network reload add rootless support
2021-05-17 10:21:20 -04:00
0d811b2339 Several shell completion fixes
- fix network filters
- add prune filters
- pod create --share support comma separated namespaces

[NO TESTS NEEDED]

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-17 15:56:11 +02:00
c8dfcce6db Add host.containers.internal entry into container's etc/hosts
This change adds the entry `host.containers.internal` to the `/etc/hosts`
file within a new containers filesystem. The ip address is determined by
the containers networking configuration and points to the gateway address
for the containers networking namespace.

Closes #5651

Signed-off-by: Baron Lenardson <lenardson.baron@gmail.com>
2021-05-17 08:21:22 -05:00
6efca0bbac Ensure that :Z/:z/:U can be used with named volumes
Docker allows relabeling of any volume passed in via -v, even
including named volumes. This normally isn't an issue at all,
given named volumes get the right label for container access
automatically, but this becomes an issue when volume plugins are
involved - these aren't managed by Podman, and may well be
unaware of SELinux labelling. We could automatically relabel
these volumes on creation, but I'm still reluctant to do that
(feels like it could break things). Instead, let's allow :z and
:Z to be used with named volumes, so users can explicitly request
relabel of a volume plugin-backed volume.

We also get :U at the same time. I don't see any real need for it
but it also doesn't seem to hurt, so I didn't bother disabling
it.

Fixes #10273

Signed-off-by: Matthew Heon <mheon@redhat.com>
2021-05-17 09:10:59 -04:00
2a43fcf786 image prune: remove unused images only with --all
Fix a regression in `podman image prune` where unused images were
accidentally removed even when `--all=false`.  Extend and partially
rewrite the e2e tests to make sure we're not regressing again in the
future.

Fixing the aforementioned issue revealed another issue in the default
prune filter.  While prune should remove all "dangling" images (i.e.,
those without tag), it removed only "intermediate" ones; dangling images
without children.  Remove the mistaken comment from the libimage
migration.

Also clarify the help message and man page.

Fixes: #10350
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-05-17 13:52:03 +02:00
4462113c5e podman network reload add rootless support
Allow podman network reload to be run as rootless user. While it is
unlikely that the iptable rules are flushed inside the rootless cni
namespace, it could still happen. Also fix podman network reload --all
to ignore errors when a container does not have the bridge network mode,
e.g. slirp4netns.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-17 10:55:02 +02:00
3bdbe3ce96 Merge pull request #10357 from srcshelton/patch-1
Update to actions/stale@v3
2021-05-17 03:30:18 -04:00
60eb4e74d1 Use more recent stale release...
… as currently with `v1`, `remove-stale-when-updated` is set but isn't causing labels to be updated when comments are added.

Signed-off-by: Stuart Shelton <stuart@shelton.me>
2021-05-16 19:02:18 +01:00
4cc19f9e0f Support automatic labeling of kube volumes
Allow users to specify options on the volume mount path.
This will trigger relabels of user specifies :z,:Z
Also will handle User Relabels if the user specifies :U

Fixes: https://github.com/containers/podman/issues/9371

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-05-16 07:09:22 -04:00
a6a3df0273 Merge pull request #10346 from Luap99/network-doc
[CI:DOCS] network tutorial: update with rootless cni changes
2021-05-16 07:02:17 -04:00
460182dc5d network tutorial: update with rootless cni changes
Starting with podman v3.2 rootless cni will work without the
rootless-cni-infra container. Update the network tutorial to reflect the
latest changes and mention that the infra container can be removed.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-15 22:46:53 +02:00
90a12acb7e Merge pull request #10332 from TomSweeneyRedHat/dev/tsweeney/fixintro
[CI:DOCS] Update first line in intro page
2021-05-15 04:07:16 -04:00
b75bb4665e Create the /etc/mtab file if does not exists
We should create the /etc/mtab->/proc/mountinfo link
so that mount command will work within the container.

Docker does this by default.

Fixes: https://github.com/containers/podman/issues/10263

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-05-15 03:56:38 -04:00
757ed8fd02 [CI:DOCS] Update first line in intro page
Remove the word `consumption` and give a better description for the
first line of the introduction page.

Fixes: #10325

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2021-05-14 17:08:35 -04:00
2b0b97150a Merge pull request #10341 from vrothberg/auto-update-prune
auto-update service: prune images
2021-05-14 15:36:38 -04:00
ed003617b2 Merge pull request #10343 from cevich/update_vm_images
Use updated VM images + updated automation tooling
2021-05-14 15:35:39 -04:00
ae72aedf40 Use updated VM images + updated automation tooling
Both the `containers/automation` and `containers/automation_images` have
been updated with a default 'main' branch, renamed from 'master`.  These
images include adjusted tooling in addition to a refresh of all
packages.

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-05-14 14:05:27 -04:00
fabaa25667 Merge pull request #10254 from jmguzik/prune-filter-cli
Add support for cli network prune --filter flag
2021-05-14 13:12:40 -04:00
9738f63bac auto-update service: prune images
Extend the systemd auto-update service to prune images after an update
has run.  As reported by a user [1], auto updates can over time cause
the disk to run out of space.  With Edge being a target use case, we
need to make sure that systems can run without much supervision, so
let's make sure to run `podman image prune` to clean up dangling images.

[1] https://twitter.com/r_isc_y/status/1388981737011793921

Fixes: #10190
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-05-14 14:32:43 +02:00
d05cc0a04a Merge pull request #10331 from redhat-et/vendor
Update go.sum
2021-05-14 06:32:31 -04:00
b9b386075b make vendor
Signed-off-by: Ivan Font <ifont@redhat.com>
2021-05-13 10:07:23 -07:00
4dc52f61cc Merge pull request #10316 from containers/dependabot/go_modules/github.com/containers/storage-1.30.3
Bump github.com/containers/storage from 1.30.2 to 1.30.3
2021-05-12 20:53:08 -04:00
0762970096 Merge pull request #10294 from Luap99/system-upgrade-tests
fix system upgrade tests
2021-05-12 19:54:45 -04:00
a31a1f5942 Merge pull request #10300 from jwhonce/issues/10289
Add host.serviceIsRemote to podman info results
2021-05-12 18:06:46 -04:00
7b59119c47 Merge pull request #10239 from alvistack/master-linux-amd64
Update nix pin with `make nixpkgs`
2021-05-12 18:00:46 -04:00
c5e7caaec1 Merge pull request #10313 from edsantiago/bats
[CI:DOCS] hack/bats - new helper for running system tests
2021-05-12 17:09:47 -04:00
071799f259 Merge pull request #10324 from containers/uncompressing
[NO TESTS NEEDED] Print "extracting" only on compressed file
2021-05-12 16:10:48 -04:00
d6507fcfbc Merge pull request #10222 from vrothberg/image-tree
podman image tree: restore previous behavior
2021-05-12 15:59:46 -04:00
5992c76f8f fix system upgrade tests
Fix many FIXMEs in the upgrade tests. Also add a basic test for pods.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-12 21:45:43 +02:00
01f6e4b53e Print "extracting" only on compressed file
We should only print "extracting compressed file" when the file is
actually compressed

Signed-off-by: Ashley Cui <acui@redhat.com>
2021-05-12 14:35:49 -04:00
d32863bbb4 podman image tree: restore previous behavior
The initial version of libimage changed the order of layers which has
now been restored to remain backwards compatible.

Further changes:

 * Fix a bug in the journald logging which requires to strip trailing
   new lines from the message.  The system tests did not pass due to
   empty new lines.  Triggered by changing the default logger to
   journald in containers/common.

 * Fix another bug in the journald logging which embedded the container
   ID inside the message rather than the specifid field.  That surfaced
   in a preceeding whitespace of each log line which broke the system
   tests.

 * Alter the system tests to make sure that the k8s-file and the
   journald logging drivers are executed.

 * A number of e2e tests have been changed to force the k8s-file driver
   to make them pass when running inside a root container.

 * Increase the timeout in a kill test which seems to take longer now.
   Reasons are unknown.  Tests passed earlier and no signal-related
   changes happend.  It may be CI VM flake since some system tests but
   other flaked.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-05-12 17:56:59 +02:00
d8dc56ba67 Merge pull request #10318 from Luap99/fix-network-test
fix network restart always test
2021-05-12 07:46:46 -04:00
e1d6e65536 Merge pull request #10317 from Luap99/fix-log-driver
fix incorrect log driver in podman container image
2021-05-12 07:13:46 -04:00
fa6b6b873f fix network restart always test
The added test in 30544f225e73 is flaking. Podman inspect is always
working so we have to check the pid instead.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-12 11:27:39 +02:00
439a515026 fix incorrect log driver in podman container image
Commit 7f2c27d43fc5 added an invalid value for the log_driver in the
containers.conf file inside the podman image.

Fixes #10312

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-12 09:34:59 +02:00
5e6405334c Add support for cli network prune --filter flag
Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
2021-05-12 09:05:06 +02:00
3aae346946 Move filter parsing to common utils
Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
2021-05-12 08:35:59 +02:00
eccd03f3c4 Bump github.com/containers/storage from 1.30.2 to 1.30.3
Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.30.2 to 1.30.3.
- [Release notes](https://github.com/containers/storage/releases)
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md)
- [Commits](https://github.com/containers/storage/compare/v1.30.2...v1.30.3)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-12 06:22:36 +00:00
9ac124809f Update nix pin with make nixpkgs
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
2021-05-12 09:19:33 +08:00
b18931cef3 [CI:DOCS] hack/bats - new helper for running system tests
Well, new to you. It's been something I've used for years.
Simple, but it takes care of a lot of housekeeping, and
makes it ever-so-much-more pleasant to invoke bats tests.
And when it's easier to run tests, tests get run.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-05-11 16:31:56 -06:00
59dd357509 Merge pull request #10310 from Luap99/restart-slirp
fix restart always with slirp4netns
2021-05-11 18:30:52 -04:00
30544f225e fix restart always with slirp4netns
When a container is automatically restarted due its restart policy and
the container used the slirp4netns netmode, the slirp4netns process
died. This caused the container to lose network connectivity.

To fix this we have to start a new slirp4netns process.

Fixes #8047

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-05-11 22:37:32 +02:00
8dcd5b893f Merge pull request #10304 from containers/dependabot/go_modules/github.com/opencontainers/runc-1.0.0-rc94
Bump github.com/opencontainers/runc from 1.0.0-rc93 to 1.0.0-rc94
2021-05-11 10:36:54 -04:00
58915f2974 Merge pull request #10303 from containers/dependabot/go_modules/github.com/coreos/go-systemd/v22-22.3.2
Bump github.com/coreos/go-systemd/v22 from 22.3.1 to 22.3.2
2021-05-11 10:35:54 -04:00
d71672c57b Bump github.com/opencontainers/runc from 1.0.0-rc93 to 1.0.0-rc94
Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.0.0-rc93 to 1.0.0-rc94.
- [Release notes](https://github.com/opencontainers/runc/releases)
- [Commits](https://github.com/opencontainers/runc/compare/v1.0.0-rc93...v1.0.0-rc94)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-11 06:19:24 +00:00