1106 Commits

Author SHA1 Message Date
7b93e7a3fa Dockerfile.Fedora: use fedora:28 instead of fedora:27
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #729
Approved by: baude
2018-05-05 20:02:22 +00:00
0906b3094d Fix calculation of RunningFor in ps json output
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #727
Approved by: rhatdan
2018-05-05 11:48:06 +00:00
bb0e7540dc Should not error out if container no longer exists in oci
This prevents you from cleaning up the container database, if
some how runc and friends db gets screwed up.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #725
Approved by: mheon
2018-05-04 20:09:17 +00:00
9cb694e094 Make invalid state nonfatal when cleaning up in run
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #726
Approved by: baude
2018-05-04 19:06:47 +00:00
769f8f2d72 test/e2e/run_userns_test.go: new file
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #690
Approved by: mheon
2018-05-04 17:15:55 +00:00
522a7197a8 podman, userNS: configure an intermediate mount namespace
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #690
Approved by: mheon
2018-05-04 17:15:55 +00:00
73078fabcf networking, userNS: configure the network namespace after create
so that the OCI runtime creates the network namespace from the correct
userNS.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #690
Approved by: mheon
2018-05-04 17:15:55 +00:00
b51d737998 Begin wiring in USERNS Support into podman
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #690
Approved by: mheon
2018-05-04 17:15:55 +00:00
1f5debd438 Merge pull request #722 from mheon/bump_0_5_1
Bump to v0.5.1
2018-05-04 11:37:14 -04:00
d04ebf8419 Bump gitvalidation epoch
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-05-04 11:36:36 -04:00
4691706d01 Bump to v0.5.2-dev
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-05-04 11:35:56 -04:00
d0fbfdc0ac Bump to v0.5.1
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
v0.5.1
2018-05-04 11:35:14 -04:00
b44d4fb1ec Fix pulling from secure registry
when pulling from a secure registry that is documented in registries.conf, we
should be able to pull without tls-verify=false

Signed-off-by: baude <bbaude@redhat.com>

Closes: #718
Approved by: rhatdan
2018-05-04 14:13:18 +00:00
c34e454177 Optionally init() during container restart
This allows us to restart containers that have never been started
without error. This makes RestartWithTimeout work with running,
stopped, and created containers.

Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #719
Approved by: rhatdan
2018-05-04 10:57:50 +00:00
5ae940a574 bashcompletion enhancements
* now all podman subcommands can be completed
* images can be completed when run as root (not sudo)
* bug corrected that made podman_top and podman_tag

Signed-off-by: baude <bbaude@redhat.com>

Closes: #716
Approved by: mheon
2018-05-03 19:43:43 +00:00
9fc85522fb Add directory for systemd socket and service if not present
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>

Closes: #717
Approved by: baude
2018-05-03 19:39:41 +00:00
8dfebd4607 varlink containers
first pass at adding in the container related endpoints/methods for the libpod
backend. Couple of important notes:

* endpoints that can use a console are not going to be done until we have "remote" console
* several of the container methods should probably be able to stream as opposed to a one-off return

Signed-off-by: baude <bbaude@redhat.com>

Closes: #708
Approved by: baude
2018-05-03 17:31:33 +00:00
fae5033a01 Make podman commit to localhost rather then docker.io
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #715
Approved by: mheon
2018-05-03 13:12:46 +00:00
e6ec1aaffe Trivial refactor on volume addition
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #700
Approved by: rhatdan
2018-05-03 12:23:12 +00:00
6ebb90f951 When adding volumes to DB, handle nontrivial cases
We want to make sure we don't add anything but the host volume,
and the volumes can include options and container locations.

Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #700
Approved by: rhatdan
2018-05-03 12:23:12 +00:00
dd569a91f4 Add accessors for new image fields in container config
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #700
Approved by: rhatdan
2018-05-03 12:23:12 +00:00
ab7e2a6956 Store user Volumes, Entrypoint, Command in database
We need these for commit, and they cannot be properly deduced
from just the OCI spec, so save them in the database so we can
retrieve them for commit.

Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #700
Approved by: rhatdan
2018-05-03 12:23:12 +00:00
16c997de62 Further fix Godoc comments in options.go
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #700
Approved by: rhatdan
2018-05-03 12:23:12 +00:00
1ece5d3db7 Update hooks to use config bool to detect volume mounts
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #700
Approved by: rhatdan
2018-05-03 12:23:12 +00:00
7137ca81d9 Fix Godoc comments in options.go
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #700
Approved by: rhatdan
2018-05-03 12:23:12 +00:00
a0e8f88700 Add config bool to indicate there are user volumes
This allows us to accurately trigger OCI hooks that trigger on
the presence of volume mounts.

Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #700
Approved by: rhatdan
2018-05-03 12:23:12 +00:00
f6d41abfb0 Print the Buildah comment from commit to given writer
Much better than unconditionally dumping to stdout

Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #706
Approved by: rhatdan
2018-05-03 12:00:17 +00:00
25dc483f00 Do not print unnecessary Buildah details during commit
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>

Closes: #706
Approved by: rhatdan
2018-05-03 12:00:17 +00:00
64dc8039e9 remove options from create/run that we cannot support
Signed-off-by: baude <bbaude@redhat.com>

Closes: #711
Approved by: rhatdan
2018-05-02 18:54:14 +00:00
86e0c87a29 fix typos in the inspect json structs
Resolves: #633

Signed-off-by: baude <bbaude@redhat.com>

Closes: #710
Approved by: rhatdan
2018-05-02 18:02:22 +00:00
03753712fc Fix podman logout --all flag
podman logout --all should remove cached credentials for all registries in
the auth.json file.
Before this, it was asking for a registry to be given with the --all flag also.

Signed-off-by: umohnani8 <umohnani@redhat.com>

Closes: #712
Approved by: rhatdan
2018-05-02 16:55:31 +00:00
970eaf0033 podman should assign a host port to -p when omitted
If the user does not provide a host port when adding -p to create/run, podman should inject an available random port.

podman run -p 80 .... podman should assign a random port to the host and expose the container port 80 to it

Signed-off-by: baude <bbaude@redhat.com>

Closes: #703
Approved by: rhatdan
2018-05-01 21:47:34 +00:00
e98ad5751d Vendor in latest buildah
Adds in --iidfile flag to podman build.

Signed-off-by: umohnani8 <umohnani@redhat.com>

Closes: #707
Approved by: mheon
2018-05-01 20:23:45 +00:00
7a0a8552cb Fix misc stuff found by jhonce
During the python client implementation, jhonce found some return types
that needed correction as well as a panic related to history which is now
corrected.

Signed-off-by: baude <bbaude@redhat.com>

Closes: #704
Approved by: rhatdan
2018-04-30 22:22:08 +00:00
2239093a63 libpod.conf: Podman's conmon path on openSUSE
Add the path to Podman's conmon for openSUSE and SLE.

Signed-off-by: Valentin Rothberg <vrothberg@suse.com>

Closes: #698
Approved by: mheon
2018-04-30 21:58:17 +00:00
40da888274 Add iidfile parame to build and commit man pages
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>

Closes: #693
Approved by: mheon
2018-04-30 21:31:46 +00:00
9924956dc8 do not commit default volumes from container
when performing a container commit, we should not add the default list of volumes
for a container to the resulting image.  it will cause the resulting image to crash
when run subsequently.

Signed-off-by: baude <bbaude@redhat.com>

Closes: #699
Approved by: mheon
2018-04-30 21:07:59 +00:00
c8c39779a7 correct varlink command in service file
The struct of the varlink command changed to accept a URI
as input.  This was never updated in the service file

Signed-off-by: baude <bbaude@redhat.com>

Closes: #691
Approved by: mheon
2018-04-30 20:45:33 +00:00
52ace66e76 Vendor in latest containers/image
Fixes podman pull to pull a public image even if $XDG_RUNTIME_DIR
does not exist for authentication. Public images don't require credentials
to access.

Signed-off-by: umohnani8 <umohnani@redhat.com>

Closes: #701
Approved by: rhatdan
2018-04-30 20:22:29 +00:00
d5d6e68592 Make ':' a restricted character for file names
file names for podman load, save, export, and import cannot
contain ":" in them. It is a reserved character for parsing
filenames.

Signed-off-by: umohnani8 <umohnani@redhat.com>

Closes: #694
Approved by: rhatdan
2018-04-30 19:58:22 +00:00
d1b03f470e Add more validation to --volume flag for run and create
Return error if the host and container  paths is a relative path.
Only absolute paths allowed.

Signed-off-by: umohnani8 <umohnani@redhat.com>

Closes: #695
Approved by: rhatdan
2018-04-30 19:30:57 +00:00
9a2e267637 Fix libseccomp not working in travis
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #697
Approved by: mheon
2018-04-30 14:20:01 +00:00
eda0fd7468 CONTRIBUTING: Document PR approval and link to OWNERS
Remove a dead "Becoming a Maintainer" link and that stub section,
since libpod currently doesn't document that process.  By leaving it
undocumented, maintainer changes falls back to the usual pull-request
review process.

Signed-off-by: W. Trevor King <wking@tremily.us>

Closes: #688
Approved by: rhatdan
2018-04-28 07:45:30 +00:00
13290d65ba OWNERS: rename 'assignees' to 'approvers'
As CRI-O did in [1].  'assignees' is deprecated and 'approvers' is
effectively the same thing [2].

[1]: https://github.com/kubernetes-incubator/cri-o/pull/1103
[2]: https://github.com/kubernetes/test-infra/issues/3851

Signed-off-by: W. Trevor King <wking@tremily.us>

Closes: #688
Approved by: rhatdan
2018-04-28 07:45:30 +00:00
6774425872 Merge pull request #689 from mheon/bump_0_4_4
Bump to v0.4.4
2018-04-27 17:27:06 -04:00
d9cced240b Bump gitvalidation epoch
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-04-27 17:25:27 -04:00
d91b24e2eb Bump to v0.5.1-dev
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-04-27 17:24:46 -04:00
888927abaa Bump to v0.4.4
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
v0.4.4
2018-04-27 17:23:43 -04:00
a824186ac9 Use buildah commit and bud in podman
Vendor in buildah and use as much of commit and bug as possible for podman
build and commit.

Resolves #586
Signed-off-by: baude <bbaude@redhat.com>

Closes: #681
Approved by: mheon
2018-04-27 20:51:07 +00:00
4e468ce83d README: Link to CONTRIBUTING.md
Make that information more easily discoverable.  And since
CONTRIBUTING.md already mentions IRC, we can drop the IRC reference
from the README to DRY things up.

Also update CONTRIBUTING.md to replace the stale #cri-o reference left
over from the initial libpod/podman fork.  While I was touching this
line, I also shuffled some of the wording around to tighten that
sentence up.

Signed-off-by: W. Trevor King <wking@tremily.us>

Closes: #687
Approved by: rhatdan
2018-04-27 19:05:46 +00:00